Use VssHttpClient instead of RawHttpClient (#2328)

* Update runnerversion

* Update releaseNote.md

releaseNote.md

@@ -11,7 +11,7 @@
 - Added the option to use the --replace argument to the create-latest-svc.sh (#2273)
 - Made runner_name optional defaulting to hostname in delete.sh script (#1871)
 - Return exit code when MANUALLY_TRAP_SIG is exported (#2285)
-- Use results for uploading step summaries (#2301)
+- Use results for uploading step summaries (#2301) with limited size (#2321)
 
 ## Windows x64
 We recommend configuring the runner in a root folder of the Windows drive (e.g. "C:\actions-runner"). This will help avoid issues related to service identity folder permissions and long file path restrictions on Windows.

releaseVersion

@@ -1 +1 @@
-2.300.0
+2.300.1

src/Runner.Worker/FileCommandManager.cs

@@ -182,6 +182,14 @@ namespace GitHub.Runner.Worker
                     return;
                 }
 
+                if (fileSize > AttachmentSizeLimit)
+                {
+                    context.Error(String.Format(Constants.Runner.UnsupportedSummarySize, AttachmentSizeLimit / 1024, fileSize / 1024));
+                    Trace.Info($"Step Summary file ({filePath}) is too large ({fileSize} bytes); skipping attachment upload");
+
+                    return;
+                }
+
                 Trace.Verbose($"Step Summary file exists: {filePath} and has a file size of {fileSize} bytes");
                 var scrubbedFilePath = filePath + "-scrubbed";
 
@@ -210,14 +218,6 @@ namespace GitHub.Runner.Worker
                 }
                 else
                 {
-                    if (fileSize > AttachmentSizeLimit)
-                    {
-                        context.Error(String.Format(Constants.Runner.UnsupportedSummarySize, AttachmentSizeLimit / 1024, fileSize / 1024));
-                        Trace.Info($"Step Summary file ({filePath}) is too large ({fileSize} bytes); skipping attachment upload");
-
-                        return;
-                    }
-
                     Trace.Info($"Queueing file ({filePath}) for attachment upload ({attachmentName})");
                     // Attachments must be added to the parent context (job), not the current context (step)
                     context.Root.QueueAttachFile(ChecksAttachmentType.StepSummary, attachmentName, scrubbedFilePath);

src/Sdk/WebApi/WebApi/ResultsHttpClient.cs

@@ -6,11 +6,11 @@ using System.Threading;
 using System.Threading.Tasks;
 using GitHub.Services.Results.Contracts;
 using System.Net.Http.Formatting;
-using Sdk.WebApi.WebApi;
+using GitHub.Services.WebApi;
 
 namespace GitHub.Services.Results.Client
 {
-    public class ResultsHttpClient : RawHttpClientBase
+    public class ResultsHttpClient : VssHttpClientBase
     {
         public ResultsHttpClient(
             Uri baseUrl,

src/runnerversion

@@ -1 +1 @@
-2.300.0
+2.300.1