Fix release workflow.

.github/workflows/release.yml

@@ -163,7 +163,6 @@ jobs:
           core.setOutput('note', releaseNote);
 
     - name: Validate Packages HASH
-      working-directory: _package
       run: |
         ls -l
         echo "${{needs.build.outputs.win-x64-sha}}  actions-runner-win-x64-${{ steps.releaseNote.outputs.version }}.zip" | shasum -a 256 -c
@@ -193,7 +192,7 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         upload_url: ${{ steps.createRelease.outputs.upload_url }}
-        asset_path: ${{ github.workspace }}/_package/actions-runner-win-x64-${{ steps.releaseNote.outputs.version }}.zip
+        asset_path: ${{ github.workspace }}/actions-runner-win-x64-${{ steps.releaseNote.outputs.version }}.zip
         asset_name: actions-runner-win-x64-${{ steps.releaseNote.outputs.version }}.zip
         asset_content_type: application/octet-stream
 
@@ -203,7 +202,7 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         upload_url: ${{ steps.createRelease.outputs.upload_url }}
-        asset_path: ${{ github.workspace }}/_package/actions-runner-win-arm64-${{ steps.releaseNote.outputs.version }}.zip
+        asset_path: ${{ github.workspace }}/actions-runner-win-arm64-${{ steps.releaseNote.outputs.version }}.zip
         asset_name: actions-runner-win-arm64-${{ steps.releaseNote.outputs.version }}.zip
         asset_content_type: application/octet-stream
 
@@ -213,7 +212,7 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         upload_url: ${{ steps.createRelease.outputs.upload_url }}
-        asset_path: ${{ github.workspace }}/_package/actions-runner-linux-x64-${{ steps.releaseNote.outputs.version }}.tar.gz
+        asset_path: ${{ github.workspace }}/actions-runner-linux-x64-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_name: actions-runner-linux-x64-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_content_type: application/octet-stream
 
@@ -223,7 +222,7 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         upload_url: ${{ steps.createRelease.outputs.upload_url }}
-        asset_path: ${{ github.workspace }}/_package/actions-runner-osx-x64-${{ steps.releaseNote.outputs.version }}.tar.gz
+        asset_path: ${{ github.workspace }}/actions-runner-osx-x64-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_name: actions-runner-osx-x64-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_content_type: application/octet-stream
 
@@ -233,7 +232,7 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         upload_url: ${{ steps.createRelease.outputs.upload_url }}
-        asset_path: ${{ github.workspace }}/_package/actions-runner-osx-arm64-${{ steps.releaseNote.outputs.version }}.tar.gz
+        asset_path: ${{ github.workspace }}/actions-runner-osx-arm64-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_name: actions-runner-osx-arm64-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_content_type: application/octet-stream
 
@@ -243,7 +242,7 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         upload_url: ${{ steps.createRelease.outputs.upload_url }}
-        asset_path: ${{ github.workspace }}/_package/actions-runner-linux-arm-${{ steps.releaseNote.outputs.version }}.tar.gz
+        asset_path: ${{ github.workspace }}/actions-runner-linux-arm-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_name: actions-runner-linux-arm-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_content_type: application/octet-stream
 
@@ -253,7 +252,7 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         upload_url: ${{ steps.createRelease.outputs.upload_url }}
-        asset_path: ${{ github.workspace }}/_package/actions-runner-linux-arm64-${{ steps.releaseNote.outputs.version }}.tar.gz
+        asset_path: ${{ github.workspace }}/actions-runner-linux-arm64-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_name: actions-runner-linux-arm64-${{ steps.releaseNote.outputs.version }}.tar.gz
         asset_content_type: application/octet-stream
 

images/Dockerfile

@@ -4,9 +4,9 @@ FROM mcr.microsoft.com/dotnet/runtime-deps:6.0-jammy as build
 ARG TARGETOS
 ARG TARGETARCH
 ARG RUNNER_VERSION
-ARG RUNNER_CONTAINER_HOOKS_VERSION=0.4.0
-ARG DOCKER_VERSION=24.0.7
-ARG BUILDX_VERSION=0.12.1
+ARG RUNNER_CONTAINER_HOOKS_VERSION=0.5.0
+ARG DOCKER_VERSION=24.0.6
+ARG BUILDX_VERSION=0.11.2
 
 RUN apt update -y && apt install curl unzip -y
 

releaseVersion

@@ -1 +1 @@
-<Update to ./src/runnerversion when creating release>
+2.312.0

src/Runner.Common/BrokerServer.cs

@@ -17,8 +17,7 @@ namespace GitHub.Runner.Common
     {
         Task ConnectAsync(Uri serverUrl, VssCredentials credentials);
 
-        Task<TaskAgentSession> CreateSessionAsync(CancellationToken cancellationToken, TaskAgentSession session);
-        Task<TaskAgentMessage> GetRunnerMessageAsync(CancellationToken token, Guid? sessionId, TaskAgentStatus status, string version, string os, string architecture, bool disableUpdate);
+        Task<TaskAgentMessage> GetRunnerMessageAsync(CancellationToken token, TaskAgentStatus status, string version, string os, string architecture, bool disableUpdate);
     }
 
     public sealed class BrokerServer : RunnerService, IBrokerServer
@@ -45,20 +44,11 @@ namespace GitHub.Runner.Common
             }
         }
 
-        public Task<TaskAgentSession> CreateSessionAsync(CancellationToken cancellationToken, TaskAgentSession session)
-        {
-            CheckConnection();
-            var jobMessage = RetryRequest<TaskAgentSession>(
-                async () => await _brokerHttpClient.CreateSessionAsync(session, cancellationToken), cancellationToken);
-
-            return jobMessage;
-        }
-
-        public Task<TaskAgentMessage> GetRunnerMessageAsync(CancellationToken cancellationToken, Guid? sessionId, TaskAgentStatus status, string version, string os, string architecture, bool disableUpdate)
+        public Task<TaskAgentMessage> GetRunnerMessageAsync(CancellationToken cancellationToken, TaskAgentStatus status, string version, string os, string architecture, bool disableUpdate)
         {
             CheckConnection();
             var jobMessage = RetryRequest<TaskAgentMessage>(
-                async () => await _brokerHttpClient.GetRunnerMessageAsync(sessionId, version, status, os, architecture, disableUpdate, cancellationToken), cancellationToken);
+                async () => await _brokerHttpClient.GetRunnerMessageAsync(version, status, os, architecture, disableUpdate, cancellationToken), cancellationToken);
 
             return jobMessage;
         }

src/Runner.Listener/BrokerMessageListener.cs

@@ -74,7 +74,6 @@ namespace GitHub.Runner.Listener
                 try
                 {
                     message = await _brokerServer.GetRunnerMessageAsync(_getMessagesTokenSource.Token,
-                                                                        null,
                                                                         runnerStatus,
                                                                         BuildConstants.RunnerPackage.Version,
                                                                         VarUtil.OS,

src/Runner.Listener/MessageListener.cs

@@ -14,7 +14,6 @@ using GitHub.Runner.Listener.Configuration;
 using GitHub.Runner.Sdk;
 using GitHub.Services.Common;
 using GitHub.Services.OAuth;
-using GitHub.Services.WebApi;
 
 namespace GitHub.Runner.Listener
 {
@@ -34,7 +33,6 @@ namespace GitHub.Runner.Listener
         private RunnerSettings _settings;
         private ITerminal _term;
         private IRunnerServer _runnerServer;
-        private IBrokerServer _brokerServer;
         private TaskAgentSession _session;
         private TimeSpan _getNextMessageRetryInterval;
         private bool _accessTokenRevoked = false;
@@ -44,7 +42,6 @@ namespace GitHub.Runner.Listener
         private readonly Dictionary<string, int> _sessionCreationExceptionTracker = new();
         private TaskAgentStatus runnerStatus = TaskAgentStatus.Online;
         private CancellationTokenSource _getMessagesTokenSource;
-        private VssCredentials _creds;
 
         public override void Initialize(IHostContext hostContext)
         {
@@ -52,7 +49,6 @@ namespace GitHub.Runner.Listener
 
             _term = HostContext.GetService<ITerminal>();
             _runnerServer = HostContext.GetService<IRunnerServer>();
-            _brokerServer = hostContext.GetService<IBrokerServer>();
         }
 
         public async Task<Boolean> CreateSessionAsync(CancellationToken token)
@@ -68,7 +64,7 @@ namespace GitHub.Runner.Listener
             // Create connection.
             Trace.Info("Loading Credentials");
             var credMgr = HostContext.GetService<ICredentialManager>();
-            _creds = credMgr.LoadCredentials();
+            VssCredentials creds = credMgr.LoadCredentials();
 
             var agent = new TaskAgentReference
             {
@@ -90,7 +86,7 @@ namespace GitHub.Runner.Listener
                 try
                 {
                     Trace.Info("Connecting to the Runner Server...");
-                    await _runnerServer.ConnectAsync(new Uri(serverUrl), _creds);
+                    await _runnerServer.ConnectAsync(new Uri(serverUrl), creds);
                     Trace.Info("VssConnection created");
 
                     _term.WriteLine();
@@ -102,14 +98,6 @@ namespace GitHub.Runner.Listener
                                                         taskAgentSession,
                                                         token);
 
-                    if (_session.BrokerMigrationMessage != null)
-                    {
-                        Trace.Info($"Runner session is in migration mode: Creating Broker session with BrokerBaseUrl: {0}", _session.BrokerMigrationMessage.BrokerBaseUrl);
-                        var brokerServer = HostContext.GetService<IBrokerServer>();
-                        await brokerServer.ConnectAsync(_session.BrokerMigrationMessage.BrokerBaseUrl, _creds);
-                        _session = await brokerServer.CreateSessionAsync(token, taskAgentSession);
-                    }
-
                     Trace.Info($"Session created.");
                     if (encounteringError)
                     {
@@ -136,7 +124,7 @@ namespace GitHub.Runner.Listener
                     Trace.Error("Catch exception during create session.");
                     Trace.Error(ex);
 
-                    if (ex is VssOAuthTokenRequestException vssOAuthEx && _creds.Federated is VssOAuthCredential vssOAuthCred)
+                    if (ex is VssOAuthTokenRequestException vssOAuthEx && creds.Federated is VssOAuthCredential vssOAuthCred)
                     {
                         // "invalid_client" means the runner registration has been deleted from the server.
                         if (string.Equals(vssOAuthEx.Error, "invalid_client", StringComparison.OrdinalIgnoreCase))
@@ -240,24 +228,6 @@ namespace GitHub.Runner.Listener
                     // Decrypt the message body if the session is using encryption
                     message = DecryptMessage(message);
 
-
-                    if (message != null && message.MessageType == BrokerMigrationMessage.MessageType)
-                    {
-                        Trace.Info("BrokerMigration message received. Polling Broker for messages...");
-
-                        var migrationMessage = JsonUtility.FromString<BrokerMigrationMessage>(message.Body);
-                        var brokerServer = HostContext.GetService<IBrokerServer>();
-
-                        await brokerServer.ConnectAsync(migrationMessage.BrokerBaseUrl, _creds);
-                        message = await brokerServer.GetRunnerMessageAsync(token,
-                                                                        _session.SessionId,
-                                                                        runnerStatus,
-                                                                        BuildConstants.RunnerPackage.Version,
-                                                                        VarUtil.OS,
-                                                                        VarUtil.OSArchitecture,
-                                                                        _settings.DisableUpdate);
-                    }
-
                     if (message != null)
                     {
                         _lastMessageId = message.MessageId;

src/Sdk/DTWebApi/WebApi/BrokerMigrationMessage.cs

@@ -1,38 +0,0 @@
-using System;
-using System.Runtime.Serialization;
-
-namespace GitHub.DistributedTask.WebApi
-{
-    /// <summary>
-    /// Message that tells the runner to redirect itself to BrokerListener for messages.
-    /// (Note that we use a special Message instead of a simple 302. This is because 
-    /// the runner will need to apply the runner's token to the request, and it is
-    /// a security best practice to *not* blindly add sensitive data to redirects
-    /// 302s.)
-    /// </summary>
-    [DataContract]
-    public class BrokerMigrationMessage
-    {
-        public static readonly string MessageType = "BrokerMigration";
-
-        public BrokerMigrationMessage()
-        {
-        }
-
-        public BrokerMigrationMessage(
-            Uri brokerUrl)
-        {
-            this.BrokerBaseUrl = brokerUrl;
-        }
-
-        /// <summary>
-        /// The base url for the broker listener
-        /// </summary>
-        [DataMember]
-        public Uri BrokerBaseUrl
-        {
-            get;
-            internal set;
-        }
-    }
-}

src/Sdk/DTWebApi/WebApi/TaskAgentSession.cs

@@ -75,12 +75,5 @@ namespace GitHub.DistributedTask.WebApi
             get;
             set;
         }
-
-        [DataMember(EmitDefaultValue = false, IsRequired = false)]
-        public BrokerMigrationMessage BrokerMigrationMessage
-        {
-            get;
-            set;
-        }
     }
 }

src/Sdk/WebApi/WebApi/BrokerHttpClient.cs

@@ -57,7 +57,6 @@ namespace GitHub.Actions.RunService.WebApi
         }
 
         public async Task<TaskAgentMessage> GetRunnerMessageAsync(
-            Guid? sessionId,
             string runnerVersion,
             TaskAgentStatus? status,
             string os = null,
@@ -70,11 +69,6 @@ namespace GitHub.Actions.RunService.WebApi
 
             List<KeyValuePair<string, string>> queryParams = new List<KeyValuePair<string, string>>();
 
-            if (sessionId != null)
-            {
-                queryParams.Add("sessionId", sessionId.Value.ToString());
-            }
-
             if (status != null)
             {
                 queryParams.Add("status", status.Value.ToString());
@@ -117,33 +111,5 @@ namespace GitHub.Actions.RunService.WebApi
 
             throw new Exception($"Failed to get job message: {result.Error}");
         }
-
-        public async Task<TaskAgentSession> CreateSessionAsync(
-
-           TaskAgentSession session,
-           CancellationToken cancellationToken = default)
-        {
-
-            var requestUri = new Uri(Client.BaseAddress, "session");
-            var requestContent = new ObjectContent<TaskAgentSession>(session, new VssJsonMediaTypeFormatter(true));
-
-            var result = await SendAsync<TaskAgentSession>(
-                new HttpMethod("POST"),
-                requestUri: requestUri,
-                content: requestContent,
-                cancellationToken: cancellationToken);
-
-            if (result.IsSuccess)
-            {
-                return result.Value;
-            }
-
-            if (result.StatusCode == HttpStatusCode.Forbidden)
-            {
-                throw new AccessDeniedException(result.Error);
-            }
-
-            throw new Exception($"Failed to create broker session: {result.Error}");
-        }
     }
 }

src/Test/L0/Listener/BrokerMessageListenerL0.cs

@@ -1,72 +0,0 @@
-using System;
-using System.Runtime.CompilerServices;
-using System.Threading;
-using System.Threading.Tasks;
-using GitHub.DistributedTask.WebApi;
-using GitHub.Runner.Listener;
-using GitHub.Runner.Listener.Configuration;
-using GitHub.Services.Common;
-using Moq;
-using Xunit;
-
-namespace GitHub.Runner.Common.Tests.Listener
-{
-    public sealed class BrokerMessageListenerL0
-    {
-        private readonly RunnerSettings _settings;
-        private readonly Mock<IConfigurationManager> _config;
-        private readonly Mock<IBrokerServer> _brokerServer;
-        private readonly Mock<ICredentialManager> _credMgr;
-
-        public BrokerMessageListenerL0()
-        {
-            _settings = new RunnerSettings { AgentId = 1, AgentName = "myagent", PoolId = 123, PoolName = "default", ServerUrlV2 = "http://myserver", WorkFolder = "_work" };
-            _config = new Mock<IConfigurationManager>();
-            _config.Setup(x => x.LoadSettings()).Returns(_settings);
-            _brokerServer = new Mock<IBrokerServer>();
-            _credMgr = new Mock<ICredentialManager>();
-            _credMgr.Setup(x => x.LoadCredentials()).Returns(new VssCredentials());
-        }
-
-        [Fact]
-        [Trait("Level", "L0")]
-        [Trait("Category", "Runner")]
-        public async void CreatesSession()
-        {
-            using TestHostContext tc = CreateTestContext();
-            using var tokenSource = new CancellationTokenSource();
-            var guid = new Guid();
-
-            // Arrange
-            _brokerServer
-                .Setup(
-                    x => x.ConnectAsync(
-                        new Uri(_settings.ServerUrlV2),
-                        It.Is<VssCredentials>(y => y != null)
-                    )
-                )
-                .Returns(
-                    Task.FromResult(
-                        new TaskAgentSession { SessionId = guid }
-                    )
-                );
-            BrokerMessageListener listener = new();
-            listener.Initialize(tc);
-
-            // Act
-            var result = await listener.CreateSessionAsync(tokenSource.Token);
-
-            // Assert
-            Assert.True(result);
-        }
-
-        private TestHostContext CreateTestContext([CallerMemberName] String testName = "")
-        {
-            TestHostContext tc = new(this, testName);
-            tc.SetSingleton<IConfigurationManager>(_config.Object);
-            tc.SetSingleton<IBrokerServer>(_brokerServer.Object);
-            tc.SetSingleton<ICredentialManager>(_credMgr.Object);
-            return tc;
-        }
-    }
-}

src/Test/L0/Listener/MessageListenerL0.cs

@@ -24,8 +24,6 @@ namespace GitHub.Runner.Common.Tests.Listener
         private Mock<ICredentialManager> _credMgr;
         private Mock<IConfigurationStore> _store;
 
-        private Mock<IBrokerServer> _brokerServer;
-
         public MessageListenerL0()
         {
             _settings = new RunnerSettings { AgentId = 1, AgentName = "myagent", PoolId = 123, PoolName = "default", ServerUrl = "http://myserver", WorkFolder = "_work" };
@@ -34,7 +32,6 @@ namespace GitHub.Runner.Common.Tests.Listener
             _runnerServer = new Mock<IRunnerServer>();
             _credMgr = new Mock<ICredentialManager>();
             _store = new Mock<IConfigurationStore>();
-            _brokerServer = new Mock<IBrokerServer>();
         }
 
         private TestHostContext CreateTestContext([CallerMemberName] String testName = "")
@@ -44,7 +41,6 @@ namespace GitHub.Runner.Common.Tests.Listener
             tc.SetSingleton<IRunnerServer>(_runnerServer.Object);
             tc.SetSingleton<ICredentialManager>(_credMgr.Object);
             tc.SetSingleton<IConfigurationStore>(_store.Object);
-            tc.SetSingleton<IBrokerServer>(_brokerServer.Object);
             return tc;
         }