If conclusion is not set, we cannot get default value (#2535)

This commit is contained in:
Yang Cao
2023-04-13 13:03:57 -04:00
committed by GitHub
parent 766cefe599
commit b9a0b5dba9

View File

@@ -330,7 +330,7 @@ namespace GitHub.Services.Results.Client
Status = ConvertStateToStatus(r.State.GetValueOrDefault()), Status = ConvertStateToStatus(r.State.GetValueOrDefault()),
StartedAt = r.StartTime?.ToString(Constants.TimestampFormat), StartedAt = r.StartTime?.ToString(Constants.TimestampFormat),
CompletedAt = r.FinishTime?.ToString(Constants.TimestampFormat), CompletedAt = r.FinishTime?.ToString(Constants.TimestampFormat),
Conclusion = ConvertResultToConclusion(r.Result.GetValueOrDefault()) Conclusion = ConvertResultToConclusion(r.Result)
}; };
} }
@@ -349,8 +349,13 @@ namespace GitHub.Services.Results.Client
} }
} }
private Conclusion ConvertResultToConclusion(TaskResult r) private Conclusion ConvertResultToConclusion(TaskResult? r)
{ {
if (!r.HasValue)
{
return Conclusion.ConclusionUnknown;
}
switch (r) switch (r)
{ {
case TaskResult.Succeeded: case TaskResult.Succeeded: