From b9a0b5dba9bf875082bcb84a75cb5a0f1eb20e72 Mon Sep 17 00:00:00 2001 From: Yang Cao Date: Thu, 13 Apr 2023 13:03:57 -0400 Subject: [PATCH] If conclusion is not set, we cannot get default value (#2535) --- src/Sdk/WebApi/WebApi/ResultsHttpClient.cs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/Sdk/WebApi/WebApi/ResultsHttpClient.cs b/src/Sdk/WebApi/WebApi/ResultsHttpClient.cs index 42721c0e8..eb9afc96b 100644 --- a/src/Sdk/WebApi/WebApi/ResultsHttpClient.cs +++ b/src/Sdk/WebApi/WebApi/ResultsHttpClient.cs @@ -330,7 +330,7 @@ namespace GitHub.Services.Results.Client Status = ConvertStateToStatus(r.State.GetValueOrDefault()), StartedAt = r.StartTime?.ToString(Constants.TimestampFormat), CompletedAt = r.FinishTime?.ToString(Constants.TimestampFormat), - Conclusion = ConvertResultToConclusion(r.Result.GetValueOrDefault()) + Conclusion = ConvertResultToConclusion(r.Result) }; } @@ -349,8 +349,13 @@ namespace GitHub.Services.Results.Client } } - private Conclusion ConvertResultToConclusion(TaskResult r) + private Conclusion ConvertResultToConclusion(TaskResult? r) { + if (!r.HasValue) + { + return Conclusion.ConclusionUnknown; + } + switch (r) { case TaskResult.Succeeded: