Rename boolean flag indicating service container failure

This commit is contained in:
JoannaaKL
2022-09-13 13:51:52 +00:00
parent 47ead99c13
commit b8aafc4ff1
2 changed files with 3 additions and 3 deletions

View File

@@ -92,7 +92,7 @@ namespace GitHub.Runner.Worker.Container
public bool IsJobContainer { get; set; } public bool IsJobContainer { get; set; }
public bool IsAlpine { get; set; } public bool IsAlpine { get; set; }
public bool IsHealthy { get; set; } = true; public bool FailedInitialization { get; set; } = false;
public IDictionary<string, string> ContainerEnvironmentVariables public IDictionary<string, string> ContainerEnvironmentVariables
{ {

View File

@@ -322,7 +322,7 @@ namespace GitHub.Runner.Worker
if (!string.IsNullOrEmpty(container.ContainerId)) if (!string.IsNullOrEmpty(container.ContainerId))
{ {
if (!container.IsJobContainer && container.IsHealthy) if (!container.IsJobContainer && !container.FailedInitialization)
{ {
var healthcheck = await Healthcheck(executionContext, container); var healthcheck = await Healthcheck(executionContext, container);
if (string.Equals(healthcheck, "healthy", StringComparison.OrdinalIgnoreCase)) if (string.Equals(healthcheck, "healthy", StringComparison.OrdinalIgnoreCase))
@@ -448,7 +448,7 @@ namespace GitHub.Runner.Worker
{ {
await _dockerManager.DockerLogs(context: executionContext, containerId: container.ContainerId); await _dockerManager.DockerLogs(context: executionContext, containerId: container.ContainerId);
executionContext.Error($"Failed to initialize container {container.ContainerImage}"); executionContext.Error($"Failed to initialize container {container.ContainerImage}");
container.IsHealthy = false; container.FailedInitialization = true;
} }
private async Task<string> ContainerRegistryLogin(IExecutionContext executionContext, ContainerInfo container) private async Task<string> ContainerRegistryLogin(IExecutionContext executionContext, ContainerInfo container)