From b8aafc4ff1a737bfddfc7614583209509663f0cc Mon Sep 17 00:00:00 2001 From: JoannaaKL Date: Tue, 13 Sep 2022 13:51:52 +0000 Subject: [PATCH] Rename boolean flag indicating service container failure --- src/Runner.Worker/Container/ContainerInfo.cs | 2 +- src/Runner.Worker/ContainerOperationProvider.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Runner.Worker/Container/ContainerInfo.cs b/src/Runner.Worker/Container/ContainerInfo.cs index 292e1e332..ce883cc10 100644 --- a/src/Runner.Worker/Container/ContainerInfo.cs +++ b/src/Runner.Worker/Container/ContainerInfo.cs @@ -92,7 +92,7 @@ namespace GitHub.Runner.Worker.Container public bool IsJobContainer { get; set; } public bool IsAlpine { get; set; } - public bool IsHealthy { get; set; } = true; + public bool FailedInitialization { get; set; } = false; public IDictionary ContainerEnvironmentVariables { diff --git a/src/Runner.Worker/ContainerOperationProvider.cs b/src/Runner.Worker/ContainerOperationProvider.cs index 3fbac07d9..d77a50c70 100644 --- a/src/Runner.Worker/ContainerOperationProvider.cs +++ b/src/Runner.Worker/ContainerOperationProvider.cs @@ -322,7 +322,7 @@ namespace GitHub.Runner.Worker if (!string.IsNullOrEmpty(container.ContainerId)) { - if (!container.IsJobContainer && container.IsHealthy) + if (!container.IsJobContainer && !container.FailedInitialization) { var healthcheck = await Healthcheck(executionContext, container); if (string.Equals(healthcheck, "healthy", StringComparison.OrdinalIgnoreCase)) @@ -448,7 +448,7 @@ namespace GitHub.Runner.Worker { await _dockerManager.DockerLogs(context: executionContext, containerId: container.ContainerId); executionContext.Error($"Failed to initialize container {container.ContainerImage}"); - container.IsHealthy = false; + container.FailedInitialization = true; } private async Task ContainerRegistryLogin(IExecutionContext executionContext, ContainerInfo container)