Add TODO, remove unn. content

This commit is contained in:
Ethan Chiu
2020-06-19 14:38:37 -04:00
parent 9939cf527e
commit 5988076fcf
3 changed files with 1 additions and 4 deletions

View File

@@ -276,6 +276,7 @@ namespace GitHub.Runner.Worker
var newGuid = Guid.NewGuid(); var newGuid = Guid.NewGuid();
step.ExecutionContext = Root.CreateChild(newGuid, step.DisplayName, newGuid.ToString("N"), null, null); step.ExecutionContext = Root.CreateChild(newGuid, step.DisplayName, newGuid.ToString("N"), null, null);
step.ExecutionContext.ExpressionValues["inputs"] = inputsData; step.ExecutionContext.ExpressionValues["inputs"] = inputsData;
// TODO: confirm whether not copying message contexts is safe
Root.JobSteps.Insert(0, step); Root.JobSteps.Insert(0, step);
} }

View File

@@ -68,10 +68,7 @@ namespace GitHub.Runner.Worker.Handlers
} }
else if (data.ExecutionType == ActionExecutionType.Composite) else if (data.ExecutionType == ActionExecutionType.Composite)
{ {
// TODO
// Runner plugin
handler = HostContext.CreateService<ICompositeActionHandler>(); handler = HostContext.CreateService<ICompositeActionHandler>();
// handler = CompositeHandler;
(handler as ICompositeActionHandler).Data = data as CompositeActionExecutionData; (handler as ICompositeActionHandler).Data = data as CompositeActionExecutionData;
} }
else else

View File

@@ -65,7 +65,6 @@ namespace GitHub.DistributedTask.Pipelines.ObjectTemplating
public const String StepEnv = "step-env"; public const String StepEnv = "step-env";
public const String StepIfResult = "step-if-result"; public const String StepIfResult = "step-if-result";
public const String Steps = "steps"; public const String Steps = "steps";
public const String StepsInTemplate = "steps-in-template"; public const String StepsInTemplate = "steps-in-template";
public const String StepsScopeInputs = "steps-scope-inputs"; public const String StepsScopeInputs = "steps-scope-inputs";
public const String StepsScopeOutputs = "steps-scope-outputs"; public const String StepsScopeOutputs = "steps-scope-outputs";