From 5988076fcf9913d98d745549089e85d11a46be8f Mon Sep 17 00:00:00 2001 From: Ethan Chiu Date: Fri, 19 Jun 2020 14:38:37 -0400 Subject: [PATCH] Add TODO, remove unn. content --- src/Runner.Worker/ExecutionContext.cs | 1 + src/Runner.Worker/Handlers/HandlerFactory.cs | 3 --- .../Pipelines/ObjectTemplating/PipelineTemplateConstants.cs | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/Runner.Worker/ExecutionContext.cs b/src/Runner.Worker/ExecutionContext.cs index 228074e6c..67ef66cb7 100644 --- a/src/Runner.Worker/ExecutionContext.cs +++ b/src/Runner.Worker/ExecutionContext.cs @@ -276,6 +276,7 @@ namespace GitHub.Runner.Worker var newGuid = Guid.NewGuid(); step.ExecutionContext = Root.CreateChild(newGuid, step.DisplayName, newGuid.ToString("N"), null, null); step.ExecutionContext.ExpressionValues["inputs"] = inputsData; + // TODO: confirm whether not copying message contexts is safe Root.JobSteps.Insert(0, step); } diff --git a/src/Runner.Worker/Handlers/HandlerFactory.cs b/src/Runner.Worker/Handlers/HandlerFactory.cs index 99311afca..db4d6559c 100644 --- a/src/Runner.Worker/Handlers/HandlerFactory.cs +++ b/src/Runner.Worker/Handlers/HandlerFactory.cs @@ -68,10 +68,7 @@ namespace GitHub.Runner.Worker.Handlers } else if (data.ExecutionType == ActionExecutionType.Composite) { - // TODO - // Runner plugin handler = HostContext.CreateService(); - // handler = CompositeHandler; (handler as ICompositeActionHandler).Data = data as CompositeActionExecutionData; } else diff --git a/src/Sdk/DTPipelines/Pipelines/ObjectTemplating/PipelineTemplateConstants.cs b/src/Sdk/DTPipelines/Pipelines/ObjectTemplating/PipelineTemplateConstants.cs index bf7d8d2e9..f2609462b 100644 --- a/src/Sdk/DTPipelines/Pipelines/ObjectTemplating/PipelineTemplateConstants.cs +++ b/src/Sdk/DTPipelines/Pipelines/ObjectTemplating/PipelineTemplateConstants.cs @@ -65,7 +65,6 @@ namespace GitHub.DistributedTask.Pipelines.ObjectTemplating public const String StepEnv = "step-env"; public const String StepIfResult = "step-if-result"; public const String Steps = "steps"; - public const String StepsInTemplate = "steps-in-template"; public const String StepsScopeInputs = "steps-scope-inputs"; public const String StepsScopeOutputs = "steps-scope-outputs";