actions/runner
1
0
Fork 0
mirror of https://github.com/actions/runner.git synced 2025-12-11 21:06:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

code review suggestion of checking heredocIndex < equalsIndex to short circuit the 'equals in delimiter' case

Browse Source
This commit is contained in:
Ben Wells
2023-07-26 14:50:59 +00:00
parent 3ee541e26a
commit 4da8c9e69a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Runner.Worker/FileCommandManager.cs
View File

@@ -329,11 +329,11 @@ namespace GitHub.Runner.Worker
var isHeredoc = heredocIndex >= 0 && var isHeredoc = heredocIndex >= 0 &&
( (
equalsIndex < 0 || equalsIndex < 0 ||
heredocIndex < equalsIndex ||
( (
heredocIndex > equalsIndex && heredocIndex > equalsIndex &&
OnlyContainsWhiteSpaceBetweenPositions(line, equalsIndex, heredocIndex) OnlyContainsWhiteSpaceBetweenPositions(line, equalsIndex, heredocIndex)
) || heredocIndex < equalsIndex )
); );
if (isHeredoc) if (isHeredoc)