From 4da8c9e69a9f60f0c7b87a4bf406c520bc882f9c Mon Sep 17 00:00:00 2001 From: Ben Wells Date: Wed, 26 Jul 2023 14:50:59 +0000 Subject: [PATCH] code review suggestion of checking heredocIndex < equalsIndex to short circuit the 'equals in delimiter' case --- src/Runner.Worker/FileCommandManager.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Runner.Worker/FileCommandManager.cs b/src/Runner.Worker/FileCommandManager.cs index e269aa91b..2a3c137b9 100644 --- a/src/Runner.Worker/FileCommandManager.cs +++ b/src/Runner.Worker/FileCommandManager.cs @@ -329,11 +329,11 @@ namespace GitHub.Runner.Worker var isHeredoc = heredocIndex >= 0 && ( equalsIndex < 0 || - + heredocIndex < equalsIndex || ( heredocIndex > equalsIndex && OnlyContainsWhiteSpaceBetweenPositions(line, equalsIndex, heredocIndex) - ) || heredocIndex < equalsIndex + ) ); if (isHeredoc)