Commit Graph

56 Commits

Author SHA1 Message Date
Thomas Boop
47cbf5a0d7 Misc Tracing cleanup (#15)
* cleanup final bits

* fix import
2022-06-15 09:28:43 -04:00
Nikola Jokic
de4553f25a added permission check for secrets (#14)
* added permission check for secrets

* typo in subresource

* moved auth check to the command receiver
2022-06-15 08:54:50 -04:00
Nikola Jokic
8ea57170d8 Fix working directory and write state for appPod to be used in run-script-step (#8)
* added initial entrypoint script

* change workingg directory working with addition to fix prepare-job state output

* added prepend path

* added run-script-step file generation, removed prepend path from container-step and prepare job

* latest changes with testing run script step

* fix the mounts real fast

* cleanup

* fix tests

* add kind test

* add kind yaml to ignore and run it during ci

* fix kind option

* remove gitignore

* lowercase pwd

* checkout first!

* ignore test file in build.yaml

* fixed wrong working directory and added test to run script step testing for the env

* handle env's/escaping better

* added single quote escape to env escapes

* surounded env value with single quote

* added spacing around run-container-step, changed examples to actually echo hello world

* refactored tests

* make sure to escape properly

* set addition mounts for container steps

* fixup container action mounts

Co-authored-by: Thomas Boop <thboop@github.com>
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
2022-06-14 21:41:49 -04:00
Nikola Jokic
643bf36fd8 docker apply env on commands where we are using '-e' (#11)
* added wrapper for docker -e to apply env

* added envs around services as well

* added wrapping environment around execute command

* fixed setting the env variable for containerRun

* added env to exec and not to handle envs by ourself

* returned back the comment to run-container-step
2022-06-13 11:13:47 -04:00
Thomas Boop
de59bd8716 Merge pull request #12 from actions/nikola-jokic/allow-no-job-container
Repaired prepare-job hook without job container
2022-06-10 13:34:52 -04:00
Nikola Jokic
d3ec1c0040 prepare job in k8s does not allow for no job container 2022-06-10 16:38:07 +02:00
Nikola Jokic
3e04b45585 removed leftover todo comments 2022-06-10 12:45:59 +02:00
Nikola Jokic
2b386f7cbd returned logging below the try k8s prepare job 2022-06-10 12:00:49 +02:00
Nikola Jokic
bf362ba0dd fixed prepare-job for docker to allow for no job container 2022-06-10 11:56:10 +02:00
Nikola Jokic
7ae8942b3d Repaired prepare-job hook without job container 2022-06-10 11:07:50 +02:00
Thomas Boop
347e68d3c9 Merge pull request #7 from actions/thboop/refactor3
K8s hook refactor
2022-06-09 09:33:53 -04:00
Thomas Boop
7c4e0f8d51 update limitations 2022-06-08 15:32:30 -04:00
Thomas Boop
cd310988c9 slight refactor, bring pod phase to k8s lib, better types 2022-06-08 15:32:30 -04:00
Thomas Boop
1bfc52f466 Merge pull request #2 from actions/nikola-jokic/computed-build-directory
Computed action build directory. Refactored tests and added docker build test
2022-06-08 13:38:57 -04:00
Nikola Jokic
2aa6f9d9c8 added quotes back to the path 2022-06-08 17:39:37 +02:00
Nikola Jokic
3d0ca83d2d removed quotes around -e env variables 2022-06-08 17:37:43 +02:00
Thomas Boop
5daaae120b Merge pull request #9 from actions/nikola-jokic/user-volume-mounts-path
User volume mount restriction to the work directory mounts if path is absolute
2022-06-08 11:15:31 -04:00
Nikola Jokic
df448fbbb0 cleared registry for testing 2022-06-08 17:13:43 +02:00
Nikola Jokic
ee2554e2c0 filter out empty ports 2022-06-08 16:49:44 +02:00
Thomas Boop
f764d18c4c Update packages/k8s/src/k8s/utils.ts 2022-06-08 09:41:38 -04:00
Thomas Boop
55761eab39 Merge pull request #10 from actions/nikola-jokic/docker-test-refactor
Added prepend path and refactored tests, adding isAlpine test and basic run-script-step test
2022-06-08 09:40:49 -04:00
Nikola Jokic
51bd8b62a4 Merge branch 'nikola-jokic/docker-env' into nikola-jokic/computed-build-directory 2022-06-08 15:07:59 +02:00
Nikola Jokic
150bc0503a substituited all -e key=value to -e key 2022-06-08 15:02:40 +02:00
Nikola Jokic
9ce39e5a60 Merge branch 'main' into nikola-jokic/computed-build-directory 2022-06-08 14:37:13 +02:00
Nikola Jokic
8351f842bd added isAlpine test to prepare job 2022-06-08 14:29:10 +02:00
Nikola Jokic
bf3707d7e0 added guard around prependPath 2022-06-08 13:28:46 +02:00
Nikola Jokic
88b7b19db7 fixed interface for hooklib and example repos 2022-06-08 13:25:45 +02:00
Nikola Jokic
dd5dfb3e48 refactored tests to be easier to follow 2022-06-08 13:20:54 +02:00
Nikola Jokic
84a57de2e3 added tests around user volume mounts for prepare job 2022-06-08 11:23:05 +02:00
Nikola Jokic
fa680b2073 Merge branch 'nikola-jokic/user-volume-mounts-path' of https://github.com/actions/runner-container-hooks into nikola-jokic/user-volume-mounts-path 2022-06-08 11:02:49 +02:00
Nikola Jokic
02f0b322a0 fixed merge conflict, repaired paths in examples 2022-06-08 11:02:33 +02:00
Thomas Boop
ecb9376000 Merge pull request #4 from actions/thboop/setupTests
Setup CI to run k8s tests
2022-06-07 22:38:06 -04:00
Thomas Boop
cc90cd2361 pr feedback 2022-06-07 16:47:45 -04:00
Thomas Boop
152c4e1cc8 Update packages/k8s/src/k8s/utils.ts 2022-06-07 16:38:02 -04:00
Nikola Jokic
d0e094649e use variable for env GITHUB_WORKSPACE 2022-06-07 16:48:05 +02:00
Nikola Jokic
3ba45d3d7e user volume mount fix based on workspacePath 2022-06-07 16:47:05 +02:00
Nikola Jokic
58ebf56ad3 Merge branch 'main' into nikola-jokic/computed-build-directory 2022-06-07 10:52:28 +02:00
Thomas Boop
e928fa3252 Pass secrets more securely for container action 2022-06-06 18:43:57 -04:00
Thomas Boop
ddf09ad7bd Merge pull request #3 from actions/nikola-jokic/docker-label-cleanup
Cleanup now looks at the containers by the label, and not by the state
2022-06-06 18:36:59 -04:00
Thomas Boop
689a74e352 run format 2022-06-06 14:27:06 -04:00
Thomas Boop
55c9198ada new pv for each pod 2022-06-06 14:15:14 -04:00
Thomas Boop
bd7e053180 Merge pull request #5 from actions/nikola-jokic/setupTests-addition
fixed testing adding storage class and persistent volume and timeout for cleanup job
2022-06-06 09:02:00 -04:00
Nikola Jokic
0ebccbd8c6 fixed testing adding storage class and persistent volume and timeout to wait for cleanup 2022-06-06 12:56:50 +02:00
Thomas Boop
ec8131abb7 setup ci to run k8s tests 2022-06-06 00:21:44 -04:00
Nikola Jokic
7010d21bff repaired tests 2022-06-03 16:24:20 +02:00
Nikola Jokic
c65ec28bbb added force cleanup for network and cleanUp hook is cleaning up based on the label 2022-06-03 16:01:24 +02:00
Ferenc Hammerl
c2f9b10f4d Fix case sensitive image in test 2022-06-03 06:56:26 -07:00
Ferenc Hammerl
1e49f4ba5b Merge branch 'nikola-jokic/computed-build-directory' of github.com:actions/runner-container-hooks into nikola-jokic/computed-build-directory 2022-06-03 06:52:11 -07:00
Ferenc Hammerl
171956673c Handle empty registry property in input 2022-06-03 06:52:06 -07:00
Nikola Jokic
3ab4ae20f9 added network prune 2022-06-03 15:15:19 +02:00