Fix is alpine check using shlex (#130)

This commit is contained in:
Nikola Jokic
2024-02-05 09:50:51 +01:00
committed by GitHub
parent 0cce49705b
commit 921be5b85f
2 changed files with 12 additions and 1 deletions

View File

@@ -14,7 +14,8 @@ import {
PodPhase,
mergePodSpecWithOptions,
mergeObjectMeta,
useKubeScheduler
useKubeScheduler,
fixArgs
} from './utils'
const kc = new k8s.KubeConfig()
@@ -226,6 +227,7 @@ export async function execPodStep(
stdin?: stream.Readable
): Promise<void> {
const exec = new k8s.Exec(kc)
command = fixArgs(command)
await new Promise(async function (resolve, reject) {
await exec.exec(
namespace(),

View File

@@ -91,6 +91,15 @@ describe('Prepare job', () => {
expect(services[0].args).toBe(undefined)
})
it('should determine alpine correctly', async () => {
prepareJobData.args.container.image = 'alpine:latest'
await prepareJob(prepareJobData.args, prepareJobOutputFilePath)
const content = JSON.parse(
fs.readFileSync(prepareJobOutputFilePath).toString()
)
expect(content.isAlpine).toBe(true)
})
it('should run pod with extensions applied', async () => {
process.env[ENV_HOOK_TEMPLATE_PATH] = path.join(
__dirname,