Merge pull request #197 from e-korolevskii/fix-tests-for-python-3.12

Fix tests for python 3.12
test(modules-test): Remove check for smtpd in python >= 3.12
2025-12-15 23:36:44 +00:00 · 2022-11-08 11:44:54 +01:00 · 2022-11-04 15:25:35 +01:00 · 2022-11-04 15:23:59 +01:00 · 2022-10-31 15:12:41 +01:00 · 2022-10-26 12:47:26 +02:00
15 changed files with 214 additions and 35 deletions
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -42,7 +42,7 @@ jobs:

    # Initializes the CodeQL tools for scanning.
    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v1
+      uses: github/codeql-action/init@v2
      with:
        languages: ${{ matrix.language }}
        # If you wish to specify custom queries, you can do so here or in a config file.
@@ -53,7 +53,7 @@ jobs:
    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
    # If this step fails, then you should remove it and run the build manually (see below)
    - name: Autobuild
-      uses: github/codeql-action/autobuild@v1
+      uses: github/codeql-action/autobuild@v2

    # ℹ️ Command-line programs to run using the OS shell.
    # 📚 https://git.io/JvXDl
@@ -67,4 +67,4 @@ jobs:
    #   make release

    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v1
+      uses: github/codeql-action/analyze@v2
--- a/.github/workflows/create-pr.yml
+++ b/.github/workflows/create-pr.yml
@@ -11,7 +11,7 @@ jobs:
    name: Create Pull Request
    runs-on: ubuntu-latest
    steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
      with:
        submodules: true

--- a/.github/workflows/get-python-versions.yml
+++ b/.github/workflows/get-python-versions.yml
@@ -12,12 +12,13 @@ defaults:

 jobs:
  find_new_versions:
+    if: github.repository_owner == 'actions'
    name: Find new versions
    runs-on: ubuntu-latest
    outputs:
      versions_output: ${{ steps.Get_new_versions.outputs.TOOL_VERSIONS }}
    steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
        with:
          submodules: true

@@ -32,7 +33,7 @@ jobs:
    env:
      TOOL_VERSIONS: ${{needs.find_new_versions.outputs.versions_output}}
    steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
        with:
          submodules: true

@@ -62,7 +63,7 @@ jobs:
      TOOL_VERSIONS: ${{needs.find_new_versions.outputs.versions_output}}
    environment: Get Available Tools Versions - Publishing Approval
    steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
        with:
          submodules: true

@@ -81,7 +82,7 @@ jobs:
    needs: [find_new_versions, check_new_versions, trigger_builds]
    if: failure()
    steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
        with:
          submodules: true

--- a/.github/workflows/manifest-config-validation.yml
+++ b/.github/workflows/manifest-config-validation.yml
@@ -11,7 +11,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
    - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
      with:
        submodules: true

@@ -21,7 +21,7 @@ jobs:
        Install-Module Pester -Force -Scope CurrentUser

    - name: Run tests
-      shell: pwsh  
+      shell: pwsh
      run: |
        Import-Module Pester
        Invoke-Pester -Configuration @{
--- a/.github/workflows/python-builder.yml
+++ b/.github/workflows/python-builder.yml
@@ -56,7 +56,7 @@ jobs:
              'arch' = $arch
            }
          }
-          echo "::set-output name=matrix::$($matrix | ConvertTo-Json -Compress)"
+          echo "matrix=$($matrix | ConvertTo-Json -Compress)" >> $env:GITHUB_OUTPUT

  build_python:
    needs: generate_matrix
@@ -70,7 +70,7 @@ jobs:
    steps:

      - name: Check out repository code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          submodules: true

@@ -80,7 +80,7 @@ jobs:
                  -Platform ${{ matrix.platform }} -Architecture ${{ matrix.arch }}

      - name: Publish artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
        with:
          name: ${{ env.ARTIFACT_NAME }}
          path: ${{ runner.temp }}/artifact
@@ -97,7 +97,7 @@ jobs:
    steps:

      - name: Check out repository code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          submodules: true

@@ -105,7 +105,7 @@ jobs:
        run: ./helpers/clean-toolcache.ps1 -ToolName "Python"

      - name: Download artifact
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v3
        with:
          path: ${{ runner.temp }}

@@ -131,7 +131,7 @@ jobs:
        working-directory: ${{ runner.temp }}/${{ env.ARTIFACT_NAME }}

      - name: Setup Python ${{ env.VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
        with:
          python-version: ${{ env.VERSION }}
          architecture: ${{ matrix.arch }}
@@ -168,7 +168,7 @@ jobs:
      needs: test_python
      runs-on: ubuntu-latest
      steps:
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v3

      - name: Publish Release ${{ env.VERSION }}
        id: create_release
@@ -182,7 +182,7 @@ jobs:
            Python ${{ env.VERSION }}

      - name: Upload release assets
-        uses: actions/github-script@v2
+        uses: actions/github-script@v6
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          script: |
@@ -205,7 +205,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
    - name: Trigger "Create Pull Request" workflow
-      uses: actions/github-script@v3
+      uses: actions/github-script@v6
      with:
        github-token: ${{ secrets.PERSONAL_TOKEN }}
        script: |
--- a/.github/workflows/python-versions-runner.yml
+++ b/.github/workflows/python-versions-runner.yml
@@ -21,7 +21,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out repository code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
      
      - name: Trigger python workflow
        run: |
--- a/.github/workflows/releases-validation.yml
+++ b/.github/workflows/releases-validation.yml
@@ -18,7 +18,7 @@ jobs:
        python: [3.5.4, 3.6.7, 3.7.5, 3.8.1]
    steps:
    - name: setup-python ${{ matrix.python }}
-      uses: actions/setup-python@v3
+      uses: actions/setup-python@v4
      with:
        python-version: ${{ matrix.python }}

--- a/.github/workflows/validate-manifest.yml
+++ b/.github/workflows/validate-manifest.yml
@@ -19,9 +19,10 @@ defaults:

 jobs:
  validation:
+    if: github.repository_owner == 'actions'
    runs-on: ubuntu-latest
    steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
        with:
          submodules: true

@@ -34,7 +35,7 @@ jobs:
    needs: [validation]
    if: failure()
    steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
        with:
          submodules: true

--- a/2
+++ b/2
--- a/installers/macos-pkg-setup-template.sh
+++ b/installers/macos-pkg-setup-template.sh
@@ -20,6 +20,7 @@ PYTHON_TOOLCACHE_PATH=$TOOLCACHE_ROOT/Python
 PYTHON_TOOLCACHE_VERSION_PATH=$PYTHON_TOOLCACHE_PATH/$PYTHON_FULL_VERSION
 PYTHON_TOOLCACHE_VERSION_ARCH_PATH=$PYTHON_TOOLCACHE_VERSION_PATH/x64
 PYTHON_FRAMEWORK_PATH="/Library/Frameworks/Python.framework/Versions/${MAJOR_VERSION}.${MINOR_VERSION}"
+PYTHON_APPLICATION_PATH="/Applications/Python ${MAJOR_VERSION}.${MINOR_VERSION}"

 echo "Check if Python hostedtoolcache folder exist..."
 if [ ! -d $PYTHON_TOOLCACHE_PATH ]; then
@@ -64,5 +65,8 @@ echo "Upgrading pip..."
 ./python -m ensurepip
 ./python -m pip install --ignore-installed pip --disable-pip-version-check --no-warn-script-location

+echo "Install OpenSSL certificates"
+sh -e "${PYTHON_APPLICATION_PATH}/Install Certificates.command"
+
 echo "Create complete file"
 touch $PYTHON_TOOLCACHE_VERSION_PATH/x64.complete
--- a/tests/python-tests.ps1
+++ b/tests/python-tests.ps1
@@ -56,7 +56,7 @@ Describe "Tests" {
    #     }
    # }

-    if (($Version -ge "3.2.0") -and -not ([semver]"$($Version.Major).$($Version.Minor)" -eq [semver]"3.11" -and $Version.PreReleaseLabel)) {
+    if (($Version -ge "3.2.0") -and ($Version -lt "3.11.0")) {
        It "Check if sqlite3 module is installed" {
            "python ./sources/python-sqlite3.py" | Should -ReturnZeroExitCode
        }
@@ -96,4 +96,8 @@ Describe "Tests" {
            "./dist/simple-test" | Should -ReturnZeroExitCode
        }
    }
+
+    It "Check urlopen with HTTPS works" {
+        "python ./sources/python-urlopen-https.py" | Should -ReturnZeroExitCode
+    }
 }
--- a/tests/sources/python-config-test.py
+++ b/tests/sources/python-config-test.py
@@ -78,6 +78,7 @@ if os_type == 'Darwin':
                exit(1)

 ### Validate libreadline
-if not have_libreadline:
-    print('Missing libreadline')
-    exit(1)
+if sys.version_info < (3, 12):
+    if not have_libreadline:
+        print('Missing libreadline')
+        exit(1)
--- a/tests/sources/python-modules.py
+++ b/tests/sources/python-modules.py
@@ -271,6 +271,10 @@ if sys.version_info >= (3, 11) and platform.system() == 'Linux' and '18.04' in p
    standard_library.remove('tkinter')
    standard_library.remove('turtle')

+# 'smtpd' module has been removed from Python 3.12
+if sys.version_info >= (3, 12):
+    standard_library.remove('smtpd')
+
 # Remove tkinter and Easter eggs
 excluded_modules = [
    'antigravity',
--- a/tests/sources/python-urlopen-https.py
+++ b/tests/sources/python-urlopen-https.py
@@ -0,0 +1,10 @@
+import sys
+
+if sys.version_info[0] == 2:
+    from urllib2 import urlopen
+else:
+    from urllib.request import urlopen
+
+response = urlopen("https://raw.githubusercontent.com/actions/python-versions/c641695f6a07526c18f10e374e503e649fef9427/.gitignore")
+data = response.read()
+assert len(data) == 140, len(data)
--- a/versions-manifest.json
+++ b/versions-manifest.json
@@ -1,47 +1,93 @@
 [
+  {
+    "version": "3.11.0",
+    "stable": true,
+    "release_url": "https://github.com/actions/python-versions/releases/tag/3.11.0-3328127706",
+    "files": [
+      {
+        "filename": "python-3.11.0-darwin-x64.tar.gz",
+        "arch": "x64",
+        "platform": "darwin",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-3328127706/python-3.11.0-darwin-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.11.0-linux-18.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "18.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-3328127706/python-3.11.0-linux-18.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.11.0-linux-20.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "20.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-3328127706/python-3.11.0-linux-20.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.11.0-linux-22.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "22.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-3328127706/python-3.11.0-linux-22.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.11.0-win32-x64.zip",
+        "arch": "x64",
+        "platform": "win32",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-3328127706/python-3.11.0-win32-x64.zip"
+      },
+      {
+        "filename": "python-3.11.0-win32-x86.zip",
+        "arch": "x86",
+        "platform": "win32",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-3328127706/python-3.11.0-win32-x86.zip"
+      }
+    ]
+  },
  {
    "version": "3.11.0-rc.2",
    "stable": false,
-    "release_url": "https://github.com/actions/python-versions/releases/tag/3.11.0-rc.2-3038386004",
+    "release_url": "https://github.com/actions/python-versions/releases/tag/3.11.0-rc.2-3172748327",
    "files": [
      {
        "filename": "python-3.11.0-rc.2-darwin-x64.tar.gz",
        "arch": "x64",
        "platform": "darwin",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3038386004/python-3.11.0-rc.2-darwin-x64.tar.gz"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3172748327/python-3.11.0-rc.2-darwin-x64.tar.gz"
      },
      {
        "filename": "python-3.11.0-rc.2-linux-18.04-x64.tar.gz",
        "arch": "x64",
        "platform": "linux",
        "platform_version": "18.04",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3038386004/python-3.11.0-rc.2-linux-18.04-x64.tar.gz"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3172748327/python-3.11.0-rc.2-linux-18.04-x64.tar.gz"
      },
      {
        "filename": "python-3.11.0-rc.2-linux-20.04-x64.tar.gz",
        "arch": "x64",
        "platform": "linux",
        "platform_version": "20.04",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3038386004/python-3.11.0-rc.2-linux-20.04-x64.tar.gz"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3172748327/python-3.11.0-rc.2-linux-20.04-x64.tar.gz"
      },
      {
        "filename": "python-3.11.0-rc.2-linux-22.04-x64.tar.gz",
        "arch": "x64",
        "platform": "linux",
        "platform_version": "22.04",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3038386004/python-3.11.0-rc.2-linux-22.04-x64.tar.gz"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3172748327/python-3.11.0-rc.2-linux-22.04-x64.tar.gz"
      },
      {
        "filename": "python-3.11.0-rc.2-win32-x64.zip",
        "arch": "x64",
        "platform": "win32",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3038386004/python-3.11.0-rc.2-win32-x64.zip"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3172748327/python-3.11.0-rc.2-win32-x64.zip"
      },
      {
        "filename": "python-3.11.0-rc.2-win32-x86.zip",
        "arch": "x86",
        "platform": "win32",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3038386004/python-3.11.0-rc.2-win32-x86.zip"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.11.0-rc.2-3172748327/python-3.11.0-rc.2-win32-x86.zip"
      }
    ]
  },
@@ -594,6 +640,52 @@
      }
    ]
  },
+  {
+    "version": "3.10.8",
+    "stable": true,
+    "release_url": "https://github.com/actions/python-versions/releases/tag/3.10.8-3271105491",
+    "files": [
+      {
+        "filename": "python-3.10.8-darwin-x64.tar.gz",
+        "arch": "x64",
+        "platform": "darwin",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.10.8-3271105491/python-3.10.8-darwin-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.10.8-linux-18.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "18.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.10.8-3271105491/python-3.10.8-linux-18.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.10.8-linux-20.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "20.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.10.8-3271105491/python-3.10.8-linux-20.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.10.8-linux-22.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "22.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.10.8-3271105491/python-3.10.8-linux-22.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.10.8-win32-x64.zip",
+        "arch": "x64",
+        "platform": "win32",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.10.8-3271105491/python-3.10.8-win32-x64.zip"
+      },
+      {
+        "filename": "python-3.10.8-win32-x86.zip",
+        "arch": "x86",
+        "platform": "win32",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.10.8-3271105491/python-3.10.8-win32-x86.zip"
+      }
+    ]
+  },
  {
    "version": "3.10.7",
    "stable": true,
@@ -1511,6 +1603,34 @@
      }
    ]
  },
+  {
+    "version": "3.9.15",
+    "stable": true,
+    "release_url": "https://github.com/actions/python-versions/releases/tag/3.9.15-3271275280",
+    "files": [
+      {
+        "filename": "python-3.9.15-linux-18.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "18.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.15-3271275280/python-3.9.15-linux-18.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.9.15-linux-20.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "20.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.15-3271275280/python-3.9.15-linux-20.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.9.15-linux-22.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "22.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.15-3271275280/python-3.9.15-linux-22.04-x64.tar.gz"
+      }
+    ]
+  },
  {
    "version": "3.9.14",
    "stable": true,
@@ -3044,6 +3164,40 @@
      }
    ]
  },
+  {
+    "version": "3.7.15",
+    "stable": true,
+    "release_url": "https://github.com/actions/python-versions/releases/tag/3.7.15-3272001243",
+    "files": [
+      {
+        "filename": "python-3.7.15-darwin-x64.tar.gz",
+        "arch": "x64",
+        "platform": "darwin",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.7.15-3272001243/python-3.7.15-darwin-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.7.15-linux-18.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "18.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.7.15-3272001243/python-3.7.15-linux-18.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.7.15-linux-20.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "20.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.7.15-3272001243/python-3.7.15-linux-20.04-x64.tar.gz"
+      },
+      {
+        "filename": "python-3.7.15-linux-22.04-x64.tar.gz",
+        "arch": "x64",
+        "platform": "linux",
+        "platform_version": "22.04",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.7.15-3272001243/python-3.7.15-linux-22.04-x64.tar.gz"
+      }
+    ]
+  },
  {
    "version": "3.7.14",
    "stable": true,
Author	SHA1	Message	Date
Marko Zivic	a6c0fa93f8	Merge pull request #197 from e-korolevskii/fix-tests-for-python-3.12 Fix tests for python 3.12	2022-11-08 11:44:54 +01:00
Evgenii Korolevskii	929dab97d0	test(modules-test): Remove check for smtpd in python >= 3.12	2022-11-04 15:25:35 +01:00
Evgenii Korolevskii	149b806fe5	test(config-test): Remove libreadline check for version >= 3.12	2022-11-04 15:23:59 +01:00
Aleksandr Chebotov	1c70aa4fc9	Update workflow task (#196 ) * Update workflow task * use $env:GITHUB_OUTPUT * update submodule	2022-10-31 15:12:41 +01:00
github-actions[bot]	379db95d31	Update versions-manifest (#195 ) Co-authored-by: Service account <no-reply@microsoft.com>	2022-10-26 12:47:26 +02:00
Vladimir Safonkin	105f6b74ad	Skip sqlite test for python 3.11 and higher (#194 )	2022-10-26 12:14:20 +02:00
Marko Zivic	0d8f04f6f8	Merge pull request #193 from actions/update-versions-manifest-file [versions-manifest] Update for release from 10/25/2022	2022-10-25 12:42:29 +02:00
Service account	11c48b4025	Update versions-manifest	2022-10-25 10:37:31 +00:00
Hugo van Kemenade	e7a13ade71	Only run scheduled jobs on upstream (#145 )	2022-10-19 11:19:28 +02:00
github-actions[bot]	024142b9c3	Update versions-manifest (#192 ) Co-authored-by: Service account <no-reply@microsoft.com>	2022-10-18 12:37:53 +02:00
github-actions[bot]	5988ec7f4a	Update versions-manifest (#191 ) Co-authored-by: Service account <no-reply@microsoft.com>	2022-10-18 09:55:49 +02:00
github-actions[bot]	1982aae0b6	Update versions-manifest (#190 ) Co-authored-by: Service account <no-reply@microsoft.com>	2022-10-03 11:09:51 +02:00
Matthieu Darbois	1e1d9f9032	fix: setup OpenSSL certificates in `macos-pkg-setup-template.sh` (#189 ) The macOS pkg installer does not setup default certificates for OpenSSL. A script is provided by the macOS pkg installer to setup those using the certifi PyPI package. Let's run this script as part of the setup template in order to be able to do HTTPS downloads out of the box.	2022-10-03 10:13:05 +02:00
Marko Zivic	a1a012d197	Merge pull request #188 from actions/update-versions-manifest-file [versions-manifest] Update for release from 09/15/2022	2022-09-15 13:28:01 +02:00
Service account	ff7fd271bf	Update versions-manifest	2022-09-15 08:54:58 +00:00