Fix issue that visible runner groups are printed as if empty in log

Fixes #1131

charts/actions-runner-controller/Chart.yaml

@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.15.3
+version: 0.16.0
 
 # Used as the default manager tag value when no tag property is provided in the values.yaml
-appVersion: 0.20.4
+appVersion: 0.21.0
 
 home: https://github.com/actions-runner-controller/actions-runner-controller
 

controllers/horizontal_runner_autoscaler_webhook.go

@@ -614,11 +614,7 @@ func (autoscaler *HorizontalRunnerAutoscalerGitHubWebhook) getManagedRunnerGroup
 			return nil, fmt.Errorf("unsupported scale target kind: %v", kind)
 		}
 
-		if g == "" {
-			continue
-		}
-
-		if e == "" && o == "" {
+		if g != "" && e == "" && o == "" {
 			autoscaler.Log.V(1).Info(
 				"invalid runner group config in scale target: spec.group must be set along with either spec.enterprise or spec.organization",
 				"scaleTargetKind", kind,
@@ -631,6 +627,16 @@ func (autoscaler *HorizontalRunnerAutoscalerGitHubWebhook) getManagedRunnerGroup
 		}
 
 		if e != enterprise && o != org {
+			autoscaler.Log.V(1).Info(
+				"Skipped scale target irrelevant to event",
+				"eventOrganization", org,
+				"eventEnterprise", enterprise,
+				"scaleTargetKind", kind,
+				"scaleTargetGroup", g,
+				"scaleTargetEnterprise", e,
+				"scaleTargetOrganization", o,
+			)
+
 			continue
 		}
 

simulator/runnergroups.go

@@ -3,6 +3,7 @@ package simulator
 import (
 	"fmt"
 	"sort"
+	"strings"
 
 	"github.com/google/go-github/v39/github"
 )
@@ -96,6 +97,10 @@ type RunnerGroup struct {
 	Name  string
 }
 
+func (r RunnerGroup) String() string {
+	return fmt.Sprintf("RunnerGroup{Scope:%s, Kind:%s, Name:%s}", r.Scope, r.Kind, r.Name)
+}
+
 // VisibleRunnerGroups is a set of enterprise and organization runner groups
 // that are visible to a GitHub repository.
 // GitHub Actions chooses one of such visible group on which the workflow job is scheduled.
@@ -111,6 +116,15 @@ func NewVisibleRunnerGroups() *VisibleRunnerGroups {
 	return &VisibleRunnerGroups{}
 }
 
+func (g *VisibleRunnerGroups) String() string {
+	var gs []string
+	for _, g := range g.sortedGroups {
+		gs = append(gs, g.String())
+	}
+
+	return strings.Join(gs, ", ")
+}
+
 func (g *VisibleRunnerGroups) IsEmpty() bool {
 	return len(g.sortedGroups) == 0
 }