Add default value of githubWebhookServer.syncPeriod to chart (#622 )

* Add default value of `githubWebhookServer.syncPeriod` to chart * Bump chart version * Update README.md
Don't set default caBundle for webhooks (#617 )
2025-12-10 11:41:27 +00:00 · 2021-06-11 09:21:05 +09:00 · 2021-06-10 08:30:37 +09:00 · 2021-06-09 10:15:09 +01:00
5 changed files with 4 additions and 7 deletions
--- a/charts/actions-runner-controller/Chart.yaml
+++ b/charts/actions-runner-controller/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.12.0
+version: 0.12.2

 # Used as the default manager tag value when no tag property is provided in the values.yaml
 appVersion: 0.19.0
--- a/charts/actions-runner-controller/README.md
+++ b/charts/actions-runner-controller/README.md
@@ -53,6 +53,7 @@ _Default values are the defaults set in the charts values.yaml, some properties
 | `scope.singleNamespace`                                  | Limit the controller to watch a single namespace                                                                           | false                                                                |
 | `githubWebhookServer.logLevel`                           | Set the log level of the githubWebhookServer container                                                                     |                                                                      |
 | `githubWebhookServer.replicaCount`                       | Set the number of webhook server pods                                                                                      | 1                                                                    |
+| `githubWebhookServer.syncPeriod`                         | Set the period in which the controller reconciles the resources                                                            | 10m                                                                  |
 | `githubWebhookServer.enabled`                            | Deploy the webhook server pod                                                                                              | false                                                                |
 | `githubWebhookServer.secret.create`                      | Deploy the webhook hook secret                                                                                             | true                                                                 |
 | `githubWebhookServer.secret.name`                        | Set the name of the webhook hook secret                                                                                    | github-webhook-server                                                |
--- a/charts/actions-runner-controller/docs/UPGRADING.md
+++ b/charts/actions-runner-controller/docs/UPGRADING.md
@@ -21,6 +21,7 @@ Due to the above you can't just do a `helm upgrade` to release the latest versio
 1. Upgrade CRDs

 ```shell
+ # REMEMBER TO UPDATE THE CHART_VERSION TO RELEVANT CHART VERISON!!!!
 CHART_VERSION=0.11.0

 curl -L https://github.com/actions-runner-controller/actions-runner-controller/releases/download/actions-runner-controller-${CHART_VERSION}/actions-runner-controller-${CHART_VERSION}.tgz | tar zxv --strip 1 actions-runner-controller/crds
--- a/charts/actions-runner-controller/templates/webhook_configs.yaml
+++ b/charts/actions-runner-controller/templates/webhook_configs.yaml
@@ -9,7 +9,6 @@ metadata:
    cert-manager.io/inject-ca-from: {{ .Release.Namespace }}/{{ include "actions-runner-controller.servingCertName" . }}
 webhooks:
 - clientConfig:
-    caBundle: Cg==
    service:
      name: {{ include "actions-runner-controller.webhookServiceName" . }}
      namespace: {{ .Release.Namespace }}
@@ -28,7 +27,6 @@ webhooks:
    - runners
  sideEffects: None
 - clientConfig:
-    caBundle: Cg==
    service:
      name: {{ include "actions-runner-controller.webhookServiceName" . }}
      namespace: {{ .Release.Namespace }}
@@ -47,7 +45,6 @@ webhooks:
    - runnerdeployments
  sideEffects: None
 - clientConfig:
-    caBundle: Cg==
    service:
      name: {{ include "actions-runner-controller.webhookServiceName" . }}
      namespace: {{ .Release.Namespace }}
@@ -75,7 +72,6 @@ metadata:
    cert-manager.io/inject-ca-from: {{ .Release.Namespace }}/{{ include "actions-runner-controller.servingCertName" . }}
 webhooks:
 - clientConfig:
-    caBundle: Cg==
    service:
      name: {{ include "actions-runner-controller.webhookServiceName" . }}
      namespace: {{ .Release.Namespace }}
@@ -94,7 +90,6 @@ webhooks:
    - runners
  sideEffects: None
 - clientConfig:
-    caBundle: Cg==
    service:
      name: {{ include "actions-runner-controller.webhookServiceName" . }}
      namespace: {{ .Release.Namespace }}
@@ -113,7 +108,6 @@ webhooks:
    - runnerdeployments
  sideEffects: None
 - clientConfig:
-    caBundle: Cg==
    service:
      name: {{ include "actions-runner-controller.webhookServiceName" . }}
      namespace: {{ .Release.Namespace }}
--- a/charts/actions-runner-controller/values.yaml
+++ b/charts/actions-runner-controller/values.yaml
@@ -113,6 +113,7 @@ scope:
 githubWebhookServer:
  enabled: false
  replicaCount: 1
+  syncPeriod: 10m
  secret:
    create: true
    name: "github-webhook-server"
Author	SHA1	Message	Date
Hidetake Iwata	dc5f90025c	Add default value of `githubWebhookServer.syncPeriod` to chart (#622 ) * Add default value of `githubWebhookServer.syncPeriod` to chart * Bump chart version * Update README.md	2021-06-11 09:21:05 +09:00
John Stewart	8566a4f453	Don't set default caBundle for webhooks (#617 ) * Don't set default caBundle for webhooks Fixes #614 * bump chart version	2021-06-10 08:30:37 +09:00
toast-gear	3366dc9a63	docs: adding in the caveat to upgrade docs	2021-06-09 10:15:09 +01:00