Merge 74f4732401 into 21e213fb19

headless/api/src/main/java/com/tencent/supersonic/headless/api/pojo/request/QueryStructReq.java

@@ -170,9 +170,6 @@ public class QueryStructReq extends SemanticQueryReq {
         // 5. Set the limit clause
         plainSelect.setLimit(buildLimit(queryStructReq));
 
-        // 6. Set having clause
-        plainSelect.setHaving(buildHavingClause(queryStructReq));
-
         select.setSelect(plainSelect);
 
         // 6. Set where clause
@@ -242,8 +239,7 @@ public class QueryStructReq extends SemanticQueryReq {
 
     private GroupByElement buildGroupByElement(QueryStructReq queryStructReq) {
         List<String> groups = queryStructReq.getGroups();
-        if ((!CollectionUtils.isEmpty(groups) && !queryStructReq.getAggregators().isEmpty())
+        if (!CollectionUtils.isEmpty(groups) && !queryStructReq.getAggregators().isEmpty()) {
-                || !queryStructReq.getMetricFilters().isEmpty()) {
             GroupByElement groupByElement = new GroupByElement();
             for (String group : groups) {
                 groupByElement.addGroupByExpression(new Column(group));
@@ -293,23 +289,4 @@ public class QueryStructReq extends SemanticQueryReq {
         }
         return Constants.TABLE_PREFIX + StringUtils.join(modelIds, "_");
     }
-
-    public Expression buildHavingClause(QueryStructReq queryStructReq) {
-        if (queryStructReq.getMetricFilters().isEmpty()) {
-            return null;
-        }
-
-        List<Filter> filters = queryStructReq.getMetricFilters();
-        SqlFilterUtils sqlFilterUtils = ContextUtils.getBean(SqlFilterUtils.class);
-        String havingClause = sqlFilterUtils.getWhereClause(filters, false);
-        if (StringUtils.isNotBlank(havingClause)) {
-            try {
-                return CCJSqlParserUtil.parseCondExpression(havingClause);
-            } catch (JSQLParserException e) {
-                log.error("Failed to parse having clause", e);
-            }
-        }
-        return null;
-    }
-
 }

headless/server/src/test/java/com/tencent/supersonic/headless/server/utils/SqlVariableParseUtilsTest.java

@@ -34,18 +34,6 @@ public class SqlVariableParseUtilsTest {
         Assertions.assertEquals(expectedSql, actualSql);
     }
 
-    @Test
-    void testParseSql_if() {
-        String sql = "select * from t_$interval$ where id = $id$ $if(name)$and name = $name$$endif$";
-        List<SqlVariable> variables = Lists.newArrayList(mockNumSqlVariable(),
-                mockExprSqlVariable(), mockStrSqlVariable());
-        List<Param> params =
-                Lists.newArrayList(mockIdParam(), mockNameParam(), mockIntervalParam());
-        String actualSql = SqlVariableParseUtils.parse(sql, variables, params);
-        String expectedSql = "select * from t_wk where id = 2 and name = 'alice'";
-        Assertions.assertEquals(expectedSql, actualSql);
-    }
-
     private SqlVariable mockNumSqlVariable() {
         return mockSqlVariable("id", VariableValueType.NUMBER, 1);
     }