From f794eee5a23ccad5360e45a61dac714a38ae6f7b Mon Sep 17 00:00:00 2001
From: tristanliu <37809633+sevenliu1896@users.noreply.github.com>
Date: Sat, 12 Oct 2024 17:23:45 +0800
Subject: [PATCH] [improvement][headless-fe] Added new functionality to the
 assistant's memory management system (#1792)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* [improvement][semantic-fe] Fixing the abnormal state of the popup when creating a model.

* [improvement][semantic-fe] Adding permission logic for bulk operations in the indicator market.

* [improvement][semantic-fe] Adding the ability to download and transpose data.

* [improvement][semantic-fe] Fixing the initialization issue with the date selection component in the indicator details page when switching time granularity.

* [improvement][semantic-fe] Fixing the logic error in the dimension value setting.

* [improvement][semantic-fe] Fixing the synchronization issue with the question and answer settings information.

* [improvement][semantic-fe] Optimizing the canvas functionality for better performance and user experience.

* [improvement][semantic-fe] Optimizing the update process for drawing model relationship edges in the canvas.

* [improvement][semantic-fe] Changing the line type for canvas connections.

* [improvement][semantic-fe] Replacing the initialization variable from "semantic" to "headless".

* [improvement][semantic-fe] Fixing the missing migration issue for default drill-down dimension configuration in model editing. Additionally, optimizing the data retrieval method for initializing fields in the model.

* [improvement][semantic-fe] Updating the logic for the fieldName.

* [improvement][semantic-fe] Adjusting the position of the metrics tab.

* [improvement][semantic-fe] Changing the 字段名称 to 英文名称.

* [improvement][semantic-fe] Fix metric measurement deletion.

* [improvement][semantic-fe] UI optimization for metric details page.

* [improvement][semantic-fe] UI optimization for metric details page.

* [improvement][semantic-fe] UI adjustment for metric details page.

* [improvement][semantic-fe] The granularity field in the time type of model editing now supports setting it as empty.

* [improvement][semantic-fe] Added field type and metric type to the metric creation options.

* [improvement][semantic-fe] The organization structure selection feature has been added to the permission management.

* [improvement][semantic-fe] Improved user experience for the metric list.

* [improvement][semantic-fe] fix update the metric list.

* [improvement][headless-fe] Added view management functionality.

* [improvement][headless-fe] The view management functionality has been added. This feature allows users to create, edit, and manage different views within the system.

* [improvement][headless-fe] Added model editing side effect detection.

* [improvement][headless-fe] Fixed the logic error in view editing.

* [improvement][headless-fe] Fixed the issue with initializing dimension associations in metric settings.

* [improvement][headless-fe] Added the ability to hide the Q&A settings entry point.

* [improvement][headless-fe] Fixed the issue with selecting search results in metric field creation.

* [improvement][headless-fe] Added search functionality to the field list in model editing.

* [improvement][headless-fe] fix the field list in model editing

* [improvement][headless-fe] Restructured the data for the dimension value settings interface.

* [improvement][headless-fe] Added dynamic variable functionality to model creation based on SQL scripts.

* [improvement][headless-fe] Added support for passing dynamic variables as parameters in the executeSql function.

* [improvement][headless-fe] Resolved the issue where users were unable to select all options for dimensions, metrics, and fields in the metric generation process.

* [improvement][headless-fe] Replaced the term "view" with "dataset"

* [improvement][headless-fe] Added the ability to export metrics and dimensions to a specific target.

* [improvement][headless-fe] Enhanced dataset creation to support the tag mode.

* [improvement][headless-fe] Added tag value setting.

* [improvement][headless-fe] Optimized the tag setting system.

* [improvement][headless-fe] Optimized the tag setting system.

* [improvement][headless-fe] Updated the data initialization for model editing to use API requests instead.

* [improvement][headless-fe] Added search functionality to model management.

* [improvement][headless-fe] Removed field null validation during model editing.

* [improvement][headless-fe] Updated the batch operation button component.

* [improvement][headless-fe] Optimized the logic for initializing indicators in dimension value settings.

* [improvement][headless-fe] Adjusted the length of the input field for model editing names.

* [improvement][headless-fe]  Lock the version of the @ant-design/pro-table component and replace it with @ant-design/pro-components.

* [improvement][headless-fe] Optimized the style of the metrics market and tags market.

* [improvement][headless-fe] The quick creation of model fields now defaults to using the "comment" field for filling.

* [improvement][headless-fe] The quick creation of model fields now defaults to using the "comment" field for filling

* [improvement][headless-fe] The quick creation of model fields now defaults to using the "comment" field for filling.

* [improvement][headless-fe] Fixed the issue where the conditions for metric measurement creation were not being saved correctly.

* [improvement][headless-fe] Default value setting for hiding dimensions.

* [improvement][headless-fe] Updated the file imports in the project.

* [improvement][headless-fe] Adjusted the logic for displaying the tab in the theme domain.

* [improvement][headless-fe] Added term management functionality.

* [improvement][headless-fe] When creating a model, the current metric operator now allows for clearance.

* [improvement][headless-fe] Term management interface transformation

* [improvement][headless-fe] Migrating scaffold version to @umi/max

* [improvement][headless-fe] remove modle column

* [improvement][headless-fe] 1.Added configuration for the large language model in the agent; 2.upgraded React version from 17 to 18; 3.modified some UI effects.

* [improvement][headless-fe] Added a simplified mode to the question-answering system.

* [improvement][headless-fe] remove pnpm-lock

* [improvement][headless-fe] add pnpm-lock

* [improvement][headless-fe] Fixed the issue with passing the modelId during initialization.

* [improvement][headless-fe] Fixed the issue with abnormal comments during model creation.

* [improvement][headless-fe] fix  build bugs

* [improvement][headless-fe]  change build config

* [improvement][headless-fe] route config change

* [improvement][headless-fe] Optimized data updating when switching domains.

* [improvement][headless-fe] css change

* [improvement][semantic-fe] logo css change

* [improvement][semantic-fe] system config add defaultValue support

* [improvement][semantic-fe] tag mode wording change

* [improvement][semantic-fe] fix metric edit page init error

* [improvement][supersonic-fe] Updated the way chat projects are imported in supersonic-fe.

* [improvement][chat-engine] Added a background silent mode for watching chat projects.

* [improvement][supersonic-fe] fix proxy url

* [improvement][headless-fe] agent setting update

* [improvement][headless-fe] Agent configuration: Added connectivity testing for large models.

* [improvement][headless-fe] Chat: Enabled integration with agent configuration.

* [improvement][headless-fe] SQL formatter: Updated the import method.

* [improvement][headless-fe] login fixed

* [improvement][headless-fe] Agent: Optimized the logic for saving.

* [improvement][headless-fe] Model management: Integrated into the main theme domain.

* [improvement][headless-fe] Sensitivity: Added bulk modification functionality.

* [improvement][headless-fe] wording change

* [improvement][headless-fe] Prompt configuration: Added the ability to configure prompts.

* [improvement][headless-fe] Added the ability to configure embedding models.

* [improvement][headless-fe] hidden configure embedding models.

* [improvement][headless-fe] Connection test prompt update for large language model settings.

* [improvement][headless-fe]  add memory review config

* [improvement][headless-fe] Rollback of data structure for large language model configuration.

* [improvement][headless-fe] Added dependency relationships between various items in system configuration.

* [improvement][headless-fe] Added password parsing to the generation rules of system settings.

* [improvement][headless-fe] Added slider parsing to the generation rules of system settings.

* [improvement][headless-fe] Optimized the logic for initializing values in system settings.

* [improvement][headless-fe] Optimized the time format

* [improvement][headless-fe] Unified the SQL generation method for data sets to ensure consistency and improve efficiency.

* [improvement][headless-fe] Added support for data sets with non-partitioned time fields

* [improvement][headless-fe] Added support for editing time formats in dimension settings

* [improvement][headless-fe] Rolled back the time parameter in the metric details page to its previous state

* [improvement][headless-fe] Fixed the issue with hidden field validation when editing dimensions

* [improvement][headless-fe] Added a connectivity test for large models in the system settings

* [improvement][headless-fe] Changed the METRIC type in ChatContextType queryType to AGGREGATE

* [improvement][headless-fe] Added query and batch delete operations to the terminology management feature

* [improvement][headless-fe] Enhanced the memory management feature by adding sorting functionality and other optimization features.

* [improvement][headless-fe] Resolved the compatibility issue with the backend service where the updatedAt and other time fields were not being properly converted to the updated_at format for sorting purposes.

* [improvement][headless-fe] Added a configuration interface for large language models

* [improvement][headless-fe] Introduced a new configuration option in the assistant module specifically for large model applications.

* [improvement][headless-fe] Replaced the agentConfig with toolConfig

* [improvement][headless-fe] Resolved the issue with the test connection parameters for the large model configuration.

* [improvement][headless-fe] Implemented a new feature where the tool configuration types can be fetched from the backend API

* [improvement][headless-fe] Updated the dimension value settings to retrieve and display values from a dictionary.

* [improvement][headless-fe] Adjusted the pageSize of the dimension value settings list to 20.

* [improvement][headless-fe] Introduced a revamped configuration for the large model in the assistant module.

* [improvement][headless-fe] Added new functionality to the assistant's memory management system

---------

Co-authored-by: tristanliu <tristanliu@tencent.com>
---
 .../src/pages/Agent/AgentForm.tsx             |   7 +-
 .../src/pages/Agent/MemorySection.tsx         |  28 ++++-
 .../src/pages/Agent/MemorySettingModal.tsx    | 105 ++++++++++++++++++
 .../supersonic-fe/src/pages/Agent/service.ts  |   7 ++
 .../supersonic-fe/src/pages/Agent/type.ts     |   1 +
 5 files changed, 146 insertions(+), 2 deletions(-)
 create mode 100644 webapp/packages/supersonic-fe/src/pages/Agent/MemorySettingModal.tsx

diff --git a/webapp/packages/supersonic-fe/src/pages/Agent/AgentForm.tsx b/webapp/packages/supersonic-fe/src/pages/Agent/AgentForm.tsx
index 9115727c5..b7367c6af 100644
--- a/webapp/packages/supersonic-fe/src/pages/Agent/AgentForm.tsx
+++ b/webapp/packages/supersonic-fe/src/pages/Agent/AgentForm.tsx
@@ -54,6 +54,7 @@ const AgentForm: React.FC<Props> = ({ editAgent, onSaveAgent, onCreateToolBtnCli
       const initData = {
         ...editAgent,
         enableSearch: editAgent.enableSearch !== 0,
+        enableFeedback: editAgent.enableFeedback !== 0,
         toolConfig: { ...defaultAgentConfig, ...config },
       };
 
@@ -152,12 +153,13 @@ const AgentForm: React.FC<Props> = ({ editAgent, onSaveAgent, onCreateToolBtnCli
       }) as any,
       examples: examples.map((example) => example.question),
       enableSearch: values.enableSearch ? 1 : 0,
+      enableFeedback: values.enableFeedback ? 1 : 0,
       chatAppConfig: Object.keys(defaultChatAppConfig).reduce((mergeConfig, key) => {
         return {
           ...mergeConfig,
           [key]: {
             ...defaultChatAppConfig[key],
-            ...(values.chatAppConfig[key] ? values.chatAppConfig[key] : {}),
+            ...(values.chatAppConfig?.[key] ? values.chatAppConfig[key] : {}),
           },
         };
       }, {}),
@@ -188,6 +190,9 @@ const AgentForm: React.FC<Props> = ({ editAgent, onSaveAgent, onCreateToolBtnCli
           <FormItem name="enableSearch" label="开启输入联想" valuePropName="checked">
             <Switch />
           </FormItem>
+          <FormItem name="enableFeedback" label="开启用户确认" valuePropName="checked">
+            <Switch />
+          </FormItem>
           {/* <FormItem
             name={['multiTurnConfig', 'enableMultiTurn']}
             label="开启多轮对话"
diff --git a/webapp/packages/supersonic-fe/src/pages/Agent/MemorySection.tsx b/webapp/packages/supersonic-fe/src/pages/Agent/MemorySection.tsx
index c456be778..65fedb48f 100644
--- a/webapp/packages/supersonic-fe/src/pages/Agent/MemorySection.tsx
+++ b/webapp/packages/supersonic-fe/src/pages/Agent/MemorySection.tsx
@@ -4,6 +4,7 @@ import React, { useState } from 'react';
 import { MemoryType, ReviewEnum, StatusEnum } from './type';
 import { getMemeoryList, saveMemory, batchDeleteMemory } from './service';
 import { Popover, Input, Badge, Radio, Select, Button, message } from 'antd';
+import MemorySettingModal from './MemorySettingModal';
 import styles from './style.less';
 import { isArrayOfValues } from '@/utils/utils';
 import dayjs from 'dayjs';
@@ -19,6 +20,7 @@ const MemorySection = ({ agentId }: Props) => {
   const [dataSource, setDataSource] = useState<readonly MemoryType[]>([]);
   const [loading, setLoading] = useState(false);
   const [filters, setFilters] = useState<any>({});
+  const [createModalVisible, setCreateModalVisible] = useState<boolean>(false);
   const { question, status, llmReviewRet, humanReviewRet } = filters;
   const [selectedRowKeys, setSelectedRowKeys] = useState<number[]>([]);
 
@@ -55,7 +57,7 @@ const MemorySection = ({ agentId }: Props) => {
       ),
     },
     {
-      title: '大模型解析SQL',
+      title: '语义S2SQL',
       dataIndex: 's2sql',
       width: 220,
       valueType: 'textarea',
@@ -342,6 +344,17 @@ const MemorySection = ({ agentId }: Props) => {
         <Button type="primary" onClick={() => loadMemoryList()}>
           查询
         </Button>
+        {agentId && (
+          <Button
+            type="primary"
+            onClick={() => {
+              setCreateModalVisible(true);
+            }}
+          >
+            新增
+          </Button>
+        )}
+
         <Button
           key="batchDelete"
           type="primary"
@@ -376,6 +389,19 @@ const MemorySection = ({ agentId }: Props) => {
           onChange: setEditableRowKeys,
         }}
       />
+      {createModalVisible && agentId && (
+        <MemorySettingModal
+          open={true}
+          agentId={agentId}
+          onCancel={() => {
+            setCreateModalVisible(false);
+          }}
+          onSubmit={() => {
+            setCreateModalVisible(false);
+            loadMemoryList();
+          }}
+        />
+      )}
     </div>
   );
 };
diff --git a/webapp/packages/supersonic-fe/src/pages/Agent/MemorySettingModal.tsx b/webapp/packages/supersonic-fe/src/pages/Agent/MemorySettingModal.tsx
new file mode 100644
index 000000000..8ef69a8cd
--- /dev/null
+++ b/webapp/packages/supersonic-fe/src/pages/Agent/MemorySettingModal.tsx
@@ -0,0 +1,105 @@
+import React, { useState, useRef } from 'react';
+import { Modal, Form, Input, message, Button, Space, Radio } from 'antd';
+import { createMemory } from './service';
+import { StatusEnum } from './type';
+import { formLayout } from '@/components/FormHelper/utils';
+
+export type CreateFormProps = {
+  onCancel: () => void;
+  agentId: number;
+  open: boolean;
+  onSubmit: (values?: any) => void;
+};
+
+const FormItem = Form.Item;
+const TextArea = Input.TextArea;
+
+const MemorySettingModal: React.FC<CreateFormProps> = ({ onCancel, agentId, open, onSubmit }) => {
+  const [form] = Form.useForm();
+  const [loading, setLoading] = useState<boolean>(false);
+
+  const createTermConfig = async (data: any) => {
+    setLoading(true);
+    const { code, msg } = await createMemory({
+      ...data,
+      agentId,
+    });
+    setLoading(false);
+    if (code === 200) {
+      onSubmit?.();
+    } else {
+      message.error(msg);
+    }
+  };
+  const renderFooter = () => {
+    return (
+      <>
+        <Space>
+          <Button
+            onClick={() => {
+              onCancel?.();
+            }}
+          >
+            取消
+          </Button>
+
+          <Button
+            type="primary"
+            loading={loading}
+            onClick={() => {
+              const formData = form.getFieldsValue();
+              createTermConfig(formData);
+            }}
+          >
+            保 存
+          </Button>
+        </Space>
+      </>
+    );
+  };
+  return (
+    <Modal
+      width={600}
+      destroyOnClose
+      title="记忆设置"
+      style={{ top: 48 }}
+      maskClosable={false}
+      open={open}
+      footer={renderFooter()}
+      onCancel={onCancel}
+    >
+      <Form
+        {...formLayout}
+        form={form}
+        layout="vertical"
+        onValuesChange={(value) => {}}
+        initialValues={{
+          status: StatusEnum.PENDING,
+        }}
+      >
+        <FormItem
+          name="question"
+          label="用户问题"
+          rules={[{ required: true, message: '请输入用户问题' }]}
+        >
+          <Input placeholder="请输入用户问题" />
+        </FormItem>
+        <FormItem name="dbSchema" label="Schema映射">
+          <TextArea placeholder="请输入Schema映射" style={{ height: 100 }} />
+        </FormItem>
+        <FormItem name="s2sql" label="语义S2SQL">
+          <TextArea placeholder="请输入语义S2SQL" style={{ height: 100 }} />
+        </FormItem>
+        <FormItem name="status" label="状态">
+          <Radio.Group size="small" buttonStyle="solid">
+            <Radio.Button value={StatusEnum.PENDING}>待定</Radio.Button>
+            <Radio.Button value={StatusEnum.ENABLED}>已启用</Radio.Button>
+            <Radio.Button value={StatusEnum.DISABLED}>已禁用</Radio.Button>
+          </Radio.Group>
+        </FormItem>
+      </Form>
+    </Modal>
+  );
+};
+
+export default MemorySettingModal;
diff --git a/webapp/packages/supersonic-fe/src/pages/Agent/service.ts b/webapp/packages/supersonic-fe/src/pages/Agent/service.ts
index e362e4fa8..1d3be5c47 100644
--- a/webapp/packages/supersonic-fe/src/pages/Agent/service.ts
+++ b/webapp/packages/supersonic-fe/src/pages/Agent/service.ts
@@ -69,3 +69,10 @@ export function getToolTypes(): Promise<any> {
     method: 'GET',
   });
 }
+
+export function createMemory(data: any) {
+  return request<Result<string>>('/api/chat/memory/createMemory', {
+    method: 'POST',
+    data,
+  });
+}
diff --git a/webapp/packages/supersonic-fe/src/pages/Agent/type.ts b/webapp/packages/supersonic-fe/src/pages/Agent/type.ts
index 1acd94b4b..d7fa9a1fb 100644
--- a/webapp/packages/supersonic-fe/src/pages/Agent/type.ts
+++ b/webapp/packages/supersonic-fe/src/pages/Agent/type.ts
@@ -93,6 +93,7 @@ export type AgentType = {
   examples?: string[];
   status?: 0 | 1;
   enableSearch?: 0 | 1;
+  enableFeedback?: 0 | 1;
   toolConfig?: string;
   // modelConfig?: LlmConfigType;
   chatAppConfig: ChatAppConfig;