mirror of
https://github.com/tencentmusic/supersonic.git
synced 2025-12-12 12:37:55 +00:00
(improvement)(headless)Optimize compatibility and robustness in ontology query translation.
(improvement)(headless)Optimize compatibility and robustness in ontology query translation.
This commit is contained in:
@@ -91,7 +91,8 @@ public class FiledFilterReplaceVisitor extends ExpressionVisitorAdapter {
|
|||||||
}
|
}
|
||||||
|
|
||||||
ExpressionList<?> leftFunctionParams = leftFunction.getParameters();
|
ExpressionList<?> leftFunctionParams = leftFunction.getParameters();
|
||||||
if (CollectionUtils.isEmpty(leftFunctionParams)) {
|
if (CollectionUtils.isEmpty(leftFunctionParams)
|
||||||
|
|| !(leftFunctionParams.get(0) instanceof Column)) {
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -78,7 +78,8 @@ public abstract class SemanticNode {
|
|||||||
scope.getValidator().getCatalogReader().getRootSchema(), engineType);
|
scope.getValidator().getCatalogReader().getRootSchema(), engineType);
|
||||||
if (Configuration.getSqlAdvisor(sqlValidatorWithHints, engineType).getReservedAndKeyWords()
|
if (Configuration.getSqlAdvisor(sqlValidatorWithHints, engineType).getReservedAndKeyWords()
|
||||||
.contains(expression.toUpperCase())) {
|
.contains(expression.toUpperCase())) {
|
||||||
if (engineType == EngineType.HANADB || engineType == EngineType.PRESTO || engineType == EngineType.TRINO) {
|
if (engineType == EngineType.HANADB || engineType == EngineType.PRESTO
|
||||||
|
|| engineType == EngineType.TRINO) {
|
||||||
expression = String.format("\"%s\"", expression);
|
expression = String.format("\"%s\"", expression);
|
||||||
} else {
|
} else {
|
||||||
expression = String.format("`%s`", expression);
|
expression = String.format("`%s`", expression);
|
||||||
@@ -166,9 +167,9 @@ public abstract class SemanticNode {
|
|||||||
if (sqlNode instanceof SqlBasicCall) {
|
if (sqlNode instanceof SqlBasicCall) {
|
||||||
SqlBasicCall sqlBasicCall = (SqlBasicCall) sqlNode;
|
SqlBasicCall sqlBasicCall = (SqlBasicCall) sqlNode;
|
||||||
if (sqlBasicCall.getOperator().getKind().equals(SqlKind.AS)) {
|
if (sqlBasicCall.getOperator().getKind().equals(SqlKind.AS)) {
|
||||||
if (sqlBasicCall.getOperandList().get(0) instanceof SqlSelect) {
|
SqlNode innerQuery = sqlBasicCall.getOperandList().get(0);
|
||||||
SqlSelect table = (SqlSelect) sqlBasicCall.getOperandList().get(0);
|
if (innerQuery instanceof SqlCall) {
|
||||||
return table;
|
return innerQuery;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -69,7 +69,13 @@ public class SqlBuilder {
|
|||||||
SqlNode parserNode = tableView.build();
|
SqlNode parserNode = tableView.build();
|
||||||
DatabaseResp database = queryStatement.getOntology().getDatabase();
|
DatabaseResp database = queryStatement.getOntology().getDatabase();
|
||||||
EngineType engineType = EngineType.fromString(database.getType());
|
EngineType engineType = EngineType.fromString(database.getType());
|
||||||
parserNode = optimizeParseNode(parserNode, engineType);
|
try {
|
||||||
|
parserNode = optimizeParseNode(parserNode, engineType);
|
||||||
|
} catch (Exception e) {
|
||||||
|
// failure in optimization phase doesn't affect the query result,
|
||||||
|
// just ignore it
|
||||||
|
log.error("optimizeParseNode error", e);
|
||||||
|
}
|
||||||
return SemanticNode.getSql(parserNode, engineType);
|
return SemanticNode.getSql(parserNode, engineType);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user