From b319f4682a730b342e1ae235e1730fa1e258f066 Mon Sep 17 00:00:00 2001
From: SuperLiChaoRen <100331512+SuperLiChaoRen@users.noreply.github.com>
Date: Sat, 20 Jul 2024 10:02:29 +0800
Subject: [PATCH] (fix)(common)fix duplication when adding data to the vector
 library (#1433)

---
 .../supersonic/common/service/impl/EmbeddingServiceImpl.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/src/main/java/com/tencent/supersonic/common/service/impl/EmbeddingServiceImpl.java b/common/src/main/java/com/tencent/supersonic/common/service/impl/EmbeddingServiceImpl.java
index df71dc11e..a8a0f590d 100644
--- a/common/src/main/java/com/tencent/supersonic/common/service/impl/EmbeddingServiceImpl.java
+++ b/common/src/main/java/com/tencent/supersonic/common/service/impl/EmbeddingServiceImpl.java
@@ -59,6 +59,7 @@ public class EmbeddingServiceImpl implements EmbeddingService {
                     continue;
                 }
                 embeddingStore.add(embedding, query);
+                cache.put(TextSegmentConvert.getQueryId(query), true);
             } catch (Exception e) {
                 log.error("embeddingModel embed error question: {}, embeddingStore: {}", question,
                         embeddingStore.getClass().getSimpleName(), e);
@@ -85,7 +86,6 @@ public class EmbeddingServiceImpl implements EmbeddingService {
         EmbeddingSearchResult result = embeddingStore.search(request);
         List<EmbeddingMatch<TextSegment>> relevant = result.matches();
         boolean exists = CollectionUtils.isNotEmpty(relevant);
-        cache.put(queryId, exists);
         return exists;
     }