From a82e3c8b1e9d2e053c2e2a68b250c56cc2327283 Mon Sep 17 00:00:00 2001 From: williamhliu <137068196+williamhliu@users.noreply.github.com> Date: Wed, 11 Sep 2024 19:37:31 +0800 Subject: [PATCH] (improvement)(chat-sdk) optimize card title (#1653) --- .../chat-sdk/src/components/ChatMsg/Bar/index.tsx | 12 ++++++++++-- .../src/components/ChatMsg/MetricTrend/index.tsx | 15 ++++++--------- .../chat-sdk/src/components/ChatMsg/index.tsx | 2 ++ 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/webapp/packages/chat-sdk/src/components/ChatMsg/Bar/index.tsx b/webapp/packages/chat-sdk/src/components/ChatMsg/Bar/index.tsx index 287b6b8b8..c3898a480 100644 --- a/webapp/packages/chat-sdk/src/components/ChatMsg/Bar/index.tsx +++ b/webapp/packages/chat-sdk/src/components/ChatMsg/Bar/index.tsx @@ -14,13 +14,21 @@ import { Spin } from 'antd'; type Props = { data: MsgDataType; + question: string; triggerResize?: boolean; loading: boolean; metricField: ColumnType; onApplyAuth?: (model: string) => void; }; -const BarChart: React.FC = ({ data, triggerResize, loading, metricField, onApplyAuth }) => { +const BarChart: React.FC = ({ + data, + question, + triggerResize, + loading, + metricField, + onApplyAuth, +}) => { const chartRef = useRef(); const [instance, setInstance] = useState(); @@ -175,7 +183,7 @@ const BarChart: React.FC = ({ data, triggerResize, loading, metricField, return (
-
{metricColumn?.name}
+
{question}
diff --git a/webapp/packages/chat-sdk/src/components/ChatMsg/MetricTrend/index.tsx b/webapp/packages/chat-sdk/src/components/ChatMsg/MetricTrend/index.tsx index a10499d58..e409a7c42 100644 --- a/webapp/packages/chat-sdk/src/components/ChatMsg/MetricTrend/index.tsx +++ b/webapp/packages/chat-sdk/src/components/ChatMsg/MetricTrend/index.tsx @@ -22,6 +22,7 @@ const metricChartSelectOptions = [ type Props = { data: MsgDataType; + question: string; chartIndex: number; triggerResize?: boolean; loading: boolean; @@ -34,6 +35,7 @@ type Props = { const MetricTrend: React.FC = ({ data, + question, chartIndex, triggerResize, loading, @@ -65,16 +67,11 @@ const MetricTrend: React.FC = ({ return (
- {metricFields?.length === 1 && ( -
-
- {activeMetricField?.name} -
+
+
+ {question}
- )} +
{!isMobile && diff --git a/webapp/packages/chat-sdk/src/components/ChatMsg/index.tsx b/webapp/packages/chat-sdk/src/components/ChatMsg/index.tsx index 998b75042..6a46a5e1c 100644 --- a/webapp/packages/chat-sdk/src/components/ChatMsg/index.tsx +++ b/webapp/packages/chat-sdk/src/components/ChatMsg/index.tsx @@ -197,6 +197,7 @@ const ChatMsg: React.FC = ({ queryColumns: columns, queryResults: dataSource, }} + question={question} loading={loading} chartIndex={chartIndex} triggerResize={triggerResize} @@ -210,6 +211,7 @@ const ChatMsg: React.FC = ({ return (