[improvement][Headless] Add unit test cases and remove unnecessary logs. (#698)

This commit is contained in:
lexluo09
2024-01-30 16:46:06 +08:00
committed by GitHub
parent fdfad515dd
commit 954c67c947
33 changed files with 301 additions and 194 deletions

View File

@@ -22,7 +22,7 @@ public class CaffeineCacheManager implements CacheManager {
@Override
public Boolean put(String key, Object value) {
log.info("[put caffeineCache] key:{}, value:{}", key, value);
log.debug("[put caffeineCache] key:{}, value:{}", key, value);
caffeineCache.put(key, value);
return true;
}
@@ -30,7 +30,7 @@ public class CaffeineCacheManager implements CacheManager {
@Override
public Object get(String key) {
Object value = caffeineCache.asMap().get(key);
log.info("[get caffeineCache] key:{}, value:{}", key, value);
log.debug("[get caffeineCache] key:{}, value:{}", key, value);
return value;
}

View File

@@ -23,7 +23,7 @@ public class DefaultQueryCache implements QueryCache {
public Object query(SemanticQueryReq semanticQueryReq, String cacheKey) {
if (isCache(semanticQueryReq)) {
Object result = cacheManager.get(cacheKey);
log.info("queryFromCache, key:{}, semanticQueryReq:{}", cacheKey, semanticQueryReq);
log.info("query from cache, key:{}", cacheKey);
return result;
}
return null;
@@ -36,7 +36,7 @@ public class DefaultQueryCache implements QueryCache {
log.warn("exception:", exception);
return null;
});
log.info("add record to cache, key:{}", cacheKey);
log.info("put to cache, key:{}", cacheKey);
return true;
}
return false;

View File

@@ -31,7 +31,6 @@ public class JdbcExecutor implements QueryExecutor {
}
log.info("query SQL: {}", queryStatement.getSql());
Database database = queryStatement.getSemanticModel().getDatabase();
log.info("database info:{}", database);
SemanticQueryResp queryResultWithColumns = new SemanticQueryResp();
SqlUtils sqlUtils = this.sqlUtils.init(database);
sqlUtils.queryInternal(queryStatement.getSql(), queryResultWithColumns);

View File

@@ -42,7 +42,7 @@ public class CalciteSqlParser implements SqlParser {
getSqlByView(aggBuilder.getSql(engineType), queryStatement.getViewSql(),
queryStatement.getViewAlias()), engineType);
if (Objects.nonNull(simplifySql) && !simplifySql.isEmpty()) {
log.info("simplifySql [{}]", simplifySql);
log.debug("simplifySql [{}]", simplifySql);
queryStatement.setViewSimplifySql(simplifySql);
}
}

View File

@@ -160,7 +160,6 @@ public class AggPlanner implements Planner {
private SqlNode optimizeSql(String sql, EngineType engineType) {
try {
log.info("before optimize:[{}]", sql);
SqlNode sqlNode = SqlParser.create(sql, Configuration.getParserConfig(engineType)).parseStmt();
if (Objects.nonNull(sqlNode)) {
return SemanticNode.optimize(scope, schema, sqlNode, engineType);

View File

@@ -106,7 +106,6 @@ public class SqlUtils {
JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource);
jdbcTemplate.setDatabaseProductName(database.getName());
jdbcTemplate.setFetchSize(500);
log.info("jdbcTemplate:{}, dataSource:{}", jdbcTemplate, dataSource);
return jdbcTemplate;
}

View File

@@ -221,7 +221,7 @@ public class QueryServiceImpl implements QueryService {
@Override
public <T> ExplainResp explain(ExplainSqlReq<T> explainSqlReq, User user) throws Exception {
T queryReq = explainSqlReq.getQueryReq();
QueryStatement queryStatement = buildQueryStatement((QuerySqlReq) queryReq, user);
QueryStatement queryStatement = buildQueryStatement((SemanticQueryReq) queryReq, user);
queryStatement = plan(queryStatement);
return getExplainResp(queryStatement);
}
@@ -332,14 +332,12 @@ public class QueryServiceImpl implements QueryService {
private QueryStatement plan(QueryStatement queryStatement) throws Exception {
queryParser.parse(queryStatement);
log.info("queryStatement:{}", queryStatement);
queryPlanner.plan(queryStatement);
return queryStatement;
}
private SemanticQueryResp query(QueryStatement queryStatement) throws Exception {
SemanticQueryResp semanticQueryResp = null;
log.info("[QueryStatement:{}]", queryStatement);
try {
//1 parse
queryParser.parse(queryStatement);

View File

@@ -188,10 +188,8 @@ public class QueryReqConverter {
}
String type = database.getType();
DbAdaptor engineAdaptor = DbAdaptorFactory.getEngineAdaptor(type.toLowerCase());
log.info("type:{},engineAdaptor:{}", type, engineAdaptor);
if (Objects.nonNull(engineAdaptor)) {
String functionNameCorrector = engineAdaptor.functionNameCorrector(databaseReq.getSql());
log.info("sql:{} ,after corrector", databaseReq.getSql(), functionNameCorrector);
databaseReq.setSql(functionNameCorrector);
}
}

View File

@@ -71,7 +71,6 @@ public class StatUtils {
QueryStat queryStatInfo = get();
queryStatInfo.setElapsedMs(System.currentTimeMillis() - queryStatInfo.getStartTime());
queryStatInfo.setQueryState(state.getStatus());
log.info("queryStatInfo: {}", queryStatInfo);
CompletableFuture.runAsync(() -> {
statRepository.createRecord(queryStatInfo);
}).exceptionally(exception -> {
@@ -186,16 +185,7 @@ public class StatUtils {
: "Admin";
}
public Boolean updateQueryOptMode(String mode) {
STATS.get().setQueryOptMode(mode);
return true;
}
public List<ItemUseResp> getStatInfo(ItemUseReq itemUseCommend) {
return statRepository.getStatInfo(itemUseCommend);
}
public List<QueryStat> getQueryStatInfoWithoutCache(ItemUseReq itemUseCommend) {
return statRepository.getQueryStatInfoWithoutCache(itemUseCommend);
}
}