From 8900fde4a32b96b52488c3bfdd490d7e463b9765 Mon Sep 17 00:00:00 2001 From: jerryjzhang Date: Wed, 15 Jan 2025 20:14:35 +0800 Subject: [PATCH] [improvement][headless]Remove unnecessary model name checks. --- .../java/com/tencent/supersonic/common/pojo/QueryColumn.java | 1 + .../headless/server/service/impl/ModelServiceImpl.java | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/common/src/main/java/com/tencent/supersonic/common/pojo/QueryColumn.java b/common/src/main/java/com/tencent/supersonic/common/pojo/QueryColumn.java index 13a46d08c..274056e90 100644 --- a/common/src/main/java/com/tencent/supersonic/common/pojo/QueryColumn.java +++ b/common/src/main/java/com/tencent/supersonic/common/pojo/QueryColumn.java @@ -22,6 +22,7 @@ public class QueryColumn { public QueryColumn(String nameEn, String type) { this.type = type; this.nameEn = nameEn; + this.name = nameEn; } public QueryColumn(String name, String type, String nameEn) { diff --git a/headless/server/src/main/java/com/tencent/supersonic/headless/server/service/impl/ModelServiceImpl.java b/headless/server/src/main/java/com/tencent/supersonic/headless/server/service/impl/ModelServiceImpl.java index ff8414e3b..0a5a66b4c 100644 --- a/headless/server/src/main/java/com/tencent/supersonic/headless/server/service/impl/ModelServiceImpl.java +++ b/headless/server/src/main/java/com/tencent/supersonic/headless/server/service/impl/ModelServiceImpl.java @@ -125,7 +125,7 @@ public class ModelServiceImpl implements ModelService { @Override @Transactional public ModelResp createModel(ModelReq modelReq, User user) throws Exception { - checkParams(modelReq); + // checkParams(modelReq); ModelDO modelDO = ModelConverter.convert(modelReq, user); modelRepository.createModel(modelDO); batchCreateDimension(modelDO, user); @@ -150,7 +150,7 @@ public class ModelServiceImpl implements ModelService { @Override @Transactional public ModelResp updateModel(ModelReq modelReq, User user) throws Exception { - checkParams(modelReq); + // checkParams(modelReq); checkRelations(modelReq); ModelDO modelDO = modelRepository.getModelById(modelReq.getId()); ModelConverter.convert(modelDO, modelReq, user);