[improvement][chat] Optimize the MemoryReviewTask task by adding individual exception handling (#1788)

This commit is contained in:
lexluo09
2024-10-11 23:09:13 +08:00
committed by GitHub
parent 0a86a63937
commit 72d01bb419
4 changed files with 13 additions and 9 deletions

View File

@@ -49,11 +49,14 @@ public class MemoryReviewTask {
@Scheduled(fixedDelay = 60 * 1000)
public void review() {
try {
memoryService.getMemoriesForLlmReview().stream().forEach(this::processMemory);
} catch (Exception e) {
log.error("Exception occurred during memory review task", e);
}
memoryService.getMemoriesForLlmReview().stream().forEach(memory -> {
try {
processMemory(memory);
} catch (Exception e) {
log.error("Exception occurred while processing memory with id {}: {}",
memory.getId(), e.getMessage(), e);
}
});
}
private void processMemory(ChatMemoryDO m) {

View File

@@ -105,8 +105,7 @@ public class AgentServiceImpl extends ServiceImpl<AgentDOMapper, AgentDO> implem
}
private synchronized void doExecuteAgentExamples(Agent agent) {
if (!agent.containsDatasetTool()
|| !agent.enableMemoryReview()
if (!agent.containsDatasetTool() || !agent.enableMemoryReview()
|| !ModelConfigHelper.testConnection(
ModelConfigHelper.getChatModelConfig(agent, ChatModelType.TEXT_TO_SQL))
|| CollectionUtils.isEmpty(agent.getExamples())) {