From 5fcec320ba93bf913316b5c05846150a8f8ed72b Mon Sep 17 00:00:00 2001
From: jerryjzhang <zhangjun2915@163.com>
Date: Wed, 9 Oct 2024 18:12:44 +0800
Subject: [PATCH] [improvement][chat]Do not create duplication memory for
 exactly the same question.

---
 .../chat/server/service/impl/MemoryServiceImpl.java       | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/chat/server/src/main/java/com/tencent/supersonic/chat/server/service/impl/MemoryServiceImpl.java b/chat/server/src/main/java/com/tencent/supersonic/chat/server/service/impl/MemoryServiceImpl.java
index d3fa92a8c..f65caa63f 100644
--- a/chat/server/src/main/java/com/tencent/supersonic/chat/server/service/impl/MemoryServiceImpl.java
+++ b/chat/server/src/main/java/com/tencent/supersonic/chat/server/service/impl/MemoryServiceImpl.java
@@ -36,7 +36,13 @@ public class MemoryServiceImpl implements MemoryService {
 
     @Override
     public void createMemory(ChatMemoryDO memory) {
-        chatMemoryRepository.createMemory(memory);
+        // do not save duplicate memory for exactly the same question
+        List<ChatMemoryDO> memories = getMemories(ChatMemoryFilter.builder()
+                .agentId(memory.getAgentId())
+                .question(memory.getQuestion()).build());
+        if (memories.size() == 0) {
+            chatMemoryRepository.createMemory(memory);
+        }
     }
 
     @Override