diff --git a/headless/server/src/main/java/com/tencent/supersonic/headless/server/utils/ModelConverter.java b/headless/server/src/main/java/com/tencent/supersonic/headless/server/utils/ModelConverter.java index 3ccb49069..a5b091234 100644 --- a/headless/server/src/main/java/com/tencent/supersonic/headless/server/utils/ModelConverter.java +++ b/headless/server/src/main/java/com/tencent/supersonic/headless/server/utils/ModelConverter.java @@ -109,8 +109,7 @@ public class ModelConverter { dimensionReq.setModelId(modelDO.getId()); dimensionReq.setExpr(dim.getExpr()); dimensionReq.setType(dim.getType().name()); - dimensionReq - .setDescription(Objects.isNull(dim.getDescription()) ? "" : dim.getDescription()); + dimensionReq.setDescription(Objects.isNull(dim.getDescription()) ? dimensionReq.getDescription() : dim.getDescription()); dimensionReq.setTypeParams(dim.getTypeParams()); return dimensionReq; } diff --git a/webapp/packages/supersonic-fe/src/pages/SemanticModel/Datasource/components/ModelFieldForm.tsx b/webapp/packages/supersonic-fe/src/pages/SemanticModel/Datasource/components/ModelFieldForm.tsx index 3a35a3bea..b8b5d4120 100644 --- a/webapp/packages/supersonic-fe/src/pages/SemanticModel/Datasource/components/ModelFieldForm.tsx +++ b/webapp/packages/supersonic-fe/src/pages/SemanticModel/Datasource/components/ModelFieldForm.tsx @@ -51,6 +51,7 @@ const getCreateFieldName = (type: EnumDataSourceType) => { EnumDataSourceType.CATEGORICAL, EnumDataSourceType.TIME, EnumDataSourceType.PARTITION_TIME, + EnumDataSourceType.FOREIGN, ].includes(type as EnumDataSourceType) ? 'isCreateDimension' : 'isCreateMetric'; @@ -101,7 +102,7 @@ const ModelFieldForm: React.FC = ({ value={selectTypeValue} allowClear onChange={(value) => { - let defaultParams = {}; + let defaultParams:any = {}; if (value === EnumDataSourceType.MEASURES) { defaultParams = { agg: AGG_OPTIONS[0].value, @@ -127,12 +128,13 @@ const ModelFieldForm: React.FC = ({ }; } else { defaultParams = { + type: value, agg: undefined, dateFormat: undefined, timeGranularity: undefined, }; } - const isCreateName = getCreateFieldName(value); + const isCreateName = getCreateFieldName(defaultParams.type); const editState = !isUndefined(record[isCreateName]) ? !!record[isCreateName] : true;