From 35892f234492e5d0ec14021e4dbffcf2b1dc2982 Mon Sep 17 00:00:00 2001 From: JackLiang Date: Tue, 16 Jul 2024 15:39:03 +0800 Subject: [PATCH] =?UTF-8?q?fix=20existSegment=20bug=20which=20embedding=20?= =?UTF-8?q?search=20not=20has=20min-score,so=20that=E2=80=A6=20(#1410)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../common/service/impl/EmbeddingServiceImpl.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/common/src/main/java/com/tencent/supersonic/common/service/impl/EmbeddingServiceImpl.java b/common/src/main/java/com/tencent/supersonic/common/service/impl/EmbeddingServiceImpl.java index b0e89b9b4..df71dc11e 100644 --- a/common/src/main/java/com/tencent/supersonic/common/service/impl/EmbeddingServiceImpl.java +++ b/common/src/main/java/com/tencent/supersonic/common/service/impl/EmbeddingServiceImpl.java @@ -79,15 +79,12 @@ public class EmbeddingServiceImpl implements EmbeddingService { Map filterCondition = new HashMap<>(); filterCondition.put(TextSegmentConvert.QUERY_ID, queryId); Filter filter = createCombinedFilter(filterCondition); - EmbeddingSearchRequest request = EmbeddingSearchRequest.builder() - .queryEmbedding(embedding).filter(filter).maxResults(1).build(); + .queryEmbedding(embedding).filter(filter).minScore(1.0d).maxResults(1).build(); EmbeddingSearchResult result = embeddingStore.search(request); List> relevant = result.matches(); - boolean exists = CollectionUtils.isNotEmpty(relevant); - cache.put(queryId, exists); return exists; } @@ -126,10 +123,8 @@ public class EmbeddingServiceImpl implements EmbeddingService { Filter filter = createCombinedFilter(filterCondition); EmbeddingSearchRequest request = EmbeddingSearchRequest.builder() .queryEmbedding(embeddedText).filter(filter).maxResults(num).build(); - EmbeddingSearchResult result = embeddingStore.search(request); List> relevant = result.matches(); - RetrieveQueryResult retrieveQueryResult = new RetrieveQueryResult(); retrieveQueryResult.setQuery(queryText); List retrievals = new ArrayList<>(); @@ -154,7 +149,6 @@ public class EmbeddingServiceImpl implements EmbeddingService { retrieveQueryResult.setRetrieval(retrievals); results.add(retrieveQueryResult); } - return results; }