[improvement][project]Opt some code structures.

This commit is contained in:
jerryjzhang
2024-10-27 10:38:30 +08:00
parent 3a905d7fb1
commit 1e3daffade
9 changed files with 35 additions and 48 deletions

View File

@@ -66,9 +66,7 @@ public class S2ChatLayerService implements ChatLayerService {
public MapResp map(QueryNLReq queryNLReq) {
MapResp mapResp = new MapResp(queryNLReq.getQueryText());
ChatQueryContext queryCtx = buildChatQueryContext(queryNLReq);
ComponentFactory.getSchemaMappers().forEach(mapper -> {
mapper.map(queryCtx);
});
ComponentFactory.getSchemaMappers().forEach(mapper -> mapper.map(queryCtx));
mapResp.setMapInfo(queryCtx.getMapInfo());
return mapResp;
}
@@ -264,22 +262,16 @@ public class S2ChatLayerService implements ChatLayerService {
/**
* * get time dimension SchemaElementMatch
*
* @param dataSetId
* @param dataSetName
* @return
*/
private SchemaElementMatch getTimeDimension(Long dataSetId, String dataSetName) {
SchemaElement element = SchemaElement.builder().dataSetId(dataSetId)
.dataSetName(dataSetName).type(SchemaElementType.DIMENSION)
.bizName(TimeDimensionEnum.DAY.getName()).build();
SchemaElementMatch timeDimensionMatch = SchemaElementMatch.builder().element(element)
return SchemaElementMatch.builder().element(element)
.detectWord(TimeDimensionEnum.DAY.getChName())
.word(TimeDimensionEnum.DAY.getChName()).similarity(1L)
.frequency(BaseWordBuilder.DEFAULT_FREQUENCY).build();
return timeDimensionMatch;
}
private Function<SchemaElement, SchemaElementMatch> mergeFunction() {

View File

@@ -119,9 +119,7 @@ public class ChatWorkflowEngine {
}
private void performProcessing(ChatQueryContext queryCtx, ParseResp parseResult) {
resultProcessors.forEach(processor -> {
processor.process(parseResult, queryCtx);
});
resultProcessors.forEach(processor -> processor.process(parseResult, queryCtx));
}
private void performTranslating(ChatQueryContext chatQueryContext, ParseResp parseResult) {
@@ -160,7 +158,7 @@ public class ChatWorkflowEngine {
}
});
if (!errorMsg.isEmpty()) {
parseResult.setErrorMsg(errorMsg.stream().collect(Collectors.joining("\n")));
parseResult.setErrorMsg(String.join("\n", errorMsg));
}
}
}