actions/stale
1
0
Fork 0
mirror of https://github.com/actions/stale.git synced 2025-12-10 03:57:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improves error handling when rate limiting is disabled on GHES. (#1300)

Browse Source 
* rateLimitResult log

* code update for rate limit

* Refactor getRateLimit method to remove mock responses and improve error handling

* retry logic removed

* Simplify warning message for rate limiting not enabled

* Remove redundant comments in rate limiting error handling

* updated the block to use catch (error: unknown) instead of any and added simple type narrowing for status and message.
This commit is contained in:
Chiranjib Swain
2025-11-05 20:31:31 +05:30
committed by GitHub
parent 39bea7de61
commit fad0de84e5
2 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
dist/index.js vendored
View File

@@ -761,6 +761,7 @@ class IssuesProcessor {
}); });
} }
getRateLimit() { getRateLimit() {
var _a;
return __awaiter(this, void 0, void 0, function* () { return __awaiter(this, void 0, void 0, function* () {
const logger = new logger_1.Logger(); const logger = new logger_1.Logger();
try { try {
@@ -768,7 +769,13 @@ class IssuesProcessor {
return new rate_limit_1.RateLimit(rateLimitResult.data.rate); return new rate_limit_1.RateLimit(rateLimitResult.data.rate);
} }
catch (error) { catch (error) {
logger.error(`Error when getting rateLimit: ${error.message}`); const status = error === null || error === void 0 ? void 0 : error.status;
const message = (_a = error === null || error === void 0 ? void 0 : error.message) !== null && _a !== void 0 ? _a : String(error);
if (status === 404 && message.includes('Rate limiting is not enabled')) {
logger.warning('Rate limiting is not enabled on this instance. Proceeding without rate limit checks.');
return undefined;
}
logger.error(`Error when getting rateLimit: ${message}`);
} }
}); });
} }

15
src/classes/issues-processor.ts
View File

@@ -660,11 +660,22 @@ export class IssuesProcessor {
async getRateLimit(): Promise<IRateLimit | undefined> { async getRateLimit(): Promise<IRateLimit | undefined> {
const logger: Logger = new Logger(); const logger: Logger = new Logger();
try { try {
const rateLimitResult = await this.client.rest.rateLimit.get(); const rateLimitResult = await this.client.rest.rateLimit.get();
return new RateLimit(rateLimitResult.data.rate); return new RateLimit(rateLimitResult.data.rate);
} catch (error) { } catch (error: unknown) {
logger.error(`Error when getting rateLimit: ${error.message}`); const status = (error as {status?: number})?.status;
const message = (error as {message?: string})?.message ?? String(error);
if (status === 404 && message.includes('Rate limiting is not enabled')) {
logger.warning(
'Rate limiting is not enabled on this instance. Proceeding without rate limit checks.'
);
return undefined;
}
logger.error(`Error when getting rateLimit: ${message}`);
} }
} }