feat: remove the days-before-stale option

BREAKING CHANGE:
The option days-before-stale was removed

src/classes/issue.spec.ts

@@ -21,7 +21,6 @@ describe('Issue', (): void => {
       daysBeforeIssueStale: 0,
       daysBeforePrClose: 0,
       daysBeforePrStale: 0,
-      daysBeforeStale: 0,
       debugOnly: false,
       deleteBranch: false,
       exemptIssueLabels: '',

src/classes/issues-processor.ts

@@ -207,8 +207,8 @@ export class IssuesProcessor {
       ? this.options.stalePrMessage.length === 0
       : this.options.staleIssueMessage.length === 0;
     const daysBeforeStale: number = issue.isPullRequest
-      ? this._getDaysBeforePrStale()
-      : this._getDaysBeforeIssueStale();
+      ? this.options.daysBeforePrStale
+      : this.options.daysBeforeIssueStale;
 
     if (issue.state === 'closed') {
       issueLogger.info(`Skipping this $$type because it is closed`);
@@ -461,7 +461,7 @@ export class IssuesProcessor {
         if (shouldMarkAsStale) {
           issueLogger.info(
             `This $$type should be marked as stale based on the option ${issueLogger.createOptionLink(
-              this._getDaysBeforeStaleUsedOptionName(issue)
+              IssuesProcessor._getDaysBeforeStaleUsedOptionName(issue)
             )} (${LoggerService.cyan(daysBeforeStale)})`
           );
           await this._markStale(issue, staleMessage, staleLabel, skipMessage);
@@ -470,7 +470,7 @@ export class IssuesProcessor {
         } else {
           issueLogger.info(
             `This $$type should not be marked as stale based on the option ${issueLogger.createOptionLink(
-              this._getDaysBeforeStaleUsedOptionName(issue)
+              IssuesProcessor._getDaysBeforeStaleUsedOptionName(issue)
             )} (${LoggerService.cyan(daysBeforeStale)})`
           );
         }
@@ -957,18 +957,6 @@ export class IssuesProcessor {
     }
   }
 
-  private _getDaysBeforeIssueStale(): number {
-    return isNaN(this.options.daysBeforeIssueStale)
-      ? this.options.daysBeforeStale
-      : this.options.daysBeforeIssueStale;
-  }
-
-  private _getDaysBeforePrStale(): number {
-    return isNaN(this.options.daysBeforePrStale)
-      ? this.options.daysBeforeStale
-      : this.options.daysBeforePrStale;
-  }
-
   private _getOnlyLabels(issue: Issue): string {
     if (issue.isPullRequest) {
       return this.options.onlyPrLabels;
@@ -1117,36 +1105,17 @@ export class IssuesProcessor {
     }
   }
 
-  private _consumeIssueOperation(issue: Readonly<Issue>): void {
-    this.operations.consumeOperation();
-    issue.operations.consumeOperation();
-  }
-
-  private _getDaysBeforeStaleUsedOptionName(
+  private static _getDaysBeforeStaleUsedOptionName(
     issue: Readonly<Issue>
-  ):
-    | Option.DaysBeforeStale
-    | Option.DaysBeforeIssueStale
-    | Option.DaysBeforePrStale {
+  ): Option.DaysBeforeIssueStale | Option.DaysBeforePrStale {
     return issue.isPullRequest
-      ? this._getDaysBeforePrStaleUsedOptionName()
-      : this._getDaysBeforeIssueStaleUsedOptionName();
-  }
-
-  private _getDaysBeforeIssueStaleUsedOptionName():
-    | Option.DaysBeforeStale
-    | Option.DaysBeforeIssueStale {
-    return isNaN(this.options.daysBeforeIssueStale)
-      ? Option.DaysBeforeStale
+      ? Option.DaysBeforePrStale
       : Option.DaysBeforeIssueStale;
   }
 
-  private _getDaysBeforePrStaleUsedOptionName():
-    | Option.DaysBeforeStale
-    | Option.DaysBeforePrStale {
-    return isNaN(this.options.daysBeforePrStale)
-      ? Option.DaysBeforeStale
-      : Option.DaysBeforePrStale;
+  private _consumeIssueOperation(issue: Readonly<Issue>): void {
+    this.operations.consumeOperation();
+    issue.operations.consumeOperation();
   }
 
   private _getRemoveStaleWhenUpdatedUsedOptionName(

src/enums/option.ts

@@ -4,7 +4,6 @@ export enum Option {
   StalePrMessage = 'stale-pr-message',
   CloseIssueMessage = 'close-issue-message',
   ClosePrMessage = 'close-pr-message',
-  DaysBeforeStale = 'days-before-stale',
   DaysBeforeIssueStale = 'days-before-issue-stale',
   DaysBeforePrStale = 'days-before-pr-stale',
   DaysBeforeIssueClose = 'days-before-issue-close',

src/interfaces/issues-processor-options.ts

@@ -6,9 +6,8 @@ export interface IIssuesProcessorOptions {
   stalePrMessage: string;
   closeIssueMessage: string;
   closePrMessage: string;
-  daysBeforeStale: number;
-  daysBeforeIssueStale: number; // Could be NaN
-  daysBeforePrStale: number; // Could be NaN
+  daysBeforeIssueStale: number;
+  daysBeforePrStale: number;
   daysBeforeIssueClose: number;
   daysBeforePrClose: number;
   staleIssueLabel: string;

src/main.ts

@@ -28,11 +28,12 @@ function _getAndValidateArgs(): IIssuesProcessorOptions {
     stalePrMessage: core.getInput('stale-pr-message'),
     closeIssueMessage: core.getInput('close-issue-message'),
     closePrMessage: core.getInput('close-pr-message'),
-    daysBeforeStale: parseInt(
-      core.getInput('days-before-stale', {required: true})
+    daysBeforeIssueStale: parseInt(
+      core.getInput('days-before-issue-stale', {required: true})
+    ),
+    daysBeforePrStale: parseInt(
+      core.getInput('days-before-pr-stale', {required: true})
     ),
-    daysBeforeIssueStale: parseInt(core.getInput('days-before-issue-stale')),
-    daysBeforePrStale: parseInt(core.getInput('days-before-pr-stale')),
     daysBeforeIssueClose: parseInt(
       core.getInput('days-before-issue-close', {required: true})
     ),
@@ -87,7 +88,8 @@ function _getAndValidateArgs(): IIssuesProcessorOptions {
   };
 
   for (const numberInput of [
-    'days-before-stale',
+    'days-before-issue-stale',
+    'days-before-pr-stale',
     'days-before-issue-close',
     'days-before-pr-close',
     'operations-per-run'