actions/stale
1
0
Fork 0
mirror of https://github.com/actions/stale.git synced 2025-12-11 12:37:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for logging error types instead of strings in the main try/catch (#66)

Browse Source 
* Bump actions core for more lenient command inputs
* Fix issue with issues that are old and unlabeled
This commit is contained in:
PJ Quirk
2020-05-12 15:23:00 -04:00
committed by GitHub
parent e611bf905b
commit 71d46bfe23
4 changed files with 1137 additions and 1041 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/IssueProcessor.ts
View File

@@ -67,7 +67,7 @@ export class IssueProcessor {
issueNumber: number,
sinceDate: string
) => Promise<Comment[]>,
getLabelCreationDate?: (issue: Issue, label: string) => Promise<string>
getLabelCreationDate?: (issue: Issue, label: string) => Promise<string | undefined>
) {
this.options = options;
this.operationsLeft = options.operationsPerRun;
@@ -190,25 +190,27 @@ export class IssueProcessor {
return; // nothing to do because we aren't closing stale issues
}
const markedStaleOn: string = await this.getLabelCreationDate(
const markedStaleOn: string | undefined = await this.getLabelCreationDate(
issue,
staleLabel
);
const issueHasComments: boolean = await this.isIssueStillStale(
issue,
markedStaleOn
markedStaleOn || issue.updated_at
);
const issueHasUpdate: boolean = IssueProcessor.updatedSince(
issue.updated_at,
this.options.daysBeforeClose
);
core.debug(`Issue #${issue.number} marked stale on: ${markedStaleOn}`);
if (markedStaleOn) {
core.debug(`Issue #${issue.number} marked stale on: ${markedStaleOn}`);
}
else {
core.debug(`Issue #${issue.number} is not marked stale, but last update of ${issue.updated_at} is older than ${this.options.daysBeforeStale} days`);
}
core.debug(`Issue #${issue.number} has been updated: ${issueHasUpdate}`);
core.debug(
`Issue #${issue.number} has been commented on: ${issueHasComments}`
);
core.debug(`Issue #${issue.number} has been commented on: ${issueHasComments}`);
if (!issueHasComments && !issueHasUpdate) {
core.debug(
@@ -219,7 +221,7 @@ export class IssueProcessor {
if (this.options.removeStaleWhenUpdated) {
await this.removeLabel(issue, staleLabel);
}
core.debug(`Ignoring stale ${issueType} because it was updated recenlty`);
core.debug(`Ignoring stale ${issueType} because it was updated recently`);
}
}
@@ -355,7 +357,7 @@ export class IssueProcessor {
private async getLabelCreationDate(
issue: Issue,
label: string
): Promise<string> {
): Promise<string | undefined> {
core.debug(`Checking for label ${label} on issue #${issue.number}`);
this.operationsLeft -= 1;
@@ -374,7 +376,12 @@ export class IssueProcessor {
event => event.event === 'labeled' && event.label.name === label
);
return staleLabeledEvent!.created_at;
if (!staleLabeledEvent) {
// Must be old rather than labeled
return undefined;
}
return staleLabeledEvent.created_at;
}
private static isLabeled(issue: Issue, label: string): boolean {