Create 2.329.0 runner release.

.devcontainer/devcontainer.json

@@ -4,7 +4,7 @@
   "features": {
     "ghcr.io/devcontainers/features/docker-in-docker:1": {},
     "ghcr.io/devcontainers/features/dotnet": {
-      "version": "8.0.415"
+      "version": "8.0.413"
     },
     "ghcr.io/devcontainers/features/node:1": {
       "version": "20"

.github/ISSUE_TEMPLATE/config.yml

@@ -1,8 +1,8 @@
 blank_issues_enabled: false
 contact_links:
   - name: 🛑 Request a feature in the runner application
-    url: https://github.com/orgs/community/discussions/categories/actions
-    about: If you have feature requests for GitHub Actions, please use the Actions section on the Github Product Feedback page.
+    url: https://github.com/orgs/community/discussions/categories/actions-and-packages
+    about: If you have feature requests for GitHub Actions, please use the Actions and Packages section on the Github Product Feedback page.
   - name: ✅ Support for GitHub Actions
     url: https://github.community/c/code-to-cloud/52
     about: If you have questions about GitHub Actions or need support writing workflows, please ask in the GitHub Community Support forum.

.github/workflows/close-features-bot.yml

@@ -9,7 +9,7 @@ jobs:
     steps:
       - uses: actions/stale@v10
         with:
-          close-issue-message: "Thank you for your interest in the runner application and taking the time to provide your valuable feedback. We kindly ask you to redirect this feedback to the [GitHub Community Support Forum](https://github.com/orgs/community/discussions/categories/actions) which our team actively monitors and would be a better place to start a discussion for new feature requests in GitHub Actions. For more information on this policy please [read our contribution guidelines](https://github.com/actions/runner#contribute). 😃"
+          close-issue-message: "Thank you for your interest in the runner application and taking the time to provide your valuable feedback. We kindly ask you to redirect this feedback to the [GitHub Community Support Forum](https://github.com/orgs/community/discussions/categories/actions-and-packages) which our team actively monitors and would be a better place to start a discussion for new feature requests in GitHub Actions. For more information on this policy please [read our contribution guidelines](https://github.com/actions/runner#contribute). 😃"
           exempt-issue-labels: "keep"
           stale-issue-label: "actions-feature"
           only-labels: "actions-feature"

releaseVersion

@@ -1 +1 @@
-<Update to ./src/runnerversion when creating release>
+2.329.0

src/Misc/expressionFunc/hashFiles/package-lock.json

@@ -1815,11 +1815,10 @@
       }
     },
     "node_modules/eslint-plugin-github/node_modules/brace-expansion": {
-      "version": "2.0.2",
-      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.2.tgz",
-      "integrity": "sha512-Jt0vHyM+jmUBqojB7E1NIYadt0vI0Qxjxd2TErW94wDz+E2LAm5vKMXXwg6ZZBTHPuUlDgQHKXvjGBdfcF1ZDQ==",
+      "version": "2.0.1",
+      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
+      "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
       "dev": true,
-      "license": "MIT",
       "dependencies": {
         "balanced-match": "^1.0.0"
       }
@@ -5905,9 +5904,9 @@
           }
         },
         "brace-expansion": {
-          "version": "2.0.2",
-          "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.2.tgz",
-          "integrity": "sha512-Jt0vHyM+jmUBqojB7E1NIYadt0vI0Qxjxd2TErW94wDz+E2LAm5vKMXXwg6ZZBTHPuUlDgQHKXvjGBdfcF1ZDQ==",
+          "version": "2.0.1",
+          "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
+          "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
           "dev": true,
           "requires": {
             "balanced-match": "^1.0.0"

src/Runner.Common/ConfigurationStore.cs

@@ -1,10 +1,10 @@
-using System;
+using GitHub.Runner.Sdk;
+using System;
 using System.IO;
 using System.Linq;
 using System.Runtime.Serialization;
 using System.Text;
 using System.Threading;
-using GitHub.Runner.Sdk;
 
 namespace GitHub.Runner.Common
 {
@@ -64,20 +64,8 @@ namespace GitHub.Runner.Common
         {
             get
             {
-                // If the value has been explicitly set, return it.
-                if (_isHostedServer.HasValue)
-                {
-                    return _isHostedServer.Value;
-                }
-
-                // Otherwise, try to infer it from the GitHubUrl.
-                if (!string.IsNullOrEmpty(GitHubUrl))
-                {
-                    return UrlUtil.IsHostedServer(new UriBuilder(GitHubUrl));
-                }
-
-                // Default to true since Hosted runners likely don't have this property set.
-                return true;
+                // Old runners do not have this property. Hosted runners likely don't have this property either.
+                return _isHostedServer ?? true;
             }
 
             set

src/Runner.Common/Constants.cs

@@ -170,8 +170,6 @@ namespace GitHub.Runner.Common
                 public static readonly string AddCheckRunIdToJobContext = "actions_add_check_run_id_to_job_context";
                 public static readonly string DisplayHelpfulActionsDownloadErrors = "actions_display_helpful_actions_download_errors";
                 public static readonly string ContainerActionRunnerTemp = "actions_container_action_runner_temp";
-                public static readonly string SnapshotPreflightHostedRunnerCheck = "actions_snapshot_preflight_hosted_runner_check";
-                public static readonly string SnapshotPreflightImageGenPoolCheck = "actions_snapshot_preflight_image_gen_pool_check";
             }
             
             // Node version migration related constants

src/Runner.Worker/JobExtension.cs

@@ -400,10 +400,6 @@ namespace GitHub.Runner.Worker
                     if (snapshotRequest != null)
                     {
                         var snapshotOperationProvider = HostContext.GetService<ISnapshotOperationProvider>();
-                        // Check that that runner is capable of taking a snapshot
-                        snapshotOperationProvider.RunSnapshotPreflightChecks(context);
-
-                        // Add postjob step to write snapshot file
                         jobContext.RegisterPostJobStep(new JobExtensionRunner(
                             runAsync: (executionContext, _) => snapshotOperationProvider.CreateSnapshotRequestAsync(executionContext, snapshotRequest),
                             condition: snapshotRequest.Condition,

src/Runner.Worker/SnapshotOperationProvider.cs

@@ -1,19 +1,15 @@
 #nullable enable
-using System;
 using System.IO;
 using System.Threading.Tasks;
 using GitHub.DistributedTask.Pipelines;
-using GitHub.DistributedTask.WebApi;
 using GitHub.Runner.Common;
 using GitHub.Runner.Sdk;
-using GitHub.Runner.Worker.Handlers;
 namespace GitHub.Runner.Worker;
 
 [ServiceLocator(Default = typeof(SnapshotOperationProvider))]
 public interface ISnapshotOperationProvider : IRunnerService
 {
     Task CreateSnapshotRequestAsync(IExecutionContext executionContext, Snapshot snapshotRequest);
-    void RunSnapshotPreflightChecks(IExecutionContext jobContext);
 }
 
 public class SnapshotOperationProvider : RunnerService, ISnapshotOperationProvider
@@ -28,32 +24,9 @@ public class SnapshotOperationProvider : RunnerService, ISnapshotOperationProvid
         }
 
         IOUtil.SaveObject(snapshotRequest, snapshotRequestFilePath);
-        executionContext.Output($"Image Name: {snapshotRequest.ImageName} Version: {snapshotRequest.Version}");
         executionContext.Output($"Request written to: {snapshotRequestFilePath}");
         executionContext.Output("This request will be processed after the job completes. You will not receive any feedback on the snapshot process within the workflow logs of this job.");
         executionContext.Output("If the snapshot process is successful, you should see a new image with the requested name in the list of available custom images when creating a new GitHub-hosted Runner.");
         return Task.CompletedTask;
     }
-
-    public void RunSnapshotPreflightChecks(IExecutionContext context)
-    {
-        var shouldCheckRunnerEnvironment = context.Global.Variables.GetBoolean(Constants.Runner.Features.SnapshotPreflightHostedRunnerCheck) ?? false;
-        if (shouldCheckRunnerEnvironment &&
-             context.Global.Variables.TryGetValue(WellKnownDistributedTaskVariables.RunnerEnvironment, out var runnerEnvironment) &&
-             !string.IsNullOrEmpty(runnerEnvironment))
-        {
-            context.Debug($"Snapshot: RUNNER_ENVIRONMENT={runnerEnvironment}");
-            if (!string.Equals(runnerEnvironment, "github-hosted", StringComparison.OrdinalIgnoreCase))
-            {
-                throw new ArgumentException("Snapshot workflows must be run on a GitHub Hosted Runner");
-            }
-        }
-        var imageGenEnabled = StringUtil.ConvertToBoolean(Environment.GetEnvironmentVariable("GITHUB_ACTIONS_IMAGE_GEN_ENABLED"));
-        context.Debug($"Snapshot: GITHUB_ACTIONS_IMAGE_GEN_ENABLED={imageGenEnabled}");
-        var shouldCheckImageGenPool = context.Global.Variables.GetBoolean(Constants.Runner.Features.SnapshotPreflightImageGenPoolCheck) ?? false;
-        if (shouldCheckImageGenPool && !imageGenEnabled)
-        {
-            throw new ArgumentException("Snapshot workflows must be run a hosted runner with Image Generation enabled");
-        }
-    }
 }

src/Test/L0/Worker/JobExtensionL0.cs

@@ -567,193 +567,5 @@ namespace GitHub.Runner.Common.Tests.Worker
                 }
             }
         }
-
-        [Fact]
-        [Trait("Level", "L0")]
-        [Trait("Category", "Worker")]
-        public async Task SnapshotPreflightChecks_HostedRunnerCheck_Enabled_GitHubHosted_Success()
-        {
-            using (TestHostContext hc = CreateTestContext())
-            {
-                _jobEc.Global.Variables.Set(WellKnownDistributedTaskVariables.RunnerEnvironment, "github-hosted");
-
-                hc.SetSingleton<ISnapshotOperationProvider>(new SnapshotOperationProvider());
-                _jobEc.Global.Variables.Set(Constants.Runner.Features.SnapshotPreflightHostedRunnerCheck, "true");
-
-                var jobExtension = new JobExtension();
-                jobExtension.Initialize(hc);
-
-
-                var snapshot = new Pipelines.Snapshot("TestImageNameForPreflightCheck");
-                var imageNameValueStringToken = new StringToken(null, null, null, snapshot.ImageName);
-                _message.Snapshot = imageNameValueStringToken;
-
-                _actionManager.Setup(x => x.PrepareActionsAsync(It.IsAny<IExecutionContext>(), It.IsAny<IEnumerable<Pipelines.JobStep>>(), It.IsAny<Guid>()))
-                    .Returns(Task.FromResult(new PrepareResult(new List<JobExtensionRunner>(), new Dictionary<Guid, IActionRunner>())));
-
-                await jobExtension.InitializeJob(_jobEc, _message);
-
-                var postJobSteps = _jobEc.PostJobSteps;
-                Assert.Equal(1, postJobSteps.Count);
-            }
-
-            Environment.SetEnvironmentVariable("RUNNER_ENVIRONMENT", null);
-        }
-
-        [Fact]
-        [Trait("Level", "L0")]
-        [Trait("Category", "Worker")]
-        public async Task SnapshotPreflightChecks_HostedRunnerCheck_Enabled_SelfHosted_ThrowsException()
-        {
-            using (TestHostContext hc = CreateTestContext())
-            {
-                _jobEc.Global.Variables.Set(WellKnownDistributedTaskVariables.RunnerEnvironment, "self-hosted");
-                hc.SetSingleton<ISnapshotOperationProvider>(new SnapshotOperationProvider());
-
-                var jobExtension = new JobExtension();
-                jobExtension.Initialize(hc);
-
-                _jobEc.Global.Variables.Set(Constants.Runner.Features.SnapshotPreflightHostedRunnerCheck, "true");
-
-                var snapshot = new Pipelines.Snapshot("TestImageNameForPreflightCheck");
-                var imageNameValueStringToken = new StringToken(null, null, null, snapshot.ImageName);
-                _message.Snapshot = imageNameValueStringToken;
-
-                _actionManager.Setup(x => x.PrepareActionsAsync(It.IsAny<IExecutionContext>(), It.IsAny<IEnumerable<Pipelines.JobStep>>(), It.IsAny<Guid>()))
-                    .Returns(Task.FromResult(new PrepareResult(new List<JobExtensionRunner>(), new Dictionary<Guid, IActionRunner>())));
-
-                var exception = await Assert.ThrowsAsync<ArgumentException>(() => jobExtension.InitializeJob(_jobEc, _message));
-                Assert.Contains("Snapshot workflows must be run on a GitHub Hosted Runner", exception.Message);
-            }
-
-            Environment.SetEnvironmentVariable("RUNNER_ENVIRONMENT", null);
-        }
-
-        [Fact]
-        [Trait("Level", "L0")]
-        [Trait("Category", "Worker")]
-        public async Task SnapshotPreflightChecks_ImageGenPoolCheck_Enabled_ImageGenEnabled_Success()
-        {
-            Environment.SetEnvironmentVariable("GITHUB_ACTIONS_IMAGE_GEN_ENABLED", "true");
-
-            using (TestHostContext hc = CreateTestContext())
-            {
-                hc.SetSingleton<ISnapshotOperationProvider>(new SnapshotOperationProvider());
-
-                var jobExtension = new JobExtension();
-                jobExtension.Initialize(hc);
-
-                _jobEc.Global.Variables.Set(Constants.Runner.Features.SnapshotPreflightImageGenPoolCheck, "true");
-
-                var snapshot = new Pipelines.Snapshot("TestImageNameForPreflightCheck");
-                var imageNameValueStringToken = new StringToken(null, null, null, snapshot.ImageName);
-                _message.Snapshot = imageNameValueStringToken;
-
-                _actionManager.Setup(x => x.PrepareActionsAsync(It.IsAny<IExecutionContext>(), It.IsAny<IEnumerable<Pipelines.JobStep>>(), It.IsAny<Guid>()))
-                    .Returns(Task.FromResult(new PrepareResult(new List<JobExtensionRunner>(), new Dictionary<Guid, IActionRunner>())));
-
-                await jobExtension.InitializeJob(_jobEc, _message);
-
-                var postJobSteps = _jobEc.PostJobSteps;
-                Assert.Equal(1, postJobSteps.Count);
-            }
-
-            Environment.SetEnvironmentVariable("GITHUB_ACTIONS_IMAGE_GEN_ENABLED", null);
-        }
-
-        [Fact]
-        [Trait("Level", "L0")]
-        [Trait("Category", "Worker")]
-        public async Task SnapshotPreflightChecks_ImageGenPoolCheck_Enabled_ImageGen_False_ThrowsException()
-        {
-            Environment.SetEnvironmentVariable("GITHUB_ACTIONS_IMAGE_GEN_ENABLED", "false");
-
-            using (TestHostContext hc = CreateTestContext())
-            {
-                hc.SetSingleton<ISnapshotOperationProvider>(new SnapshotOperationProvider());
-                _jobEc.SetRunnerContext("environment", "github-hosted");
-
-                var jobExtension = new JobExtension();
-                jobExtension.Initialize(hc);
-
-                _jobEc.Global.Variables.Set(Constants.Runner.Features.SnapshotPreflightImageGenPoolCheck, "true");
-
-                var snapshot = new Pipelines.Snapshot("TestImageNameForPreflightCheck");
-                var imageNameValueStringToken = new StringToken(null, null, null, snapshot.ImageName);
-                _message.Snapshot = imageNameValueStringToken;
-
-                _actionManager.Setup(x => x.PrepareActionsAsync(It.IsAny<IExecutionContext>(), It.IsAny<IEnumerable<Pipelines.JobStep>>(), It.IsAny<Guid>()))
-                    .Returns(Task.FromResult(new PrepareResult(new List<JobExtensionRunner>(), new Dictionary<Guid, IActionRunner>())));
-
-                var exception = await Assert.ThrowsAsync<ArgumentException>(() => jobExtension.InitializeJob(_jobEc, _message));
-                Assert.Contains("Snapshot workflows must be run a hosted runner with Image Generation enabled", exception.Message);
-            }
-
-            Environment.SetEnvironmentVariable("GITHUB_ACTIONS_IMAGE_GEN_ENABLED", null);
-        }
-
-        [Fact]
-        [Trait("Level", "L0")]
-        [Trait("Category", "Worker")]
-        public async Task SnapshotPreflightChecks_ImageGenPoolCheck_Enabled_ImageGen_Missing_ThrowsException()
-        {
-            using (TestHostContext hc = CreateTestContext())
-            {
-                hc.SetSingleton<ISnapshotOperationProvider>(new SnapshotOperationProvider());
-
-                var jobExtension = new JobExtension();
-                jobExtension.Initialize(hc);
-
-                _jobEc.Global.Variables.Set(Constants.Runner.Features.SnapshotPreflightImageGenPoolCheck, "true");
-
-                var snapshot = new Pipelines.Snapshot("TestImageNameForPreflightCheck");
-                var imageNameValueStringToken = new StringToken(null, null, null, snapshot.ImageName);
-                _message.Snapshot = imageNameValueStringToken;
-
-                _actionManager.Setup(x => x.PrepareActionsAsync(It.IsAny<IExecutionContext>(), It.IsAny<IEnumerable<Pipelines.JobStep>>(), It.IsAny<Guid>()))
-                    .Returns(Task.FromResult(new PrepareResult(new List<JobExtensionRunner>(), new Dictionary<Guid, IActionRunner>())));
-
-                var exception = await Assert.ThrowsAsync<ArgumentException>(() => jobExtension.InitializeJob(_jobEc, _message));
-                Assert.Contains("Snapshot workflows must be run a hosted runner with Image Generation enabled", exception.Message);
-            }
-
-            Environment.SetEnvironmentVariable("GITHUB_ACTIONS_IMAGE_GEN_ENABLED", null);
-        }
-
-        [Fact]
-        [Trait("Level", "L0")]
-        [Trait("Category", "Worker")]
-        public async Task SnapshotPreflightChecks_BothChecks_Enabled_AllConditionsMet_Success()
-        {
-            Environment.SetEnvironmentVariable("GITHUB_ACTIONS_IMAGE_GEN_ENABLED", "true");
-
-            using (TestHostContext hc = CreateTestContext())
-            {
-                hc.SetSingleton<ISnapshotOperationProvider>(new SnapshotOperationProvider());
-
-                var jobExtension = new JobExtension();
-                jobExtension.Initialize(hc);
-
-                // Enable both preflight checks
-                _jobEc.Global.Variables.Set(WellKnownDistributedTaskVariables.RunnerEnvironment, "github-hosted");
-                _jobEc.Global.Variables.Set(Constants.Runner.Features.SnapshotPreflightHostedRunnerCheck, "true");
-                _jobEc.Global.Variables.Set(Constants.Runner.Features.SnapshotPreflightImageGenPoolCheck, "true");
-
-                var snapshot = new Pipelines.Snapshot("TestImageNameForPreflightCheck");
-                var imageNameValueStringToken = new StringToken(null, null, null, snapshot.ImageName);
-                _message.Snapshot = imageNameValueStringToken;
-
-                _actionManager.Setup(x => x.PrepareActionsAsync(It.IsAny<IExecutionContext>(), It.IsAny<IEnumerable<Pipelines.JobStep>>(), It.IsAny<Guid>()))
-                    .Returns(Task.FromResult(new PrepareResult(new List<JobExtensionRunner>(), new Dictionary<Guid, IActionRunner>())));
-
-                await jobExtension.InitializeJob(_jobEc, _message);
-
-                var postJobSteps = _jobEc.PostJobSteps;
-                Assert.Equal(1, postJobSteps.Count);
-            }
-
-            Environment.SetEnvironmentVariable("RUNNER_ENVIRONMENT", null);
-            Environment.SetEnvironmentVariable("GITHUB_ACTIONS_IMAGE_GEN_ENABLED", null);
-        }
     }
 }

src/Test/L0/Worker/SnapshotOperationProviderL0.cs

@@ -38,7 +38,6 @@ public class SnapshotOperationProviderL0
             Assert.NotNull(actualSnapshot);
             Assert.Equal(expectedSnapshot.ImageName, actualSnapshot!.ImageName);
             _ec.Verify(ec => ec.Write(null, $"Request written to: {_snapshotRequestFilePath}"), Times.Once);
-            _ec.Verify(ec => ec.Write(null, $"Image Name: {expectedSnapshot.ImageName} Version: {expectedSnapshot.Version}"), Times.Once);
             _ec.Verify(ec => ec.Write(null, "This request will be processed after the job completes. You will not receive any feedback on the snapshot process within the workflow logs of this job."), Times.Once);
             _ec.Verify(ec => ec.Write(null, "If the snapshot process is successful, you should see a new image with the requested name in the list of available custom images when creating a new GitHub-hosted Runner."), Times.Once);
             _ec.VerifyNoOtherCalls();

src/dev.sh

@@ -17,7 +17,7 @@ LAYOUT_DIR="$SCRIPT_DIR/../_layout"
 DOWNLOAD_DIR="$SCRIPT_DIR/../_downloads/netcore2x"
 PACKAGE_DIR="$SCRIPT_DIR/../_package"
 DOTNETSDK_ROOT="$SCRIPT_DIR/../_dotnetsdk"
-DOTNETSDK_VERSION="8.0.415"
+DOTNETSDK_VERSION="8.0.413"
 DOTNETSDK_INSTALLDIR="$DOTNETSDK_ROOT/$DOTNETSDK_VERSION"
 RUNNER_VERSION=$(cat runnerversion)
 

src/global.json

@@ -1,5 +1,5 @@
 {
   "sdk": {
-    "version": "8.0.415"
+    "version": "8.0.413"
   }
 }