Compare commits

..

3 Commits

Author SHA1 Message Date
JoannaaKL
302aad97c5 Add solution suggested by @fhammerl 2023-05-17 15:10:16 +00:00
JoannaaKL
17975e3491 Use PascalCase for methods 2023-05-17 09:21:06 +00:00
JoannaaKL
e1e7fde7bc Remove duplicated issues 2023-05-17 08:59:04 +00:00
4 changed files with 1 additions and 19 deletions

View File

@@ -818,7 +818,6 @@ namespace GitHub.Runner.Common
return mergedRecords; return mergedRecords;
} }
private async Task UploadFile(UploadFileInfo file) private async Task UploadFile(UploadFileInfo file)
{ {
bool uploadSucceed = false; bool uploadSucceed = false;

View File

@@ -1,4 +1,4 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.ComponentModel; using System.ComponentModel;
using System.Linq; using System.Linq;
@@ -163,7 +163,6 @@ namespace GitHub.DistributedTask.ObjectTemplating
message = $"{prefix} {message}"; message = $"{prefix} {message}";
} }
Errors.Add(message);
TraceWriter.Error(message); TraceWriter.Error(message);
} }

View File

@@ -15,10 +15,6 @@
</ItemGroup> </ItemGroup>
<ItemGroup> <ItemGroup>
<PackageReference Include="coverlet.collector" Version="3.2.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" /> <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
<PackageReference Include="xunit" Version="2.4.1" /> <PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" /> <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />

View File

@@ -194,10 +194,6 @@ function layout ()
function runtest () function runtest ()
{ {
if [[ ! -d "$LAYOUT_DIR" ]]; then
echo "$LAYOUT_DIR doesn't exist. Generating it now ..."
layout
fi
heading "Testing ..." heading "Testing ..."
if [[ ("$CURRENT_PLATFORM" == "linux") || ("$CURRENT_PLATFORM" == "darwin") ]]; then if [[ ("$CURRENT_PLATFORM" == "linux") || ("$CURRENT_PLATFORM" == "darwin") ]]; then
@@ -207,13 +203,6 @@ function runtest ()
dotnet msbuild -t:test -p:PackageRuntime="${RUNTIME_ID}" -p:BUILDCONFIG="${BUILD_CONFIG}" -p:RunnerVersion="${RUNNER_VERSION}" ./dir.proj || failed "failed tests" dotnet msbuild -t:test -p:PackageRuntime="${RUNTIME_ID}" -p:BUILDCONFIG="${BUILD_CONFIG}" -p:RunnerVersion="${RUNNER_VERSION}" ./dir.proj || failed "failed tests"
} }
function coverage ()
{
heading "Coverage ..."
cd Test && dotnet test --collect:"XPlat Code Coverage;Format=json"
# reportgenerator -reports:"/workspaces/runner/src/Test/TestResults/ecf2bd75-83e9-489a-9339-d61293abf98b/coverage.cobertura.xml" -targetdir:"coveragereport" -reporttypes:Html
}
function format() function format()
{ {
heading "Formatting..." heading "Formatting..."
@@ -380,7 +369,6 @@ case $DEV_CMD in
"p") package;; "p") package;;
"format") format;; "format") format;;
"f") format;; "f") format;;
"c") coverage;;
*) echo "Invalid cmd. Use build(b), test(t), layout(l), package(p), or format(f)";; *) echo "Invalid cmd. Use build(b), test(t), layout(l), package(p), or format(f)";;
esac esac