eric sciple
fb6d1adb43
.NET 8 OS compatibility test ( #3422 )
...
* Revert "Warn for soon to be deprecated OS versions (#3413 )"
This reverts commit ae04147f96 .
* Add .NET 8 OS compatibility test
* feedback
2024-08-07 16:53:00 -05:00
Tingluo Huang
43d67e46db
Revert "Bump runner to dotnet 8" ( #3412 )
...
* Revert "Upgrade dotnet sdk to v8.0.303 (#3388 )"
This reverts commit dbcaa7cf3d .
* Revert "Bump System.Security.Cryptography.Pkcs from 5.0.0 to 8.0.0 in /src (#3347 )"
This reverts commit 3dab1f1fb0 .
* Revert "Upgrade dotnet sdk to v8.0.302 (#3346 )"
This reverts commit 8f1c723ba0 .
* Revert "Bump runner to dotnet 8 (#3345 )"
This reverts commit 1e74a8137b .
2024-08-05 10:03:18 -05:00
eric sciple
ae04147f96
Warn for soon to be deprecated OS versions ( #3413 )
2024-08-02 14:37:46 -05:00
eric sciple
054fc2e046
Backoff to avoid excessive retries to Run Service in a duration ( #3354 )
2024-06-24 16:33:22 -05:00
Tingluo Huang
1e74a8137b
Bump runner to dotnet 8 ( #3345 )
...
* Bump runner to dotnet 8
* .
2024-06-18 11:28:53 -04:00
dependabot[bot]
ce4d7be00f
Bump xunit from 2.4.1 to 2.7.1 in /src ( #3242 )
...
* Bump xunit from 2.4.1 to 2.7.1 in /src
Bumps [xunit](https://github.com/xunit/xunit ) from 2.4.1 to 2.7.1.
- [Commits](https://github.com/xunit/xunit/compare/2.4.1...2.7.1 )
---
updated-dependencies:
- dependency-name: xunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* Appease xunit warnings after upgrading to v2.7.1
* Appease the whitespace linter
* Appease the whitespace linter
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick Ellis <319655+pje@users.noreply.github.com >
2024-05-21 10:47:43 -04:00
eric sciple
dd9fcfc5b2
Replace invalid file name chars in diag log name ( #3249 )
2024-04-20 11:37:25 -05:00
Tingluo Huang
5107c5efb2
Cleanup enabled feature flags. ( #3248 )
2024-04-19 15:31:44 -04:00
Tingluo Huang
2e0eb2c11f
Cleanup enabled feature flags. ( #3246 )
...
* Cleanup FF 'DistributedTask.UseWhich2'.
* more ff.
2024-04-16 16:52:10 -04:00
eeSquared
f467e9e125
Add new SessionConflict return code ( #3215 )
...
* Add new SessionConflict return code
* formatting
* Change return type of CreateSessionAsync to new enum
* Update entry scripts to handle new exit code
* Move enum
2024-03-27 18:49:58 +00:00
Luke Tomlinson
8ebf298bcd
Always Delete Actions Service Session ( #3214 )
...
* Delete Actions Service session always
* update tes
2024-03-21 16:30:34 -04:00
David Omid
927b26a364
Process snapshot tokens ( #3135 )
...
* Added Snapshot TemplateToken to AgentJobRequestMessage
* WIP for processing the snapshot token
* Changed snapshot post job step condition to Success, added comments
* Refactored snapshot post-job step
* Added evaluation of snapshot token to retrieve image name
* Added snapshot to workflow schema
* Fixed linter error
* Migrated snapshot logic to new SnapshotOperationProvider
* Fixed linter error
* Fixed linter errors
* Fixed linter error
* Fixed linter errors
* Updated L0 tests
* Fixed linter errors
* Added new JobExtensionL0 tests for snapshot post-job step
* Added JobExtensionL0 test case for snapshot mappings
* Added SnapshotOperationProviderL0 tests
* Enabled nullable types for SnapshotOperationProvider and its tests
* Added more assertions to SnapshotOperationProviderL0 tests
* Fixed linter errors
* Made sure TestHostContexts are disposed of properlyh in SnapshotOperationProviderL0 tests
* Resolved PR comments
* Fixed formatting
* Removed redundant reference
* Addressed PR comments
2024-02-14 21:34:52 -05:00
Josh Soref
fa874cf314
Improve error report for invalid action.yml ( #3106 )
2024-02-06 13:40:53 +00:00
Luke Tomlinson
894c50073a
Implement Broker Redirects for Session and Messages ( #3103 )
2024-01-30 20:57:49 +00:00
Tingluo Huang
f1f18f67e1
Remove runner trimmed packages. ( #3074 )
2024-01-10 12:32:17 -05:00
Luke Tomlinson
a9bae6f37a
Handle SelfUpdate Flow when Package is provided in Message ( #2926 )
2023-11-13 16:44:07 -05:00
Luke Tomlinson
3136ce3a71
Send disableUpdate as query parameter ( #2970 )
2023-11-13 10:19:42 -05:00
Luke Tomlinson
c851794f04
send os and arch as query params ( #2913 )
2023-10-09 15:14:00 -04:00
Tingluo Huang
22d4310b69
trim whitespace. ( #2915 )
2023-10-09 12:34:40 -04:00
Tingluo Huang
f57ecd8e3c
Allow use action archive cache to speed up workflow jobs. ( #2857 )
...
* Refactor ActionManager.cs
* changes.
* cleanup
2023-09-28 23:43:55 +00:00
Tingluo Huang
8f1c070506
Use Directory.EnumerateFiles instead of Directory.GetFiles in WhichUtil. ( #2882 )
...
* Use Directory.EnumerateFiles instead of Directory.GetFiles in WhichUtil.
* .
* .
2023-09-26 20:49:15 +00:00
Tingluo Huang
67d70803a9
Fix ArgumentOutOfRangeException in PowerShellPostAmpersandEscape. ( #2875 )
2023-09-21 16:34:28 +00:00
Tingluo Huang
5b2bc388ca
GetAgents from all runner groups durning config. ( #2865 )
...
* GetAgents from all runner groups
* Update ConfigurationManagerL0.cs
2023-09-20 11:05:44 -04:00
Cory Miller
7b703d667d
Mark action download failures as infra failures ( #2827 )
...
* Mark action download failures as infra failures
* Fix Windows variable name
* Update src/Runner.Worker/ActionManager.cs
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com >
---------
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com >
2023-09-06 13:32:57 +00:00
Luke Tomlinson
0e9e9f1e8d
Support replacing runners in v2 flow ( #2791 )
...
* Support replacing runners in v2 flow
* Use correct endpoint for listing runners
* fix test
* really fix test
* lint
2023-08-31 09:55:05 -04:00
dependabot[bot]
e22452c2d6
Bump System.Buffers from 4.3.0 to 4.5.1 in /src ( #2749 )
...
Bumps [System.Buffers](https://github.com/dotnet/corefx ) from 4.3.0 to 4.5.1.
- [Release notes](https://github.com/dotnet/corefx/releases )
- [Commits](https://github.com/dotnet/corefx/commits )
---
updated-dependencies:
- dependency-name: System.Buffers
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-24 09:54:25 -04:00
Cory Miller
8b9a81c952
Filter NODE_OPTIONS from env for file output ( #2775 )
...
Copies logic that used to be in ::set::env before its deprecation
2023-08-16 17:56:01 -04:00
Cory Miller
460d9ae5a8
Revert "Fixed a bug where a misplaced = character could bypass heredoc-style processing. ( #2627 )" ( #2774 )
...
This reverts commit 4ffd081aea .
2023-08-16 15:03:55 -04:00
Tatyana Kostromskaya
8206cf4e73
Add node20 to runner ( #2732 )
...
* .
* fix hashes
* fix linux-arm
* linux-arm64
* osx-x64
* win-x64
* clean up node12 deprecation warning
* Add node20
* Remove node12 from the BuildInVersions list
* fix externals hash
2023-08-11 11:11:28 +02:00
Tatyana Kostromskaya
9eb4b96713
Remove node12 ( #2717 )
...
* .
* fix hashes
* clean up node12 deprecation warning
* Remove node12 from the BuildInVersions list
2023-08-10 15:16:30 +02:00
Tingluo Huang
8fa970a1e6
Change RunnerId/AgentId from int32 to uint64 ( #2661 )
...
* RunnerId int -> ulong
2023-08-04 16:22:52 -04:00
Tingluo Huang
b91ad56f92
Check connectivity for endpoints requested by service. ( #2691 )
2023-07-17 08:36:20 -04:00
Cameron Booth
d4bbbb8419
Only add StepResult for Tasks, not the Job itself ( #2620 )
2023-06-30 04:17:46 -07:00
John Wesley Walker III
4ffd081aea
Fixed a bug where a misplaced = character could bypass heredoc-style processing. ( #2627 )
...
* Fixed a bug where a misplaced `=` character could bypass heredoc-style processing.
Fixes https://github.com/github/c2c-actions/issues/6910
GitHub Docs for context: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings
* Consolidate near-identical FileCommand-related unit test classes. (#2672 )
2023-06-29 12:52:05 +02:00
Ferenc Hammerl
5f1c6f4708
Add 'http://' to http(s)_proxy if there is no protocol ( #2663 )
...
* Add 'http://' to http(s)_proxy if there is no protocol
Before this commit, these URIs used to be ignored (nullproxy).
The new behaviour aligns with go style http(s)_proxy
* Update src/Runner.Sdk/RunnerWebProxy.cs
Co-authored-by: Nikola Jokic <jokicnikola07@gmail.com >
* Assert that original protocol is preserved
* Use startsWith for testing protocol
* Only modify proxy if useful
---------
Co-authored-by: Nikola Jokic <jokicnikola07@gmail.com >
2023-06-20 15:53:44 +02:00
Nikola Jokic
8415f13bab
removed throw and else on container action handler ( #1873 )
...
* removed throw and else on container action handler
* repaired merge resolution error
2023-06-16 21:53:52 -04:00
Dylan Geraci
1096b975e4
Send environment url to Run Service ( #2650 )
...
* add EnvironmentUrl to CompleteJobRequest
* Send environment url to Run Service
* Fix whitespace
* Fix test
* Fix more whitespace
* Apply suggestions from code review
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
* Apply suggestion from code review
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
---------
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
2023-06-16 04:13:08 +00:00
JoannaaKL
efffbaeabc
Add utf8 with bom ( #2641 )
...
* Change default file encoding
2023-06-02 21:47:59 +02:00
Gabriel
eeb0cf6f1e
Add --no-default-labels config option to self-hosted runners ( #2443 )
...
* Add --no-default-labels option
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com >
* Add tests
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com >
* .
---------
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com >
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
2023-05-11 12:37:56 -04:00
John Wesley Walker III
f8a28c3c4e
[1742] Ensure multiple composite annoations are correctly written. ( #2311 )
...
* [1742] Ensure multiple composite annoations are correctly written.
This implementation uses a collector pattern to allow embedded ExecutionContexts to stash Issue objects for later processing by a non-embedded ancestor ExecutionContext.
Also:
- Provide explicit constructor implementations for ExecutionContext
- Leverage explicit constructors to solidify immutability of several ExecutionContext class members.
- Fixed erroneous call to ExecutionContext.Complete in CompositeActionHandler.cs
- Use a consistent timestamp for FinishTime in ExecutionContext::Complete
* Ensure collected issues are processed only by a non-embedded ExecutionContext.
This was already implicit. Now, just making it explicit.
* Provide a clear mechanism that allows callers to opt-in/opt-out of ExecutionContext::AddIssue's logging behavior.
* Addressed deserialization inconsistencies in TimelineRecord.cs
* Added TimelineRecord unit tests.
* Refined unit tests related to TimelineRecord::Variables case-insensitivity
* Add a unit test that verifies ExecutionContextLogOptions::LogMessageOverride has the desired effect.
* Responded to PR feedback.
* Don't allow embedded ExecutionContexts to add Issues to a TimelineRecord
2023-05-10 16:24:02 +02:00
John Hernley
22d1938ac4
Resolve Actions Directly From Launch for Run Service Jobs ( #2529 )
...
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
2023-05-03 16:04:21 -04:00
John Wesley Walker III
229b9b8ecc
Remove Temporary Serialization Shim ( #2549 )
2023-05-03 15:29:19 +02:00
Yashwanth Anantharaju
896152d78e
send annotations to run-service ( #2574 )
...
* send annotations to run-service
* skip message deletion
* actually don't skip deletion
* enum as numbers
* fix enum
* linting
* remove unncessary file
* feedback
2023-05-01 08:33:03 -04:00
John Wesley Walker III
a41397ae93
Rename AcquireJobRequest::StreamID to AcquireJobRequest::JobMessageID ( #2547 )
...
* Rename AcquireJobRequest::StreamID to AcquireJobRequest::JobMessageID to match corresponding server-side update.
* appeased the linter
* Added unit tests to prove AcquireJobRequest serialization/deserialization is as-expected.
* Distinguish unit test variations.
* Incorporated PR Feedback.
2023-04-26 18:31:41 +02:00
Eli Entelis
2ecd7d2fc6
which handles broken symlink & unit test added ( #2150 ) ( #2196 )
...
* which handles broken symlink & unit test added (#2150 )
* Update src/Runner.Sdk/Util/WhichUtil.cs
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com >
* fix pr comments
* trace log added, in case we find a symlink that is broken
* add check in case the target of the symlink is a relative path; added test that check symlink that targets a full path; added test that check symlink that targets a relative path;
* fix tests
* fix tests for linux
---------
Co-authored-by: Eli Entelis <eli.entelis@hexagon.com >
Co-authored-by: Eli Entelis <42981948+Eliminator1999@users.noreply.github.com >
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com >
2023-04-06 22:15:11 -04:00
Nikola Jokic
1ceb1a67f2
Guard against NullReference while creating HostContext ( #2343 )
...
* Guard against NullReference while creating HostContext
* Throw on IOUtil loading object if content is empty or object is null
* removed unused dependency
* Changed exceptions to ArgumentNullException and ArgumentException
* fixed my mistake on LoadObject
* fixed tests
* trigger workflows
* trigger workflows
* encode files using utf8
2023-03-30 15:39:09 +02:00
Luke Tomlinson
9f778b814d
Register Runners against V2 servers ( #2505 )
...
* Parse runners and send publicKey
* wip
* Fix conflicts
* Cleanup
* Cleanup
* fix test
* fix test
* Add trace for broker message listener
* Feedback
* refactor
* remove dead code
* Remove old comment
2023-03-28 15:45:00 -04:00
Tatyana Kostromskaya
bb7b1e8259
Update runner to handle Dotcom/runner-admin based registration flow ( #2487 )
2023-03-21 16:05:32 +01:00
Jongwoo Han
514ecec5a3
Replace deprecated command with environment file ( #2429 )
...
Signed-off-by: jongwooo <jongwooo.han@gmail.com >
2023-03-09 22:09:05 -05:00
Ferenc Hammerl
8ef48200b4
Bypass all proxies for all hosts if no_proxy='*' is set ( #2395 )
...
* Bypass top level domain even if no_proxy specified it with leading '.'
E.g. no_proxy='.github.com' will now bypass github.com.
* Bypass proxy on all hosts when no_proxy is * (wildcard)
* Undo '.' stripping
* Simplify unit tests
* Respect wildcard even if it's one of many no_proxy items
2023-03-06 11:01:45 +01:00