actions/runner
1
0
Fork 0
mirror of https://github.com/actions/runner.git synced 2025-12-16 23:20:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor Docker command options to use escaped options and add tests for quoting environment variables in scripts

Browse Source
This commit is contained in:
Salman Chishti - SalmanMKC
2025-09-22 23:28:07 +01:00
parent 2b472844d3
commit ece418e8c4
4 changed files with 183 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Runner.Worker/Handlers/StepHost.cs
View File

@@ -5,6 +5,7 @@ using System.Threading;
using System.Threading.Tasks;
using GitHub.Runner.Worker.Container;
using GitHub.Runner.Common;
using GitHub.Runner.Worker.Container;
using GitHub.Runner.Sdk;
using System.Linq;
using GitHub.Runner.Worker.Container.ContainerHooks;
@@ -220,7 +221,7 @@ namespace GitHub.Runner.Worker.Handlers
// [OPTIONS]
dockerCommandArgs.Add($"-i");
dockerCommandArgs.Add($"--workdir {workingDirectory}");
dockerCommandArgs.Add(DockerUtil.CreateEscapedOption("--workdir", workingDirectory));
foreach (var env in environment)
{
// e.g. -e MY_SECRET maps the value into the exec'ed process without exposing