Fix build warnings in Test project (#178)

The build warnings were of these type (mostly reported by xUnit's Code Analyzers):
- Fixed wrong parameter order in xUnit assertions (can lead to poor error reporting in test failures)
- Unused code was removed
- Correct assertions were used (e.g. Assert.True/.Contains/.EndsWith)
- Public non-test methods on test classes were made private
This commit is contained in:
Eilon Lipton
2019-11-06 05:52:51 -08:00
committed by Thomas Boop
parent bcac4557a0
commit ec9cb6c68d
10 changed files with 139 additions and 162 deletions

View File

@@ -150,7 +150,7 @@ namespace GitHub.Runner.Common.Tests.Worker
string actual = variables.Get("no such");
// Assert.
Assert.Equal(null, actual);
Assert.Null(actual);
}
}