From ec910bab3dabf909d417194715fdf929ded06987 Mon Sep 17 00:00:00 2001 From: eric sciple Date: Wed, 7 Apr 2021 11:18:05 -0500 Subject: [PATCH] . --- ...ctions.md => 1040-composite-supports-action-steps.md} | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) rename docs/adrs/{0000-composite-actions.md => 1040-composite-supports-action-steps.md} (69%) diff --git a/docs/adrs/0000-composite-actions.md b/docs/adrs/1040-composite-supports-action-steps.md similarity index 69% rename from docs/adrs/0000-composite-actions.md rename to docs/adrs/1040-composite-supports-action-steps.md index 04999cd96..c9f447989 100644 --- a/docs/adrs/0000-composite-actions.md +++ b/docs/adrs/1040-composite-supports-action-steps.md @@ -27,12 +27,15 @@ TODO: Move these details into a tracking issue instead - Update schema to support `uses` within a composite step - src/Runner.Worker/action_yaml.json - src/Sdk/DTPipelines/Pipelines/ObjectTemplating/PipelineTemplateConverter.cs - - Manage inputs/outputs between nested layers + - Mimic server validation, generate IDs, etc + - Handle inputs/outputs between nested layers - Update server to generate context names when empty - Fix issue with `hashFiles` within a composite action - https://github.com/actions/runner/issues/991 - - Support actions with pre-step and post-step - - Investigate whether CompositeActionHandler.cs especially wrt clearing the output scopes + - Support container-actions and actions with pre-step and post-step + - Investigate how to deal with pre-steps. Today, nested steps are created just-in-time. However, pre-steps are generally executed before regular steps. Container actions implicitly have a pre-step to pull or build the image + - Investigate whether we copy the continue-on-error setting to the pre/post steps + - Investigate CompositeActionHandler.cs especially wrt clearing the output scopes - Investigate whether we need additional validation to restrict contexts available to pre-step condition and post-step condition - Testing - Support all types of action manifests: Node.js, Dockerfile, `docker://`, composite, no manifest only Dockerfile