From d15ab3d8fa304afe28fcfd9853e40b3da8082490 Mon Sep 17 00:00:00 2001 From: Francesco Renzi Date: Tue, 17 Mar 2026 15:30:19 +0000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Tingluo Huang --- src/Runner.Worker/JobRunner.cs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Runner.Worker/JobRunner.cs b/src/Runner.Worker/JobRunner.cs index bfe64cb33..bb1c74d8b 100644 --- a/src/Runner.Worker/JobRunner.cs +++ b/src/Runner.Worker/JobRunner.cs @@ -194,7 +194,7 @@ namespace GitHub.Runner.Worker catch (Exception ex) { Trace.Error($"Failed to start DAP debugger: {ex.Message}"); - AddDebuggerConnectionTelemetry(jobContext, "Failed"); + AddDebuggerConnectionTelemetry(jobContext, $"Failed: {ex.Message}"); jobContext.Error("Failed to start debugger."); return await CompleteJobAsync(server, jobContext, message, TaskResult.Failed); } @@ -261,11 +261,10 @@ namespace GitHub.Runner.Worker catch (Exception ex) { Trace.Error($"DAP debugger failed to become ready: {ex.Message}"); - AddDebuggerConnectionTelemetry(jobContext, "Failed"); + AddDebuggerConnectionTelemetry(jobContext, $"Failed: {ex.Message}"); // If debugging was requested but the debugger is not available, fail the job - var errorMessage = "The debugger failed to start or no debugger client connected in time."; - jobContext.Error(errorMessage); + jobContext.Error("The debugger failed to start or no debugger client connected in time."); return await CompleteJobAsync(server, jobContext, message, TaskResult.Failed); } }