From d061d61093beb9914c95519fc2fec023a7376319 Mon Sep 17 00:00:00 2001 From: Luke Tomlinson Date: Mon, 8 Jan 2024 12:47:48 -0800 Subject: [PATCH] Remove USE_BROKER_FLOW usage --- src/Runner.Sdk/Util/VssUtil.cs | 5 ----- src/Sdk/Common/Common/VssHttpMessageHandler.cs | 2 +- src/Sdk/Common/Common/VssHttpRequestSettings.cs | 10 ---------- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/src/Runner.Sdk/Util/VssUtil.cs b/src/Runner.Sdk/Util/VssUtil.cs index bf74fa16c..941198b52 100644 --- a/src/Runner.Sdk/Util/VssUtil.cs +++ b/src/Runner.Sdk/Util/VssUtil.cs @@ -62,11 +62,6 @@ namespace GitHub.Runner.Sdk settings.SendTimeout = TimeSpan.FromSeconds(Math.Min(Math.Max(httpRequestTimeoutSeconds, 100), 1200)); } - if (StringUtil.ConvertToBoolean(Environment.GetEnvironmentVariable("USE_BROKER_FLOW"))) - { - settings.AllowAutoRedirectForBroker = true; - } - // Remove Invariant from the list of accepted languages. // // The constructor of VssHttpRequestSettings (base class of VssClientHttpRequestSettings) adds the current diff --git a/src/Sdk/Common/Common/VssHttpMessageHandler.cs b/src/Sdk/Common/Common/VssHttpMessageHandler.cs index 04a318d63..c98105054 100644 --- a/src/Sdk/Common/Common/VssHttpMessageHandler.cs +++ b/src/Sdk/Common/Common/VssHttpMessageHandler.cs @@ -215,7 +215,7 @@ namespace GitHub.Services.Common // SyncronizationContext (such as ASP.NET's) which keeps things from deadlocking... var tmpResponse = await m_messageInvoker.SendAsync(request, tokenSource.Token).ConfigureAwait(false); - if (Settings.AllowAutoRedirectForBroker && tmpResponse.StatusCode == HttpStatusCode.Redirect) + if (tmpResponse.StatusCode == HttpStatusCode.Redirect) { //Dispose of the previous response tmpResponse?.Dispose(); diff --git a/src/Sdk/Common/Common/VssHttpRequestSettings.cs b/src/Sdk/Common/Common/VssHttpRequestSettings.cs index 6d67f9274..7279d2809 100644 --- a/src/Sdk/Common/Common/VssHttpRequestSettings.cs +++ b/src/Sdk/Common/Common/VssHttpRequestSettings.cs @@ -110,16 +110,6 @@ namespace GitHub.Services.Common set; } - /// - /// Gets or sets a value indicating whether or not HttpClientHandler should follow redirect on outgoing broker requests - /// This is special since this also sends token in the request, where as default AllowAutoRedirect does not - /// - public Boolean AllowAutoRedirectForBroker - { - get; - set; - } - /// /// Gets or sets a value indicating whether or not compression should be used on outgoing requests. /// The default value is true.