From ccca13ac07a9c6faefee71add2577a02d1159f51 Mon Sep 17 00:00:00 2001 From: eric sciple Date: Mon, 28 Oct 2019 11:52:22 -0400 Subject: [PATCH] restrict hashFiles to basic globbing and globstar (#150) --- .../DTExpressions2/Expressions2/Sdk/Functions/HashFiles.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Sdk/DTExpressions2/Expressions2/Sdk/Functions/HashFiles.cs b/src/Sdk/DTExpressions2/Expressions2/Sdk/Functions/HashFiles.cs index f3a9e941a..4da0d6d83 100644 --- a/src/Sdk/DTExpressions2/Expressions2/Sdk/Functions/HashFiles.cs +++ b/src/Sdk/DTExpressions2/Expressions2/Sdk/Functions/HashFiles.cs @@ -83,11 +83,15 @@ namespace GitHub.DistributedTask.Expressions2.Sdk.Functions } } + // Only support basic globbing (* ? and []) and globstar (**) private static readonly Options s_minimatchOptions = new Options { Dot = true, NoBrace = true, - NoCase = Environment.OSVersion.Platform != PlatformID.Unix && Environment.OSVersion.Platform != PlatformID.MacOSX + NoCase = Environment.OSVersion.Platform != PlatformID.Unix && Environment.OSVersion.Platform != PlatformID.MacOSX, + NoComment = true, + NoExt = true, + NoNegate = true, }; } } \ No newline at end of file