actions/runner
1
0
Fork 0
mirror of https://github.com/actions/runner.git synced 2025-12-12 15:13:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Account for DataContractSerializer vagaries.

Browse Source
This commit is contained in:
John Wesley Walker III
2023-02-27 16:38:45 +00:00
parent b70f97f183
commit cb89be7aac
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Sdk/DTWebApi/WebApi/Issue.cs
View File

@@ -25,7 +25,8 @@ namespace GitHub.DistributedTask.WebApi
private Issue(Issue original) private Issue(Issue original)
{ {
m_data = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase); // DataContractSerializer bypasses all constructor logic and inline initialization!
this.EnsureInitialized();
if (original != null) if (original != null)
{ {
this.Type = original.Type; this.Type = original.Type;
@@ -86,6 +87,7 @@ namespace GitHub.DistributedTask.WebApi
private void OnDeserialized(StreamingContext context) private void OnDeserialized(StreamingContext context)
{ {
SerializationHelper.Copy(ref m_serializedData, ref m_data, StringComparer.OrdinalIgnoreCase, true); SerializationHelper.Copy(ref m_serializedData, ref m_data, StringComparer.OrdinalIgnoreCase, true);
this.EnsureInitialized();
} }
[OnSerializing] [OnSerializing]
@@ -104,5 +106,10 @@ namespace GitHub.DistributedTask.WebApi
private IDictionary<string, string> m_serializedData; private IDictionary<string, string> m_serializedData;
private IDictionary<string, string> m_data; private IDictionary<string, string> m_data;
private void EnsureInitialized()
{
m_data = m_data ?? new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
}
} }
} }