From c5ce52641cfe45c409b8540f4e4e524a98ef362d Mon Sep 17 00:00:00 2001 From: Vladimir Panteleev Date: Wed, 1 Sep 2021 20:01:23 +0000 Subject: [PATCH] Allow setting default severity to "notice" (#1213) --- src/Runner.Worker/IssueMatcher.cs | 1 + src/Test/L0/Worker/IssueMatcherL0.cs | 29 ++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/src/Runner.Worker/IssueMatcher.cs b/src/Runner.Worker/IssueMatcher.cs index 3b4374226..0a6eb0fc4 100644 --- a/src/Runner.Worker/IssueMatcher.cs +++ b/src/Runner.Worker/IssueMatcher.cs @@ -350,6 +350,7 @@ namespace GitHub.Runner.Worker case "": case "ERROR": case "WARNING": + case "NOTICE": break; default: throw new ArgumentException($"Matcher '{_owner}' contains unexpected default severity '{_severity}'"); diff --git a/src/Test/L0/Worker/IssueMatcherL0.cs b/src/Test/L0/Worker/IssueMatcherL0.cs index bc83bfc9f..aae92f3cc 100644 --- a/src/Test/L0/Worker/IssueMatcherL0.cs +++ b/src/Test/L0/Worker/IssueMatcherL0.cs @@ -392,6 +392,35 @@ namespace GitHub.Runner.Common.Tests.Worker Assert.Equal("not-working", match.Message); } + [Fact] + [Trait("Level", "L0")] + [Trait("Category", "Worker")] + public void Matcher_MultiplePatterns_DefaultSeverityNotice() + { + var config = JsonUtility.FromString(@" +{ + ""problemMatcher"": [ + { + ""owner"": ""myMatcher"", + ""severity"": ""notice"", + ""pattern"": [ + { + ""regexp"": ""^(.+)$"", + ""message"": 1 + } + ] + } + ] +} +"); + config.Validate(); + var matcher = new IssueMatcher(config.Matchers[0], TimeSpan.FromSeconds(1)); + + var match = matcher.Match("just-a-notice"); + Assert.Equal("notice", match.Severity); + Assert.Equal("just-a-notice", match.Message); + } + [Fact] [Trait("Level", "L0")] [Trait("Category", "Worker")]