actions/runner
1
0
Fork 0
mirror of https://github.com/actions/runner.git synced 2025-12-12 15:13:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove job summary feature flag (#1936)

Browse Source
This commit is contained in:
Rob Herley
2022-06-09 15:49:04 -04:00
committed by GitHub
parent a9ce6b92c4
commit b2e2aa68c8
2 changed files with 1 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Runner.Worker/FileCommandManager.cs
View File

@@ -275,12 +275,6 @@ namespace GitHub.Runner.Worker
public void ProcessCommand(IExecutionContext context, string filePath, ContainerInfo container) public void ProcessCommand(IExecutionContext context, string filePath, ContainerInfo container)
{ {
if (!context.Global.Variables.GetBoolean("DistributedTask.UploadStepSummary") ?? true)
{
Trace.Info("Step Summary is disabled; skipping attachment upload");
return;
}
if (String.IsNullOrEmpty(filePath) || !File.Exists(filePath)) if (String.IsNullOrEmpty(filePath) || !File.Exists(filePath))
{ {
Trace.Info($"Step Summary file ({filePath}) does not exist; skipping attachment upload"); Trace.Info($"Step Summary file ({filePath}) does not exist; skipping attachment upload");

20
src/Test/L0/Worker/CreateStepSummaryCommandL0.cs
View File

@@ -25,23 +25,6 @@ namespace GitHub.Runner.Common.Tests.Worker
private CreateStepSummaryCommand _createStepCommand; private CreateStepSummaryCommand _createStepCommand;
private ITraceWriter _trace; private ITraceWriter _trace;
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Worker")]
public void CreateStepSummaryCommand_FeatureDisabled()
{
using (var hostContext = Setup(featureFlagState: "false"))
{
var stepSummaryFile = Path.Combine(_rootDirectory, "feature-off");
_createStepCommand.ProcessCommand(_executionContext.Object, stepSummaryFile, null);
_jobExecutionContext.Complete();
_jobServerQueue.Verify(x => x.QueueFileUpload(It.IsAny<Guid>(), It.IsAny<Guid>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<bool>()), Times.Never());
Assert.Equal(0, _issues.Count);
}
}
[Fact] [Fact]
[Trait("Level", "L0")] [Trait("Level", "L0")]
[Trait("Category", "Worker")] [Trait("Category", "Worker")]
@@ -199,7 +182,7 @@ namespace GitHub.Runner.Common.Tests.Worker
File.WriteAllText(path, contentStr, encoding); File.WriteAllText(path, contentStr, encoding);
} }
private TestHostContext Setup([CallerMemberName] string name = "", string featureFlagState = "true") private TestHostContext Setup([CallerMemberName] string name = "")
{ {
var hostContext = new TestHostContext(this, name); var hostContext = new TestHostContext(this, name);
@@ -241,7 +224,6 @@ namespace GitHub.Runner.Common.Tests.Worker
_variables = new Variables(hostContext, new Dictionary<string, VariableValue> _variables = new Variables(hostContext, new Dictionary<string, VariableValue>
{ {
{ "MySecretName", new VariableValue("My secret value", true) }, { "MySecretName", new VariableValue("My secret value", true) },
{ "DistributedTask.UploadStepSummary", featureFlagState },
}); });
// Directory for test data // Directory for test data