actions/runner
1
0
Fork 0
mirror of https://github.com/actions/runner.git synced 2025-12-12 15:13:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Treat warnings as errors (#249)

Browse Source 
* Treat warnings as errors

* fix warnings
This commit is contained in:
Joseph Petersen
2019-12-21 15:51:41 +01:00
committed by Tingluo Huang
parent 300bc67950
commit ac1a076a3b
3 changed files with 53 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/Directory.Build.props
View File

@@ -46,4 +46,9 @@
<PropertyGroup Condition="'$(Configuration)' == 'Debug'"> <PropertyGroup Condition="'$(Configuration)' == 'Debug'">
<DefineConstants>$(DefineConstants);DEBUG</DefineConstants> <DefineConstants>$(DefineConstants);DEBUG</DefineConstants>
</PropertyGroup> </PropertyGroup>
<!-- Set Treat tarnings as errors -->
<PropertyGroup>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
</Project> </Project>

6
src/Test/L0/ProcessInvokerL0.cs
View File

@@ -260,7 +260,7 @@ namespace GitHub.Runner.Common.Tests
var proc = await processInvoker.ExecuteAsync("", "bash", "-c \"cat /proc/$$/oom_score_adj\"", null, false, null, false, null, false, false, var proc = await processInvoker.ExecuteAsync("", "bash", "-c \"cat /proc/$$/oom_score_adj\"", null, false, null, false, null, false, false,
highPriorityProcess: false, highPriorityProcess: false,
cancellationToken: tokenSource.Token); cancellationToken: tokenSource.Token);
Assert.Equal(oomScoreAdj, 500); Assert.Equal(500, oomScoreAdj);
} }
catch (OperationCanceledException) catch (OperationCanceledException)
{ {
@@ -298,7 +298,7 @@ namespace GitHub.Runner.Common.Tests
false, null, false, null, false, false, false, null, false, null, false, false,
highPriorityProcess: false, highPriorityProcess: false,
cancellationToken: tokenSource.Token); cancellationToken: tokenSource.Token);
Assert.Equal(oomScoreAdj, 1234); Assert.Equal(1234, oomScoreAdj);
} }
catch (OperationCanceledException) catch (OperationCanceledException)
{ {
@@ -336,7 +336,7 @@ namespace GitHub.Runner.Common.Tests
var proc = await processInvoker.ExecuteAsync("", "bash", "-c \"cat /proc/$$/oom_score_adj\"", null, false, null, false, null, false, false, var proc = await processInvoker.ExecuteAsync("", "bash", "-c \"cat /proc/$$/oom_score_adj\"", null, false, null, false, null, false, false,
highPriorityProcess: true, highPriorityProcess: true,
cancellationToken: tokenSource.Token); cancellationToken: tokenSource.Token);
Assert.Equal(oomScoreAdj, 123); Assert.Equal(123, oomScoreAdj);
} }
catch (OperationCanceledException) catch (OperationCanceledException)
{ {

70
src/Test/L0/Worker/ActionManagerL0.cs
View File

@@ -57,8 +57,8 @@ namespace GitHub.Runner.Common.Tests.Worker
var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions); var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions);
//Assert //Assert
Assert.Equal((steps[0].Data as ContainerSetupInfo).StepIds[0], actionId); Assert.Equal(actionId, (steps[0].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.Image, "ubuntu:16.04"); Assert.Equal("ubuntu:16.04", (steps[0].Data as ContainerSetupInfo).Container.Image);
} }
finally finally
{ {
@@ -204,9 +204,9 @@ namespace GitHub.Runner.Common.Tests.Worker
//Act //Act
var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions); var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions);
Assert.Equal((steps[0].Data as ContainerSetupInfo).StepIds[0], actionId); Assert.Equal(actionId, (steps[0].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory, actionDir); Assert.Equal(actionDir, (steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.Dockerfile, Path.Combine(actionDir, "Dockerfile")); Assert.Equal(Path.Combine(actionDir, "Dockerfile"), (steps[0].Data as ContainerSetupInfo).Container.Dockerfile);
} }
finally finally
{ {
@@ -245,9 +245,9 @@ namespace GitHub.Runner.Common.Tests.Worker
//Act //Act
var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions); var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions);
Assert.Equal((steps[0].Data as ContainerSetupInfo).StepIds[0], actionId); Assert.Equal(actionId, (steps[0].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory, actionDir); Assert.Equal(actionDir, (steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.Dockerfile, Path.Combine(actionDir, "images/cli", "Dockerfile")); Assert.Equal(Path.Combine(actionDir, "images/cli", "Dockerfile"), (steps[0].Data as ContainerSetupInfo).Container.Dockerfile);
} }
finally finally
{ {
@@ -284,9 +284,9 @@ namespace GitHub.Runner.Common.Tests.Worker
//Act //Act
var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions); var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions);
Assert.Equal((steps[0].Data as ContainerSetupInfo).StepIds[0], actionId); Assert.Equal(actionId, (steps[0].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory, actionDir); Assert.Equal(actionDir, (steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.Dockerfile, Path.Combine(actionDir, "Dockerfile")); Assert.Equal(Path.Combine(actionDir, "Dockerfile"), (steps[0].Data as ContainerSetupInfo).Container.Dockerfile);
} }
finally finally
{ {
@@ -324,9 +324,9 @@ namespace GitHub.Runner.Common.Tests.Worker
//Act //Act
var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions); var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions);
Assert.Equal((steps[0].Data as ContainerSetupInfo).StepIds[0], actionId); Assert.Equal(actionId, (steps[0].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory, actionDir); Assert.Equal(actionDir, (steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.Dockerfile, Path.Combine(actionDir, "images/Dockerfile")); Assert.Equal(Path.Combine(actionDir, "images/Dockerfile"), (steps[0].Data as ContainerSetupInfo).Container.Dockerfile);
} }
finally finally
{ {
@@ -364,8 +364,8 @@ namespace GitHub.Runner.Common.Tests.Worker
//Act //Act
var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions); var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions);
Assert.Equal((steps[0].Data as ContainerSetupInfo).StepIds[0], actionId); Assert.Equal(actionId, (steps[0].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.Image, "ubuntu:18.04"); Assert.Equal("ubuntu:18.04", (steps[0].Data as ContainerSetupInfo).Container.Image);
} }
finally finally
{ {
@@ -403,9 +403,9 @@ namespace GitHub.Runner.Common.Tests.Worker
//Act //Act
var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions); var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions);
Assert.Equal((steps[0].Data as ContainerSetupInfo).StepIds[0], actionId); Assert.Equal(actionId, (steps[0].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory, actionDir); Assert.Equal(actionDir, (steps[0].Data as ContainerSetupInfo).Container.WorkingDirectory);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.Dockerfile, Path.Combine(actionDir, "Dockerfile")); Assert.Equal(Path.Combine(actionDir, "Dockerfile"), (steps[0].Data as ContainerSetupInfo).Container.Dockerfile);
} }
finally finally
{ {
@@ -521,30 +521,30 @@ namespace GitHub.Runner.Common.Tests.Worker
var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions); var steps = await _actionManager.PrepareActionsAsync(_ec.Object, actions);
//Assert //Assert
Assert.Equal((steps[0].Data as ContainerSetupInfo).StepIds[0], actionId1); Assert.Equal(actionId1, (steps[0].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[0].Data as ContainerSetupInfo).Container.Image, "ubuntu:16.04"); Assert.Equal("ubuntu:16.04", (steps[0].Data as ContainerSetupInfo).Container.Image);
Assert.True((steps[1].Data as ContainerSetupInfo).StepIds.Contains(actionId2)); Assert.Contains(actionId2, (steps[1].Data as ContainerSetupInfo).StepIds);
Assert.True((steps[1].Data as ContainerSetupInfo).StepIds.Contains(actionId3)); Assert.Contains(actionId3, (steps[1].Data as ContainerSetupInfo).StepIds);
Assert.True((steps[1].Data as ContainerSetupInfo).StepIds.Contains(actionId4)); Assert.Contains(actionId4, (steps[1].Data as ContainerSetupInfo).StepIds);
Assert.Equal((steps[1].Data as ContainerSetupInfo).Container.Image, "ubuntu:18.04"); Assert.Equal("ubuntu:18.04", (steps[1].Data as ContainerSetupInfo).Container.Image);
var actionDir = Path.Combine(_hc.GetDirectory(WellKnownDirectory.Actions), "TingluoHuang", "runner_L0", "repositoryactionwithdockerfile"); var actionDir = Path.Combine(_hc.GetDirectory(WellKnownDirectory.Actions), "TingluoHuang", "runner_L0", "repositoryactionwithdockerfile");
Assert.Equal((steps[2].Data as ContainerSetupInfo).StepIds[0], actionId5); Assert.Equal(actionId5, (steps[2].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[2].Data as ContainerSetupInfo).Container.WorkingDirectory, actionDir); Assert.Equal(actionDir, (steps[2].Data as ContainerSetupInfo).Container.WorkingDirectory);
Assert.Equal((steps[2].Data as ContainerSetupInfo).Container.Dockerfile, Path.Combine(actionDir, "Dockerfile")); Assert.Equal(Path.Combine(actionDir, "Dockerfile"), (steps[2].Data as ContainerSetupInfo).Container.Dockerfile);
actionDir = Path.Combine(_hc.GetDirectory(WellKnownDirectory.Actions), "TingluoHuang", "runner_L0", "repositoryactionwithdockerfileinrelativepath"); actionDir = Path.Combine(_hc.GetDirectory(WellKnownDirectory.Actions), "TingluoHuang", "runner_L0", "repositoryactionwithdockerfileinrelativepath");
Assert.True((steps[3].Data as ContainerSetupInfo).StepIds.Contains(actionId6)); Assert.Contains(actionId6, (steps[3].Data as ContainerSetupInfo).StepIds);
Assert.True((steps[3].Data as ContainerSetupInfo).StepIds.Contains(actionId7)); Assert.Contains(actionId7, (steps[3].Data as ContainerSetupInfo).StepIds);
Assert.Equal((steps[3].Data as ContainerSetupInfo).Container.WorkingDirectory, actionDir); Assert.Equal(actionDir, (steps[3].Data as ContainerSetupInfo).Container.WorkingDirectory);
Assert.Equal((steps[3].Data as ContainerSetupInfo).Container.Dockerfile, Path.Combine(actionDir, "Dockerfile")); Assert.Equal(Path.Combine(actionDir, "Dockerfile"), (steps[3].Data as ContainerSetupInfo).Container.Dockerfile);
Assert.Equal((steps[4].Data as ContainerSetupInfo).StepIds[0], actionId8); Assert.Equal(actionId8, (steps[4].Data as ContainerSetupInfo).StepIds[0]);
Assert.Equal((steps[4].Data as ContainerSetupInfo).Container.WorkingDirectory, actionDir); Assert.Equal(actionDir, (steps[4].Data as ContainerSetupInfo).Container.WorkingDirectory);
Assert.Equal((steps[4].Data as ContainerSetupInfo).Container.Dockerfile, Path.Combine(actionDir, "images/cli", "Dockerfile")); Assert.Equal(Path.Combine(actionDir, "images/cli", "Dockerfile"), (steps[4].Data as ContainerSetupInfo).Container.Dockerfile);
} }
finally finally
{ {