Fix Null Ref Issues Composite Actions (#657)

This commit is contained in:
Ethan Chiu
2020-08-12 17:12:54 -04:00
committed by GitHub
parent 8c29e33e88
commit 9e7b56f698

View File

@@ -91,7 +91,7 @@ namespace GitHub.Runner.Worker.Handlers
ProcessCompositeActionOutputs(); ProcessCompositeActionOutputs();
ExecutionContext.Global.StepsContext.ClearScope(ExecutionContext.GetFullyQualifiedContextName()); ExecutionContext.Global.StepsContext.ClearScope(childScopeName);
} }
catch (Exception ex) catch (Exception ex)
{ {
@@ -137,13 +137,20 @@ namespace GitHub.Runner.Worker.Handlers
var outputsName = pair.Key; var outputsName = pair.Key;
var outputsAttributes = pair.Value as DictionaryContextData; var outputsAttributes = pair.Value as DictionaryContextData;
outputsAttributes.TryGetValue("value", out var val); outputsAttributes.TryGetValue("value", out var val);
var outputsValue = val as StringContextData;
if (val != null)
{
var outputsValue = val as StringContextData;
// Set output in the whole composite scope. // Set output in the whole composite scope.
if (!String.IsNullOrEmpty(outputsName) && !String.IsNullOrEmpty(outputsValue)) if (!String.IsNullOrEmpty(outputsValue))
{ {
ExecutionContext.SetOutput(outputsName, outputsValue, out _); ExecutionContext.SetOutput(outputsName, outputsValue, out _);
} }
else
{
ExecutionContext.SetOutput(outputsName, "", out _);
}
}
} }
} }
} }