diff --git a/src/Runner.Common/JobServerQueue.cs b/src/Runner.Common/JobServerQueue.cs index b480bf94f..6234b4bdd 100644 --- a/src/Runner.Common/JobServerQueue.cs +++ b/src/Runner.Common/JobServerQueue.cs @@ -17,7 +17,7 @@ namespace GitHub.Runner.Common TaskCompletionSource JobRecordUpdated { get; } event EventHandler JobServerQueueThrottling; Task ShutdownAsync(); - void Start(Pipelines.AgentJobRequestMessage jobRequest, bool resultServiceOnly = false); + void Start(Pipelines.AgentJobRequestMessage jobRequest, bool resultsServiceOnly = false); void QueueWebConsoleLine(Guid stepRecordId, string line, long? lineNumber = null); void QueueFileUpload(Guid timelineId, Guid timelineRecordId, string type, string name, string path, bool deleteSource); void QueueResultsUpload(Guid timelineRecordId, string name, string path, string type, bool deleteSource, bool finalize, bool firstBlock, long totalLines); @@ -96,14 +96,14 @@ namespace GitHub.Runner.Common _resultsServer = hostContext.GetService(); } - public void Start(Pipelines.AgentJobRequestMessage jobRequest, bool resultServiceOnly = false) + public void Start(Pipelines.AgentJobRequestMessage jobRequest, bool resultsServiceOnly = false) { Trace.Entering(); - _resultsServiceOnly = resultServiceOnly; + _resultsServiceOnly = resultsServiceOnly; var serviceEndPoint = jobRequest.Resources.Endpoints.Single(x => string.Equals(x.Name, WellKnownServiceEndpointNames.SystemVssConnection, StringComparison.OrdinalIgnoreCase)); - if (!resultServiceOnly) + if (!resultsServiceOnly) { _jobServer.InitializeWebsocketClient(serviceEndPoint); } @@ -119,7 +119,7 @@ namespace GitHub.Runner.Common { string liveConsoleFeedUrl = null; Trace.Info("Initializing results client"); - if (resultServiceOnly + if (resultsServiceOnly && serviceEndPoint.Data.TryGetValue("FeedStreamUrl", out var feedStreamUrl) && !string.IsNullOrEmpty(feedStreamUrl)) { @@ -545,9 +545,8 @@ namespace GitHub.Runner.Common if (!_resultsServiceOnly) { _resultsClientInitiated = false; + SendResultsTelemetry(ex); } - - SendResultsTelemetry(ex); } } @@ -666,9 +665,8 @@ namespace GitHub.Runner.Common if (!_resultsServiceOnly) { _resultsClientInitiated = false; + SendResultsTelemetry(e); } - - SendResultsTelemetry(e); } if (_bufferedRetryRecords.Remove(update.TimelineId)) diff --git a/src/Runner.Worker/JobRunner.cs b/src/Runner.Worker/JobRunner.cs index 88ac3fc68..cde358dcb 100644 --- a/src/Runner.Worker/JobRunner.cs +++ b/src/Runner.Worker/JobRunner.cs @@ -72,7 +72,7 @@ namespace GitHub.Runner.Worker launchServer.InitializeLaunchClient(new Uri(launchReceiverEndpoint), accessToken); } _jobServerQueue = HostContext.GetService(); - _jobServerQueue.Start(message, resultServiceOnly: true); + _jobServerQueue.Start(message, resultsServiceOnly: true); } else {