From 9821c1399203943e700cdfd859442dd7e2582d3e Mon Sep 17 00:00:00 2001 From: Thomas Boop <52323235+thboop@users.noreply.github.com> Date: Tue, 9 Feb 2021 14:47:58 -0500 Subject: [PATCH] Release 2.277.1 runner (#977) (#978) * Revert "Enable tty output from Docker Actions (#916)" 5972bd00601dae39e1931742bd717014c217fa0b * Release notes * add pr --- releaseNote.md | 11 +++-------- src/Runner.Worker/Container/DockerCommandManager.cs | 3 +-- src/Runner.Worker/Handlers/StepHost.cs | 2 +- src/runnerversion | 2 +- 4 files changed, 6 insertions(+), 12 deletions(-) diff --git a/releaseNote.md b/releaseNote.md index b75320f23..3c265bb54 100644 --- a/releaseNote.md +++ b/releaseNote.md @@ -1,16 +1,11 @@ ## Features - - Verify the Runner Hash during auto-upgrade before installing the new runner version (#967) - - Support download of runners from authenticated endpoints (#920) - - Enabled tty output in Docker Actions (#916) - - Added '--check' command to verify runner connectivity (#949) + ## Bugs - - Fix usage of /dev/null and ping in run.sh (#968) + - Fixed an issue where docker containers failed to initialize (#977) ## Misc - - Updated the copy for various runner messages (#972) - - Added the runner's OS to telemetry (#939) - - Various other telemetry improvements (#935) + ## Windows x64 We recommend configuring the runner in a root folder of the Windows drive (e.g. "C:\actions-runner"). This will help avoid issues related to service identity folder permissions and long file path restrictions on Windows. diff --git a/src/Runner.Worker/Container/DockerCommandManager.cs b/src/Runner.Worker/Container/DockerCommandManager.cs index 4ac0e96b6..8663e9340 100644 --- a/src/Runner.Worker/Container/DockerCommandManager.cs +++ b/src/Runner.Worker/Container/DockerCommandManager.cs @@ -197,8 +197,7 @@ namespace GitHub.Runner.Worker.Container dockerOptions.Add($"--workdir {container.ContainerWorkDirectory}"); dockerOptions.Add($"--rm"); - dockerOptions.Add($"-t"); - + foreach (var env in container.ContainerEnvironmentVariables) { // e.g. -e MY_SECRET maps the value into the exec'ed process without exposing diff --git a/src/Runner.Worker/Handlers/StepHost.cs b/src/Runner.Worker/Handlers/StepHost.cs index 83c70b8e4..0907eaed2 100644 --- a/src/Runner.Worker/Handlers/StepHost.cs +++ b/src/Runner.Worker/Handlers/StepHost.cs @@ -182,7 +182,7 @@ namespace GitHub.Runner.Worker.Handlers dockerCommandArgs.Add($"exec"); // [OPTIONS] - dockerCommandArgs.Add($"-it"); + dockerCommandArgs.Add($"-i"); dockerCommandArgs.Add($"--workdir {workingDirectory}"); foreach (var env in environment) { diff --git a/src/runnerversion b/src/runnerversion index 8b4d7c33c..4ffc935e1 100644 --- a/src/runnerversion +++ b/src/runnerversion @@ -1 +1 @@ -2.277.0 +2.277.1