diff --git a/src/Runner.Common/Constants.cs b/src/Runner.Common/Constants.cs index 979e33d56..33ab3ce04 100644 --- a/src/Runner.Common/Constants.cs +++ b/src/Runner.Common/Constants.cs @@ -159,6 +159,7 @@ namespace GitHub.Runner.Common public static readonly string WorkerCrash = "WORKER_CRASH"; public static readonly string LowDiskSpace = "LOW_DISK_SPACE"; public static readonly string UnsupportedCommand = "UNSUPPORTED_COMMAND"; + public static readonly string UnsupportedCommandMessage = "The `{0}` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/"; public static readonly string UnsupportedCommandMessageDisabled = "The `{0}` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/"; public static readonly string UnsupportedStopCommandTokenDisabled = "You cannot use a endToken that is an empty string, the string 'pause-logging', or another workflow command. For more information see: https://docs.github.com/actions/learn-github-actions/workflow-commands-for-github-actions#example-stopping-and-starting-workflow-commands or opt into insecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_STOPCOMMAND_TOKENS` environment variable to `true`."; public static readonly string UnsupportedSummarySize = "$GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of {0}k, got {1}k. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary"; diff --git a/src/Runner.Worker/ActionCommandManager.cs b/src/Runner.Worker/ActionCommandManager.cs index a705d67ed..e301515da 100644 --- a/src/Runner.Worker/ActionCommandManager.cs +++ b/src/Runner.Worker/ActionCommandManager.cs @@ -307,6 +307,17 @@ namespace GitHub.Runner.Worker public void ProcessCommand(IExecutionContext context, string line, ActionCommand command, ContainerInfo container) { + if (context.Global.Variables.GetBoolean("DistributedTask.DeprecateStepOutputCommands") ?? false) + { + var issue = new Issue() + { + Type = IssueType.Warning, + Message = String.Format(Constants.Runner.UnsupportedCommandMessage, this.Command) + }; + issue.Data[Constants.Runner.InternalTelemetryIssueDataKey] = Constants.Runner.UnsupportedCommand; + context.AddIssue(issue); + } + if (!command.Properties.TryGetValue(SetOutputCommandProperties.Name, out string outputName) || string.IsNullOrEmpty(outputName)) { throw new Exception("Required field 'name' is missing in ##[set-output] command."); @@ -331,6 +342,17 @@ namespace GitHub.Runner.Worker public void ProcessCommand(IExecutionContext context, string line, ActionCommand command, ContainerInfo container) { + if (context.Global.Variables.GetBoolean("DistributedTask.DeprecateStepOutputCommands") ?? false) + { + var issue = new Issue() + { + Type = IssueType.Warning, + Message = String.Format(Constants.Runner.UnsupportedCommandMessage, this.Command) + }; + issue.Data[Constants.Runner.InternalTelemetryIssueDataKey] = Constants.Runner.UnsupportedCommand; + context.AddIssue(issue); + } + if (!command.Properties.TryGetValue(SaveStateCommandProperties.Name, out string stateName) || string.IsNullOrEmpty(stateName)) { throw new Exception("Required field 'name' is missing in ##[save-state] command."); @@ -586,7 +608,7 @@ namespace GitHub.Runner.Worker public void ProcessCommand(IExecutionContext context, string inputLine, ActionCommand command, ContainerInfo container) { ValidateLinesAndColumns(command, context); - + command.Properties.TryGetValue(IssueCommandProperties.File, out string file); command.Properties.TryGetValue(IssueCommandProperties.Line, out string line); command.Properties.TryGetValue(IssueCommandProperties.Column, out string column);