actions/runner
1
0
Fork 0
mirror of https://github.com/actions/runner.git synced 2025-12-12 05:37:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary 'IsAnyUnhealthy' flag

Browse Source
This commit is contained in:
JoannaaKL
2022-09-13 12:44:22 +00:00
parent 76e4f51a21
commit 912d7d6932
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Runner.Worker/ContainerOperationProvider.cs
View File

@@ -100,33 +100,33 @@ namespace GitHub.Runner.Worker
} }
executionContext.Output("##[group]Waiting for all services to be ready"); executionContext.Output("##[group]Waiting for all services to be ready");
bool IsAnyUnhealthy = false;
_dockerManager.UnhealthyContainers = new List<ContainerInfo>(); _dockerManager.UnhealthyContainers = new List<ContainerInfo>();
foreach (var container in containers.Where(c => !c.IsJobContainer)) foreach (var container in containers.Where(c => !c.IsJobContainer))
{ {
var healthcheck = await Healthcheck(executionContext, container); var healthcheck = await Healthcheck(executionContext, container);
if (!string.Equals(healthcheck, "healthy", StringComparison.OrdinalIgnoreCase)) if (!string.Equals(healthcheck, "healthy", StringComparison.OrdinalIgnoreCase))
{ {
IsAnyUnhealthy = true;
_dockerManager.UnhealthyContainers.Add(container); _dockerManager.UnhealthyContainers.Add(container);
} }
else else
{ {
executionContext.Output($"{container.ContainerNetworkAlias} service is healthy."); executionContext.Output($"{container.ContainerNetworkAlias} service is healthy.");
} }
} }
executionContext.Output("##[endgroup]"); executionContext.Output("##[endgroup]");
if (IsAnyUnhealthy) if (_dockerManager.UnhealthyContainers.Count > 0)
{ {
foreach (var container in _dockerManager.UnhealthyContainers) foreach (var container in _dockerManager.UnhealthyContainers)
{ {
executionContext.Output($"##[group]Service container {container.ContainerNetworkAlias} failed."); executionContext.Output($"##[group]Service container {container.ContainerNetworkAlias} failed.");
await ContainerErrorLogs(executionContext, container); await ContainerErrorLogs(executionContext, container);
executionContext.Output("##[endgroup]"); executionContext.Output("##[endgroup]");
} }
throw new InvalidOperationException("One or more containers failed to start."); throw new InvalidOperationException("One or more containers failed to start.");
} }
} }
public void printHello() public void printHello()