From 75a11dac1bda624c706b873921c3ff9961e2b2a7 Mon Sep 17 00:00:00 2001 From: Yang Cao Date: Wed, 27 Sep 2023 09:35:28 -0400 Subject: [PATCH] Do not give us if Results is powering logs --- src/Runner.Common/JobServerQueue.cs | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/Runner.Common/JobServerQueue.cs b/src/Runner.Common/JobServerQueue.cs index 5717894bf..b480bf94f 100644 --- a/src/Runner.Common/JobServerQueue.cs +++ b/src/Runner.Common/JobServerQueue.cs @@ -541,8 +541,11 @@ namespace GitHub.Runner.Common Trace.Error(ex); errorCount++; - // If we hit any exceptions uploading to Results, let's skip any additional uploads to Results - _resultsClientInitiated = false; + // If we hit any exceptions uploading to Results, let's skip any additional uploads to Results unless Results is serving logs + if (!_resultsServiceOnly) + { + _resultsClientInitiated = false; + } SendResultsTelemetry(ex); } @@ -660,7 +663,10 @@ namespace GitHub.Runner.Common { Trace.Info("Catch exception during update steps, skip update Results."); Trace.Error(e); - _resultsClientInitiated = false; + if (!_resultsServiceOnly) + { + _resultsClientInitiated = false; + } SendResultsTelemetry(e); }