notes on todo tasks for refactoring to support different types of steps

This commit is contained in:
Ethan Chiu
2020-07-10 13:51:36 -04:00
parent 9d7bd4706b
commit 747addfca6
3 changed files with 6 additions and 0 deletions

View File

@@ -376,6 +376,7 @@ namespace GitHub.Runner.Worker
{ {
var steps = run.Value.AssertSequence("steps"); var steps = run.Value.AssertSequence("steps");
var evaluator = executionContext.ToPipelineTemplateEvaluator(); var evaluator = executionContext.ToPipelineTemplateEvaluator();
// TODO: Change this so that we process each type of step
stepsLoaded = evaluator.LoadCompositeSteps(steps); stepsLoaded = evaluator.LoadCompositeSteps(steps);
break; break;
} }

View File

@@ -47,6 +47,10 @@ namespace GitHub.Runner.Worker.Handlers
// Add each composite action step to the front of the queue // Add each composite action step to the front of the queue
int location = 0; int location = 0;
// TODO: Assume that each step is not an actionStep
// How do we handle all types of steps?????
foreach (Pipelines.ActionStep aStep in actionSteps) foreach (Pipelines.ActionStep aStep in actionSteps)
{ {
// Ex: // Ex:

View File

@@ -159,6 +159,7 @@ namespace GitHub.DistributedTask.Pipelines.ObjectTemplating
return result; return result;
} }
// Change to return a variety of steps.
public List<ActionStep> LoadCompositeSteps( public List<ActionStep> LoadCompositeSteps(
TemplateToken token) TemplateToken token)
{ {